Re: [PATCH] bfd: Define pagesize variables only for mmap

[Alan Modra <amodra@gmail.com>]

On Mon, Apr 08, 2024 at 07:26:37AM -0700, H.J. Lu wrote:
> On Sun, Apr 7, 2024 at 8:58 PM Simon Marchi <simon.marchi@polymtl.ca> wrote:
> > Since this commit, when building for --host=x86_64-w64-mingw32, I get:
> >
> >
> > make[4]: Entering directory '/home/simark/build/binutils-gdb-x86_64-w64-mingw32/bfd'
> >   CC       libbfd.lo
> > /home/simark/src/binutils-gdb/bfd/libbfd.c: In function ‘bfd_init_pagesize’:
> > /home/simark/src/binutils-gdb/bfd/libbfd.c:1583:19: error: implicit declaration of function ‘getpagesize’ [-Werror=implicit-function-declaration]
> >  1583 |   _bfd_pagesize = getpagesize ();
> >       |                   ^~~~~~~~~~~
> >
> > Simon
> 
> Please try this patch.

You need to revert the change to lynx-core.c as well.

Somewhat related, why does binutils/elfedit.c depend on HAVE_MMAP?
I run into failures with asan builds (ie. -fsanitize=address,undefined
in CFLAGS and CXXFLAGS passed to configure).
elfedit: unrecognized option '--enable-x86-feature'
Apparently HAVE_MMAP configury fusses too much, see this comment:
gnulib/import/m4/mmap-anon.m4:  # Check for mmap(). Don't use AC_FUNC_MMAP, because it checks too much: it

-- 
Alan Modra
Australia Development Lab, IBM