From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com [IPv6:2607:f8b0:4864:20::102e]) by sourceware.org (Postfix) with ESMTPS id 636B03858D3C for ; Wed, 10 Apr 2024 23:54:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 636B03858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 636B03858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712793244; cv=none; b=YoDBh0dmc99zhD9SRdZHD5nx+UWiUmrX4Ro/lrEMcq1ZxiRRtlrHqH8SYmOSIuBL/VC8+y7hQe6K9TX0Zr/mIBAQtPi5pYye9f9esJ1pldFDHyqBy7pKXqX7dRxt7clpOLZz2xsjkl+OBpUSYQWUxu+SqKKXWJMlO7DvWHUU7AA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712793244; c=relaxed/simple; bh=vuAHXED8Aw3W0rySDXjmMfjQWnxN7PK4T6WLYb7ZuFg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=XZMJleaoXy7bMYcNDfn9SN0shVNsQssONHhv+hJdciA3JEt6onABcX0nSne0WRvk9kIT8zbNoJYAHsCuvbQX8W36Sfg0Ge7hiSjLUkLX/Cqa6r8blO2Hu6ZfHRspzSy9f3Ya9evNBm6gf1MZz0Wr7PPtbP+NCWtGGMNl6vHzQIA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-2a2d82537efso4320682a91.2 for ; Wed, 10 Apr 2024 16:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712793241; x=1713398041; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qs7f12I6/9rl/s9y6meKP6dHkjfgd9/DzHK+JAg1RWE=; b=lUKwx69qqbejFT2SMjPbbKX3dK9Dla4UvgdvyGprxJBBpq+cVx2yH/6Rstp+/43CZB kdfA53W6scXrRhfmPJDex8Jc3D841xCFiXuf8sknTEaMbaS9OTUUyr9BdV/37ntBuzmn L439QMe5IeBGsT7mmcso7HTQ1jUvppp1nFtRG7LIIDvBlsP4Wt8X/vlGIfF5a51jZKDe cvkjGb9FCUG/GZwfWDntnzSKqxh9j/cYACA1e5EeBjXLorQcfCKgr1CHOXcTjAg52ITx lbC8LrovdH7M2zTJCK8K1t54n5Xa1k2Q84kWnBxmGuaSfqa58DadDagUHi+/eC5T6ya0 qeNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712793241; x=1713398041; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qs7f12I6/9rl/s9y6meKP6dHkjfgd9/DzHK+JAg1RWE=; b=JXUi8WycuLuUJpJvRlWfP2d7n+iT1+nH9/xzIMrA5mZyTJzCMzk3CM5RfPjIpMSr2q 6V7Ca3FLpcjfZoQybDx7Un96xarq8lvauFAe9Bztw1Gu9Bu9Efjgxe0rso3nkVucuASl yjGLt50POg4SbIlk4pxIRxT3vy/BWAQWfr1KFZ9zFkrqNKUebGHy0DKWsnJKWiUpTRuT O74vpxTfEtqu2NesjecUyJ25WFUKqP0Pclx5aFAIVme9NK9K2hVnj4I7PwqDro5Cc0WT Wn6NXIkkxTKpu3voGWA0tciqhhQ5HiVwOFCktxw68r80OBAUp3ToIInn8Y8NrWv/oXmP zaHg== X-Gm-Message-State: AOJu0Yw8bh23AhDxPIU0sXjCgcsZfYHFvyjPSX/tiggXIJBiljQHL65H orK2a1W1Ii1ycixwGGChXLAX3bcH/SwqegxmDviUavWS2W4e0bI4 X-Google-Smtp-Source: AGHT+IFBls3tG8tl6HpmsjaBTbe5ar8CO35UjpF1AyGBJTbaFYtUg/zdiDbpQ5BbDk855yl69JV3OA== X-Received: by 2002:a17:90a:bb83:b0:2a4:76c8:74da with SMTP id v3-20020a17090abb8300b002a476c874damr4656045pjr.36.1712793241125; Wed, 10 Apr 2024 16:54:01 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:da25:346f:5e55:47ce]) by smtp.gmail.com with ESMTPSA id l24-20020a17090ac59800b002a474e2d7d8sm1918132pjt.15.2024.04.10.16.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 16:54:00 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B18931140084; Thu, 11 Apr 2024 09:23:57 +0930 (ACST) Date: Thu, 11 Apr 2024 09:23:57 +0930 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] mmap: Fix a memory leak in _bfd_mmap_read_temporary Message-ID: References: <20240409230248.2466402-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240409230248.2466402-1-hjl.tools@gmail.com> X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 09, 2024 at 04:02:48PM -0700, H.J. Lu wrote: > Return malloced memory in *mmap_base so that _bfd_munmap_readonly_temporary > will free it. > > * libbfd.c (_bfd_mmap_read_temporary): Return malloced memory > in *mmap_base. OK, I'm assuming you know what you're doing here. -- Alan Modra Australia Development Lab, IBM