From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id A1AA83858D20 for ; Thu, 18 Apr 2024 02:05:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A1AA83858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A1AA83858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713405914; cv=none; b=c3w/AKa0MlcgcEl7s9JhuJB18WfRHa8AEnCSYI3nP2wNG1dvrY50IzW2DwP8JhIIzwSOo9WfEl0k0vAXYQKBttMXl6JMy+wUrPMPWFqJ+mp649fEBDaoQ1j6zuGcKRfw6minGYCvqkzDkTDTrVdndF7ewcw/mj1fVWgvSeDlbAU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713405914; c=relaxed/simple; bh=sLGnVN9oGYXuE3JLudy7MHpxcgJImMK4ry6LYOxpd00=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rPxBLu56whsBwo2nYR82tDOpyJpXV0nb8u476OVB1WDt1QsBIvCNkloexh6W9UrRcjk+yBLHmbZ21+TYohBR6+rBp4jYSYtgdusiEWy05rY3lXiRTOeAEGZHQ0Fbgoqqme0yE/2WtMmtEjwPTUJ1LkJ+7+V5nB8BnzoUWTdoPzc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e455b630acso2823775ad.1 for ; Wed, 17 Apr 2024 19:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713405910; x=1714010710; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G7NsdPB7DB3lKMJL6r8RtaYlTX76XjfSW0SZRe/46kQ=; b=XjkUhhIiVoXCU7lvcAKWULmWvvAKD1ogA5+PI+CfDQuw+Tj3LOBjrg9VMerG2v+tCg pS9XgIMADGvjiMDkj+nqJIUux2ujoApBLqAdsfXr3xi+yFKUtek1/Ee5oqzBL9VzVE3j FyMf7ESN5rrP3jxOJcCsYh6oXwC1e04/0OPi65LiPvoHTjY/IghdAlgajL6+G7WeUxl0 sOsDd9qoym6+Zwx/HMdwpJ5pjKTsrgmTorEzpRDVMYYiX6ZYOPnuubgoz2X1eof/Q29a ix1H+h2SaxnRtVh01YSxITx9Gwrr0wg/FtlLkUxh1mZw+pSyqaFuzbiSYd/guxnHnKsu ZSPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713405910; x=1714010710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G7NsdPB7DB3lKMJL6r8RtaYlTX76XjfSW0SZRe/46kQ=; b=obA1ZMrqy5vSy9tsG0BbTN28Sd6AFRcB6bJqJ0sQnz1U2vwyoRULeBYXjcI9o9MUcz MRKB7ne1LZZUhhxIsBFHS1FrhFl+AokAY40avPlhh3wZQ31bDfB+RJoV7LZ8V3A35++L KQGc0moJ2avhI4tOr1TtsEsxtygDiYQb/Y0KrGc6Dbl8XscA/oShdOGrEoS1rRvKLFop 23AMLOdAraWcx+BP39OyL3+evleFn4WgB56RgiFKT61fCUoL8Dr6touVvEVTjCNPrteW 7azggJyUh2sXWz9BZmfY+0K1jvY4W48Zg86AUpJOdse7/YTV4H+xBwsSEAAmukxf/Rm9 JR3g== X-Gm-Message-State: AOJu0YyoeEz0lF1jq8PpS12/AQtv2EB+D/4M/35VPak+ainnuljw1K3+ OtPKj0ZoDuDea0mPQnBUUVDZmarGtefS8ps+czMErsUTruXBQKUxS3OBtw== X-Google-Smtp-Source: AGHT+IE1Yk3528L49pgEWDrZKTiDcGACkdMtBkapBggTX8WhE8fK0yqkIs26hI/wcY2GFcLc68sCkA== X-Received: by 2002:a17:902:ba87:b0:1e8:674b:d10f with SMTP id k7-20020a170902ba8700b001e8674bd10fmr1356711pls.41.1713405910298; Wed, 17 Apr 2024 19:05:10 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:e156:fdda:9910:2a6e]) by smtp.gmail.com with ESMTPSA id n3-20020a170902e54300b001e41e968a61sm316345plf.223.2024.04.17.19.05.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 19:05:09 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id A409F114005E; Thu, 18 Apr 2024 11:35:07 +0930 (ACST) Date: Thu, 18 Apr 2024 11:35:07 +0930 From: Alan Modra To: Nick Alcock Cc: binutils@sourceware.org Subject: Re: [PATCH 01/22] binutils, objdump: Add --ctf-parent-section Message-ID: References: <20240417202018.34966-1-nick.alcock@oracle.com> <20240417202018.34966-2-nick.alcock@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417202018.34966-2-nick.alcock@oracle.com> X-Spam-Status: No, score=-3026.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Apr 17, 2024 at 09:19:57PM +0100, Nick Alcock wrote: > @@ -4890,13 +4897,36 @@ dump_ctf (bfd *abfd, const char *sect_name, const char *parent_name) > return; > } > > - if ((parent = ctf_dict_open (ctfa, parent_name, &err)) == NULL) > + if (parent_sect_name) { > + psec = read_section (abfd, parent_sect_name, &ctfpdata); > + if (sec == NULL) { > + my_bfd_nonfatal (bfd_get_filename (abfd)); > + free (ctfdata); > + return; > + } Formatting, here and elsewhere in this patch. Open braces go on a line by themselves. if (parent_sect_name) { psec = read_section (abfd, parent_sect_name, &ctfpdata); if (sec == NULL) { my_bfd_nonfatal (bfd_get_filename (abfd)); free (ctfdata); return; } } Patch is OK with these all fixed. -- Alan Modra Australia Development Lab, IBM