From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 5EF993858C35 for ; Fri, 19 Apr 2024 00:25:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5EF993858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5EF993858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713486344; cv=none; b=xxpW3P4Rnk91Y9UgcZX9KwEJ2bRiXmYaH5PFeCUZpGls0tp2+1Y1Z9tLc2cpaiKM/o2oT2Dxl84N3VJ/K8L7nLEs3y24y24EhIdB0H/Ks8T5E1Ojutc3X2Px1lTd1f9J/KXox5Bk4CqNi2NksATIDT14XdDPObFIrrHgpMRR3R0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713486344; c=relaxed/simple; bh=rSLf99i5se8YfvOBROFMtklEyy9TwsLl0+Yn8GddmE4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=oCU3WkuTzLqumLigbgII93G4kUiL8940DtQqwfiJNw6sXwZ3Zl4+JDf1VI+Pd9A7QuUJGFoBrvIHPcRIFLetC0kpzi7gNFLwIIxG6+kSSaQ2vM4hB/0wC+Ymqfzk2tu8cta9kPwDe3TGhDwpxarJrkEAKX+4ou0u7KD66x9k8wI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1e3e84a302eso11512925ad.0 for ; Thu, 18 Apr 2024 17:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713486341; x=1714091141; darn=sourceware.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5tlI4F6u0ji9jer321BAXnXmzYhNHb91h6z8+lfuBdE=; b=URxPFSHiok8q4KP8sz4ugIpx/8WCIp5V/9zficyvdWyoXq5hNNBWx/sFBis2UVbciJ GneDBbFRuZBAOr/n6lAcYpZR8NWALevbuf69KyiixT4PcHu2yDHZMstAytSY3H0S3gSa 5fJfcy/XjdjAvv7fK70Yl77+k46ZaBlk1bXugh9R/yZnQIhdub+gOiOgx4BGnSMiEgVL ZE72E6IRC7XuZT+rOA8iZDsaf+IrwslqQkt0JG42kJm1jvdpd8yrbYXdP75VNKsfplLL RbYntBI3NJnvkUl/sOH65BHndJOwl69vaAX4HR7jBqDnmFmiCXYz2A9vwa/emaxCb2Co GxMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713486341; x=1714091141; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5tlI4F6u0ji9jer321BAXnXmzYhNHb91h6z8+lfuBdE=; b=Pkt8ojIov/ks4t3jqwcr4xLhgFHQ9yKMeLhZNqjgCBiDzJQwoiTi6+pOLnjulJ4FsG HGajpukxwBdQxurKTt3fAGIDuJm5SagBVvTHwWeLnDgnaR0B7SXC2Isj0bCpY4My+RSx ATRljG3Sdrq2kQwAY5v4nnFVb63r5JIQOBfDx7gMKd5WPdn9Jw8EDDKLt10Os07KAOTc N3VXjGpCip9CGcFUd6PdOmXpdcdR78Rt8/s957Dnn39mftP0Zn0nPTUC6HcTc0Iq2a0a dZn1KEEpgcRslX6J1Wq7sp9+9jt81up86vsrcmQRi/9rGpoBcIUfgJ/uOmXya6HP6c9k LCCg== X-Gm-Message-State: AOJu0YzUq15N035KPPatplvq4XlY57pq1WvBAUVktaWTf/4HB/A9IXIX hILSXEAR26ARwEZ6/Mzut9/Sa+OOW/awa9JEADW4vimnE/dX3osXO9tevA== X-Google-Smtp-Source: AGHT+IFjN+i6UMRlrXCRu1oFSJj+aBk7evm3/DJZjkpV2W8WynWW7dpnjyhPw8fBHiVIDIZIvF5seQ== X-Received: by 2002:a17:902:6b86:b0:1e4:1f86:88d6 with SMTP id p6-20020a1709026b8600b001e41f8688d6mr652238plk.17.1713486341084; Thu, 18 Apr 2024 17:25:41 -0700 (PDT) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:2141:f431:e4de:a0ac]) by smtp.gmail.com with ESMTPSA id o24-20020a170902779800b001e5119c0f9asm2123515pll.66.2024.04.18.17.25.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 17:25:40 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 668331140235; Fri, 19 Apr 2024 09:55:38 +0930 (ACST) Date: Fri, 19 Apr 2024 09:55:38 +0930 From: Alan Modra To: Andrew Pinski Cc: binutils@sourceware.org Subject: Re: PR29613, use of uninitialized value in objcopy Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3025.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 18, 2024 at 02:12:27PM -0700, Andrew Pinski wrote: > On Mon, Sep 26, 2022 at 2:56 AM Alan Modra via Binutils > wrote: > > > > PR 29613 > > * elf.c (_bfd_elf_write_secondary_reloc_section): Trim sh_size > > back to relocs written. Use better types for vars. > > Just FYI. I noticed that this adds the use of `%zu` to > _bfd_error_handler but _bfd_error_handler uses ATTRIBUTE_PRINTF_1 > which uses just the printf format which on mingw is different from > other targets (it is an alias to ms_printf rather than an alias to > gnu_printf). So this and other uses `%zu` will cause a warning to show > up because of that. > This was reported to GCC via > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114775 . >From binutils/README: To build binutils you will need a C99 compliant compiler and library. Casting size_t to long in order to print values is just plain wrong, particularly on LLP64 hosts where sizeof(long)==4 and sizeof(size_t)==8. In fact, many places in binutils that use long variables, struct fields or function return values ought to be using size_t or ssize_t. -- Alan Modra Australia Development Lab, IBM