From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by sourceware.org (Postfix) with ESMTPS id D302A3858D33 for ; Fri, 19 Apr 2024 00:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D302A3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D302A3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1034 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713486714; cv=none; b=iie2NXOeYuweWNKmCK0sWU3cqyQ1mujcc2vVi+jBIPCB/500bNiY2bKU1COt4eRF3UsTShXEX3nQpsg0kyf16IgymIIrNjjnISQHnXCKA37SDnDbmghe5ewPlrR4j/psmJSeF+sluw/4sBtk635KqbCPG+HrX8M1yD1NM3wGqSI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713486714; c=relaxed/simple; bh=mrrB9oyppnbKYZg3YzxGohWMX8rTSbkmbpuZGJgcsMA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=CGmAOovYm7LC5yeLKY6gAM99weWyR0OqjZFMs4ju9gnOTqaMUzFN+1FCS6gyVakucJm5zAhkzdR9T8VBz33BU4PRQyxRAvrQUk0S0GnIUA4kl0J3k2Pr5vzsr+A6AzDlioSAyvM0jE/jb68OhhsN5jfdxR7vU8cdB3xCXIGI4pE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-2ab1ddfded1so1238718a91.1 for ; Thu, 18 Apr 2024 17:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713486711; x=1714091511; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=LAt/D2mfKOXJx3G02sxmMvgmnGdmpja51RwHFlcGW9Q=; b=R9vyCbq7EdXVuPJQoHaK6L4C0EjTjJiuZMbskBHI61OCfAK/ynnkqU8N5yZwjv/7lY qn2DKMDszfq5OrVv0547ftVu4RgAE91iRFZAEV9jns/Y/RKfeJOztDTMI1uEMm/gXbQW w2/N48vdXr/jwNdf/2AMqhTxC13dXTTc4BHBq+G3Xf8RknpQgdHgAAroIcxpNa6DT8vm OTuFEI6VrD65ns6Dd3TBZT2jmoHrUilRZWBPjjaQ37DEIVE99DUQLs89C++O/LqahsfH woaa2iInW5gSsZjJaykv9tGaKK3clCwllboPqtCB6ukZkWhO/fp0hq/SGL8o9NXlE/Vp Pblg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713486711; x=1714091511; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LAt/D2mfKOXJx3G02sxmMvgmnGdmpja51RwHFlcGW9Q=; b=B6PqbSiL0EqRsi4XRGIda3GiepGx6cqy512oZa3nBtgHISa7DjME1rch0qbN8b4ltM ecItbNeFTcwpTFj7xrt4aCE2+fJbEbyS+8Lh/P1dkgr7pjGrt1A93AgFEE8A+MOALjuR I8Nh9oiNPGqIwG7IuGpGSNjGUj1e8pTxl8y4ASAKSWU0PeiV48LP9xu/b8iXNLNFZo+a FSf6T5d9sdb7p+8SKVPU0Gbidxn1MkEgHwQl8Cgku5pvjazMbTJWpOpjD6fyCYI6AI+T JoVfT5ZttIF2egiMvyIYEY7F8lQm8D/u0RyFQcl/yGVSlnclUHFJC7flnKdXJNufpLqB 3ixw== X-Gm-Message-State: AOJu0Yx7FAdc95t2wrvWo8V+CBE9IV2TK76iwbL19e5XEaGuYx0DcRE7 qi4zRdi2qY5+IleEa8LD7RAC8NKodsUXXiciZ0RSXYRbCoLlL6+WFhu/sg== X-Google-Smtp-Source: AGHT+IHyuOJ3/QbxNJuda44UFGw/gqJOKB99T8nG2v7P+S7jfqX01ZXIbeG0i0kDVl9KgJbc3rm/eQ== X-Received: by 2002:a17:90b:4f8a:b0:2aa:9738:ad2f with SMTP id qe10-20020a17090b4f8a00b002aa9738ad2fmr824573pjb.6.1713486710518; Thu, 18 Apr 2024 17:31:50 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id bg22-20020a17090b0d9600b002a2f3cfc92asm3770392pjb.16.2024.04.18.17.31.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 17:31:50 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id CA2B91140235; Fri, 19 Apr 2024 10:01:47 +0930 (ACST) Date: Fri, 19 Apr 2024 10:01:47 +0930 From: Alan Modra To: binutils@sourceware.org Subject: mmix disassemble memory leak Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: It's a once-off and of no consequence, but fix it anyway. The mmix caonoicalize_syms array is an array of pointers. Freeing it won't lose symbol names. * mmix-dis.c (initialize_mmix_dis_info): Free syms. diff --git a/opcodes/mmix-dis.c b/opcodes/mmix-dis.c index ea17bfe974a..370da70ed5d 100644 --- a/opcodes/mmix-dis.c +++ b/opcodes/mmix-dis.c @@ -117,6 +117,7 @@ initialize_mmix_dis_info (struct disassemble_info *info) && minfop->reg_name[syms[i]->value] == NULL) minfop->reg_name[syms[i]->value] = syms[i]->name; } + free (syms); } } -- Alan Modra Australia Development Lab, IBM