From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id D56FE3864830 for ; Fri, 19 Apr 2024 07:15:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D56FE3864830 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D56FE3864830 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713510947; cv=none; b=kbzyV91z4X/Vx4K1Fp1afIL6LlxxAip1VbT2Fa3CQKh/zqymnVyuYonMOSDFI/yWu2FF+wIWgn1wtOmJcaSGPiAKQHJsQwSzvmkND7mJbJctf73MoZbxMR797iueDJP79tINo7zv9m0bHBGCoZ+U4RCVgIkMs65oVvIFgUmhobA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713510947; c=relaxed/simple; bh=NqkAzlzIsmQ9NvZ3I2ekST4AlvZNX46GurVfNFLHGU8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=eFjCNOqaCM2Zah5pv1JKSAVBaNKVw1HLXeW2ztIGNsjEAHWz8hD0dR3+6kHCAPvlcbm+puASzlhWa9N5TF8WjsfPnFc297IHGRBlkjrVkU6/xwNAzo46IyXDUrMZ4tYAXnzeOPizVD/AfQ/c93Tm6gpAfd1EP4lPj8FzHUNJi2Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6ea2375d8d0so1368871a34.0 for ; Fri, 19 Apr 2024 00:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713510944; x=1714115744; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FXrIXTmgS5e299IADk8u8bnLZrJNcJhh3uGWxuLD5Zg=; b=cQDlZYQyn33sPLhkOEnuT+mAtMW+Yyi3exOwgGJyvIsWim8xQuJA2MY8NdOGZx9Gq0 0E5zmZyDp00itzeBoCe1UQ5WdIQcd5H07qLNTIHyU12lfi0grFUVSo3Ra9SKmNb+s27v tDC6MihcllTM2ZT7RK09FRvc/n1o5VtzPBSDr2m3/9vMAcxTC1ItTqD51PNzCpmqL5dK 6TvtUhkuytXIGMLWjAbYfauY4shNcgFUsD3Ojv+cKvDHf9lh5XHKQ8uneKra3x1MpO/c CZLzwzwB1bEtRTp+LEkHsjhuv8Wwv4/CmVA1dovsfu/t6Kp5de01Yp4UF55Y194jH7zc ByIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713510944; x=1714115744; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FXrIXTmgS5e299IADk8u8bnLZrJNcJhh3uGWxuLD5Zg=; b=iBU4FRrvyfRNcReFNvhg4d/FVlIgMS7X57TPrPotI+7ITpAIO1PPmCUrILkx2vlbfg EYHzco2mzRt6SbizAHAe2uDhvnXAzjqMWyPMqIalvk1cZz7DYtT+v35lpV7Spc77e1F0 G2CwlRR4b/SDt/gQ1LBYx5cVd/INuxOb/i16VStYeFS/flmBAvSIroAEkqJZ4FIRutoT 2IEbRYakKhk2mVec++fCh/c8tZ77bYda6ZZhDgrDEmtQOoZmJe/cFWzJF1FerPmloh6n eFbpWUfez5cFDODu+3Map07QOky5lApn4x48s9KoPoWu16pOcDOvft2TCYk7sNIaR5Ec OLDA== X-Gm-Message-State: AOJu0YzZE7+2g3I7YiOUKzK/7B8LMYNSM4UR0+JX8LPIRwQpyELkl5Qd k+4jd0NrkCzPT/QFr6HN8vruw+v8RSdf6kuVxNeim7ODoqIUlueBGnHTHA== X-Google-Smtp-Source: AGHT+IGW19BX6Hc7rmQCH1zrB6cBNyXUdb5GjY5Y8F/Ods6QItxrEoQtHGbbWcB4JumROk+CsYO6RA== X-Received: by 2002:a05:6830:1484:b0:6eb:7a3f:ca8 with SMTP id s4-20020a056830148400b006eb7a3f0ca8mr1340674otq.4.1713510944041; Fri, 19 Apr 2024 00:15:44 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id o6-20020a635d46000000b005f769b41a58sm2533903pgm.4.2024.04.19.00.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 00:15:43 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id B531C11400D0; Fri, 19 Apr 2024 16:45:40 +0930 (ACST) Date: Fri, 19 Apr 2024 16:45:40 +0930 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org, oliva@gnu.org Subject: Re: [PATCH] elf: Strip unreferenced weak undefined symbols Message-ID: References: <20240418122856.190234-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240418122856.190234-1-hjl.tools@gmail.com> X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I guess I should have asked if you'd tested this patch. alpha-linux-gnu +FAIL: Generate undefweak-1.a alpha-linux-gnu +FAIL: Generate undefweak-1.o alpha-netbsd +FAIL: Generate undefweak-1.a alpha-netbsd +FAIL: Generate undefweak-1.o alpha-unknown-freebsd4.7 +FAIL: Generate undefweak-1.a alpha-unknown-freebsd4.7 +FAIL: Generate undefweak-1.o d30v-elf +XPASS: Generate undefweak-1.a d30v-elf +XPASS: Generate undefweak-1.o dlx-elf +XPASS: Generate undefweak-1.a dlx-elf +XPASS: Generate undefweak-1.o fr30-elf +XPASS: Generate undefweak-1.a fr30-elf +XPASS: Generate undefweak-1.o frv-elf +XPASS: Generate undefweak-1.a frv-elf +XPASS: Generate undefweak-1.o ft32-elf +XPASS: Generate undefweak-1.a ft32-elf +XPASS: Generate undefweak-1.o iq2000-elf +XPASS: Generate undefweak-1.a iq2000-elf +XPASS: Generate undefweak-1.o mn10200-elf +XPASS: Generate undefweak-1.a mn10200-elf +XPASS: Generate undefweak-1.o msp430-elf +XPASS: Generate undefweak-1.a msp430-elf +XPASS: Generate undefweak-1.o mt-elf +XPASS: Generate undefweak-1.a mt-elf +XPASS: Generate undefweak-1.o pj-elf +XPASS: Generate undefweak-1.a pj-elf +XPASS: Generate undefweak-1.o powerpc64-freebsd +FAIL: ld-powerpc/relbrlt powerpc64le-linux-gnu +FAIL: Build pr26391-3 powerpc64le-linux-gnu +FAIL: Build pr26391-4 powerpc64le-linux-gnu +FAIL: Run pr26391-3 powerpc64le-linux-gnu +FAIL: Run pr26391-4 powerpc64le-linux-gnu +FAIL: ld-powerpc/relbrlt powerpc64-linux-gnu +FAIL: Build pr26391-3 powerpc64-linux-gnu +FAIL: Build pr26391-4 powerpc64-linux-gnu +FAIL: Run pr26391-3 powerpc64-linux-gnu +FAIL: Run pr26391-4 powerpc64-linux-gnu +FAIL: ld-powerpc/relbrlt powerpc-eabisim +FAIL: ld-powerpc/relbrlt powerpc-eabivle +FAIL: ld-powerpc/relbrlt powerpcle-elf +FAIL: ld-powerpc/relbrlt powerpc-linux-gnu +FAIL: ld-powerpc/relbrlt s12z-elf +XPASS: Generate undefweak-1.a s12z-elf +XPASS: Generate undefweak-1.o xgate-elf +XPASS: Generate undefweak-1.a xgate-elf +XPASS: Generate undefweak-1.o I'm applying the following to fix the powerpc failures, I'll leave the rest to you. PR ld/31652 * elflink.c (_bfd_elf_link_output_relocs): Don't segfault on NULL rel_hash. diff --git a/bfd/elflink.c b/bfd/elflink.c index 4f72d1b2a90..6db6a9c0b47 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -2985,12 +2985,13 @@ _bfd_elf_link_output_relocs (bfd *output_bfd, * bed->s->int_rels_per_ext_rel); while (irela < irelaend) { - if (*rel_hash) + if (rel_hash && *rel_hash) (*rel_hash)->has_reloc = 1; (*swap_out) (output_bfd, irela, erel); irela += bed->s->int_rels_per_ext_rel; erel += input_rel_hdr->sh_entsize; - rel_hash++; + if (rel_hash) + rel_hash++; } /* Bump the counter, so that we know where to add the next set of -- Alan Modra Australia Development Lab, IBM