From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 532533858D38 for ; Tue, 23 Apr 2024 11:41:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 532533858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 532533858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::135 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713872471; cv=none; b=U8SXFGZlZrjELiM4xDBkRRS0aEi5X8MyXkN/TkvMWwD2efQNiYtQMPYt748G2UOxPUONmngWfOGD5ny8HuEbbHlOFpNhR1t8b9rEJ4F/utFLuX2KPOlYLFLcS9KYceIhXcUE0IPYozpyF299JuUu4KiTJug+9km4hvkX8tdY1HU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713872471; c=relaxed/simple; bh=DNZFrS7qTRUswdxNPlQ5oyqa/ea6bsa53ty2xem62iY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=m9/z+w1XlfBlO1BYBjr4VXPHgPsLlWaWqKx9lD0VX6ifvb3O1oreowULpVc08mKI51SFlzn2qday+d9KcikBnDpd+Fik1SZYp65YClT+qC6zcjhNjs33xK9Jtwa8kxYBHAQi2VwaPJ0Vyk8zYcRFDrjEtzKJMZwpEBwo+iBlYaM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-36bff60429cso15286965ab.2 for ; Tue, 23 Apr 2024 04:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713872466; x=1714477266; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=jAjZRwzj/8PPbROERf9cT8pRmgsJXHX1mAWOJ8NuomY=; b=noxOJqbO8EAgF05/z0ZWt0e1mKzOsJ20YqhU2wt/wpSX1vUATzWgV0m1W4GGdqerEk hkQT682vGgADs+5FRp0+7hTFCToQCqz9BqpzvMe7gC4HXkf28+RMhX4KdAtuujXrsBKh fp2/8JY/DVefn07yqQDTDB0+x6cSc/Pu0a8Miv+1HXDe3m1a6tTd8WU0R+VDGxrmDj8s rgN2/2u0Rt1bkOXXDeqjxsrih5vvLiZqDZWuwjMWUmrLvuHB6GQjx51Mnv7bo0maii1H qghLSqm4DKqJ6Kr1bDuU2xFeJnJXdwIqu/Pav9McE2GPqnIBPfeuP3qnIGPkW4LWMKdF YoZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713872466; x=1714477266; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jAjZRwzj/8PPbROERf9cT8pRmgsJXHX1mAWOJ8NuomY=; b=Xl4B7v5yAHrsIBTNHC+akA7/y1jkszMh994W6n74lvs9+q+yzZ9gzLFejXkH9FN3ba YD6syFDBIroFzVRh4qNJZDIsoNZSfAPvjyVb60lWyPGpeazHZf9N0CN8lZOs3nPfsV2l xHULmX8kKRGcCwd17v8Hby6X1WOV/2hEE3iD5/VoteXEQ6TQvoaw0VABHXZrBIan/Hh6 RW4uxckwULkUhYQEprRZmbAZkvU6y07W6LPNYxIxiDYmdPCaw3oqv0S/fJ2IIojwLszF gwWkiA9SPQUJvpPyVetE5RE2aKtbfOhwUZ3P6WPJSNwqwkEO0nImpp8F73ksJrpRViBB TpFQ== X-Gm-Message-State: AOJu0Yw9F9TKO2Zp1kxSX63z36j108jPeMABpSE+zf4sL0kCBzo1c5Di Yzc7fsYrdHBSdZ1P4ffYuFgsFkSvynLNph2H7yayQOzDjzqH+W3ynhRESg== X-Google-Smtp-Source: AGHT+IHBG3+dKl3LoJaYo1ZlrntasqHx0TLkzgbrPnKI24m+soD1wp9vAfVBO62MlBpp/DidKpBvXA== X-Received: by 2002:a05:6e02:12e5:b0:36a:88f0:1e81 with SMTP id l5-20020a056e0212e500b0036a88f01e81mr18427731iln.6.1713872466060; Tue, 23 Apr 2024 04:41:06 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id z23-20020a656657000000b005f8072699e1sm5746155pgv.45.2024.04.23.04.41.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 04:41:05 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 556A211426DB; Tue, 23 Apr 2024 21:11:02 +0930 (ACST) Date: Tue, 23 Apr 2024 21:11:02 +0930 From: Alan Modra To: binutils@sourceware.org Subject: copy_private_symbol_data Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: bfd_copy_private_symbol_data is a bfd function that appeared in commit 89665c8562da a long time ago, but seemingly wasn't used anywhere until Jan added it to gas/symbols.c in commit 6a2b6326c21e. The function is used to modify ELF symbol st_shndx for symbols defined in odd sections like .symtab, so that they get the corresponding section st_shndx in an output file. This patch fixes some bitrot in the function. After commit c03551323c04 which introduced output_elf_obj_tdata, elf_strtab_sec and elf_shstrtab_sec will segfault if used on an input bfd. PR 14493 * elf.c (_bfd_elf_copy_private_symbol_data): Don't use elf_strtab_sec and elf_shstrtab_sec. diff --git a/bfd/elf.c b/bfd/elf.c index 52a6a2f56c3..41ec649ebab 100644 --- a/bfd/elf.c +++ b/bfd/elf.c @@ -8785,9 +8785,9 @@ _bfd_elf_copy_private_symbol_data (bfd *ibfd, shndx = MAP_ONESYMTAB; else if (shndx == elf_dynsymtab (ibfd)) shndx = MAP_DYNSYMTAB; - else if (shndx == elf_strtab_sec (ibfd)) + else if (shndx == elf_elfsections (ibfd)[elf_onesymtab (ibfd)]->sh_link) shndx = MAP_STRTAB; - else if (shndx == elf_shstrtab_sec (ibfd)) + else if (shndx == elf_elfheader (ibfd)->e_shstrndx) shndx = MAP_SHSTRTAB; else if (find_section_in_list (shndx, elf_symtab_shndx_list (ibfd))) shndx = MAP_SYM_SHNDX; -- Alan Modra Australia Development Lab, IBM