From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 2EE193858402 for ; Tue, 23 Apr 2024 11:41:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EE193858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2EE193858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713872512; cv=none; b=K3aL2OJh5pU80lCGMYqh+TmgiFqqRNornwaxBHN94tO9swJaBZ2e2BykEp3rON0WQKlFX6Xf+7XpfenWMZbFFeTomsqfMUilOQ9/Ma0zIfFx9Am+k1Nadbx7tgaJYi4oiCZ9YQWrTm3ivIKuL3Fzfaf2luTq0qm0G50A0eNJQUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713872512; c=relaxed/simple; bh=GeMAiqbP2arImi7o+tuOBuzMtHwepDsvBgTllZxuWDI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nuZniu84g05UK2klKE+Or+oFL2D22WZQwy2kr8jPITGzNn3+O/nDg6LPZlS1H2Bpy3HIonVhnsyvgKGXL9EzGDaXgYrhbAjJbqiE7Ww0ybeSNJMTQBOghxdYIW2mGPq5jkz/yNg89x1VgrqjSMmyGWN4NuvtJm7pkj1QAATLKPs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1e3f6f03594so40969835ad.0 for ; Tue, 23 Apr 2024 04:41:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713872510; x=1714477310; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=kIVdOYKSaWa0WnuEuT2dM/RL8djmadRZVCEFaHz2xGA=; b=ZGhPK1DS2ai77vRmSjXIIh2gHaup+YzSggAzeUX4eRTTJoI0uRDBk0trX/MTTUxaEK ROqGVHhUUC3oijCczMrxK9sRvzqv2XkxMYLOJw+FCajgIH9OjgLjPfcQVc6LQ+hlqwa7 3vgrlg/pZ3Gf5tVu2ejpX8M0sdIjANw1wlgmSd+xmvQWPaXN929HgCdm6QV7uj7ZDXem yrWbWAaYm9gd0qBVcZka1YHw5o2I5ukeEQQ2CMcc3wZ1wFWGecDVXCVHScizcyParG2D L4iONblmKR8BxtAN9kXED6ROs4JXP1x0eMMs3grWp2pSw+8CaNJKOohX0xE61Jkd3qa6 m86w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713872510; x=1714477310; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kIVdOYKSaWa0WnuEuT2dM/RL8djmadRZVCEFaHz2xGA=; b=OKZXgcNadrWFnAjT7ZMZoA4/iidl8fdk2j7r1U7YWrZKwd2gMSq3Uhp2uKos2siCdF Qjli9ViKM0xtBevO6DKKzxs7t6YYrIppTEOtZZNiqGky6gPKMsojWBSYi21UQSqL3u4T dmL6YdcgWBYjqbF/xBg7/J4t0nO3qykQCo4jLetBgzxa6L5H8RWolB310CvhT9KyZ9U2 Q+09Nnn2B6VNPlUrqSz918ZvhIMjH172vbv4i1Y2v3bkAV+kTfShqRgbBp2A4pFN15Ku TD+eldamPY2zkKSsI5Op+M3wrdnrGAnMK8cn9ugugYzQRqcTzMMd1QkxuY9hSEwNdvDh mpyw== X-Gm-Message-State: AOJu0YweBfmJQjPdEaSK54TwSrPTZXpNQtK4u0x1l1jKjWO2boZCajsn G9iP7X/B7G2JCeVzpjw6c+FmyYEMgF0Ca2nkh6IYJCrK4nLOY9scpInmDg== X-Google-Smtp-Source: AGHT+IEDngAsjxYpS23cCLEdS0ZjHyvw50Ltvz7QtVncJUGEfvZwGYQ2nErSzOD8osw61logZbVkgA== X-Received: by 2002:a17:902:d4cf:b0:1e7:b6f4:971 with SMTP id o15-20020a170902d4cf00b001e7b6f40971mr14873591plg.27.1713872509400; Tue, 23 Apr 2024 04:41:49 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id k9-20020a170902c40900b001e3f54f90ecsm9804621plk.300.2024.04.23.04.41.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 04:41:48 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id AC6E21142750; Tue, 23 Apr 2024 21:11:45 +0930 (ACST) Date: Tue, 23 Apr 2024 21:11:45 +0930 From: Alan Modra To: binutils@sourceware.org Subject: use copy_private_symbol_data in objcopy Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: osympp appearing twice here is not a bug. PR 14493 * objcopy.c (copy_object): Run the symbols through bfd_copy_private_symbol_data. diff --git a/binutils/objcopy.c b/binutils/objcopy.c index d91ba123c01..634ebae3fc3 100644 --- a/binutils/objcopy.c +++ b/binutils/objcopy.c @@ -3380,6 +3380,13 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount); } + for (i = 0; i < symcount; i++) + if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])) + { + status = 1; + return false; + } + if (dhandle != NULL) { bool res; -- Alan Modra Australia Development Lab, IBM