From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id BCA43385840D for ; Tue, 23 Apr 2024 23:48:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BCA43385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BCA43385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713916104; cv=none; b=ntXxvEgR8dNsW9Wqd1v7XZcTHx6QmtQRzEkyr1YibsfLFJuuIVAME5eFnZxCCAlIrPG5tmZk/Y3bnv8SijoC+zS2homC2Z3NZC7PB5aeLrzeJ37qaOaHs0A4b+BuQ58FrvRK8mkHGaje3jKeBfZ+KE8gO2w+1jwIukVZLosrBrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713916104; c=relaxed/simple; bh=73h0f71D5aKoGLniCdPKpDuMt8MYfuYTl/rpb0uort8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=WOgyCqdTR5W5gw/6T6sGx9LeVM4U5WlSe18taMWQ5o8AxEWZxPca1Atywk1rMjKYt0XYzdQhtkMMr3zELVwmcidlnh1NstfOAN9SHpcZqrLVhlBPsOGh1cjEHaaNkzIvbzaQVRr3hg9d/BysoibhcwOQjUcce0Xvgc85SK6hAIU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6eddff25e4eso5327777b3a.3 for ; Tue, 23 Apr 2024 16:48:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713916098; x=1714520898; darn=sourceware.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BEq5spEWj2wrc9kMYx2ocNcXU9Y8Mt995RHN6SBVrWU=; b=WB5BDifTwN0+LDF6rds3iKP6h825ddHHoGglN17M+PCLBQOQcJQcQCtfMrFA4v9wdP ZyWebt9hYjgopGGFHkka/NWNG7qwA5Mq6vc3FGnwmV74LVAjcY068NjEEtxscs3y/aQR goLqjMzDcsW97Udr2/98K22hI+Nz2hUlf7F8W9Udz75UlclyoT5qiZ31VRu9kmnCjJHz fea6tXewYCXPe8ueVP+lDCul0+q/gEAU8bfdUIqzVKONGSFRjHCobPZ4+yoilfZHoXG+ moKwwYjUXdIzsV5q/blckXRRhRn0zz3gQ1UJW1DvbbRJf+L14H/s8jCIrMuyWWDlScqI dkIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713916098; x=1714520898; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BEq5spEWj2wrc9kMYx2ocNcXU9Y8Mt995RHN6SBVrWU=; b=FOmdm/RePVjxImNO5kAeLOHI3rK7UZd6RhCmcIm2l0Dluy1GeqigmWkUc3EGinh3rh x/C5nHvlaUtBzwXu63Vvjm31kFtLvb4f9qai8Lg5fd24NIwINr7Kln+kv7EmANRvCNSq dsooPXFxcTQYp2b3sbTAUmGYwzfhJn8x/tT+UmB/lRnkHTmZwNVjnfTyPb9aM716VXFA UXw2qADhtqC8+X2Ioc+CfBMj31Rqr8TAnG52VsU7HpzHhkPF989FUko8VWFkupAykLOM RtsBNeC375ZaOn2hP8/9I0OZXkAVWCwp74LVXpnYvqtWj9IvddRLHSMrJwtyF4hMtT9A PYrA== X-Gm-Message-State: AOJu0YwMUOh3VhCW43P9l9xpETGThC6tFkDCEykmhaaimh1X7jwbui+p S+kHC3/hqS6RSV3iLKPejysmNBrdIEQJXpC5Nj7LQWJGSok9jJaM X-Google-Smtp-Source: AGHT+IHxwwVV5L4CaZIsKugL7f2lExvEc3I90oCxbSlwmb/vY8O/rhkeJTQuudiJoHfm+v4XL0FHIQ== X-Received: by 2002:a05:6a20:43a4:b0:1a3:72d2:c430 with SMTP id i36-20020a056a2043a400b001a372d2c430mr1040776pzl.51.1713916097522; Tue, 23 Apr 2024 16:48:17 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id j17-20020aa783d1000000b006ecf00c1dd5sm10183120pfn.120.2024.04.23.16.48.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 16:48:16 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 5A9DF114015E; Wed, 24 Apr 2024 09:18:14 +0930 (ACST) Date: Wed, 24 Apr 2024 09:18:14 +0930 From: Alan Modra To: "H.J. Lu" Cc: binutils@sourceware.org Subject: Re: [PATCH] objcopy.c: Fix bfd_copy_private_symbol_data on 32-bit hosts Message-ID: References: <20240423141324.1156583-1-hjl.tools@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-3033.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 23, 2024 at 08:30:03AM -0700, H.J. Lu wrote: > On Tue, Apr 23, 2024 at 7:13 AM H.J. Lu wrote: > > > > Use long with bfd_copy_private_symbol_data to fix > > > > .../binutils/objcopy.c: In > > function ‘copy_object’: > > .../binutils/objcopy.c:3383:17: error: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘long int’ [-Werror=sign-compare] > > 3383 | for (i = 0; i < symcount; i++) > > | ^ > > > > on 32-bit hosts. > > > > PR binutils/14493 > > * objcopy.c (copy_object): Use long with > > bfd_copy_private_symbol_data. > > --- > > binutils/objcopy.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/binutils/objcopy.c b/binutils/objcopy.c > > index 634ebae3fc3..e8ca1374935 100644 > > --- a/binutils/objcopy.c > > +++ b/binutils/objcopy.c > > @@ -3380,8 +3380,8 @@ copy_object (bfd *ibfd, bfd *obfd, const bfd_arch_info_type *input_arch) > > symcount = filter_symbols (ibfd, obfd, osympp, isympp, symcount); > > } > > > > - for (i = 0; i < symcount; i++) > > - if (!bfd_copy_private_symbol_data (ibfd, osympp[i], obfd, osympp[i])) > > + for (long s = 0; s < symcount; s++) > > + if (!bfd_copy_private_symbol_data (ibfd, osympp[s], obfd, osympp[s])) > > { > > status = 1; > > return false; > > -- > > 2.44.0 > > > > Tested on Linux/x86-64 and Linux/i686. I am checking it in. Thanks. I neglected my 32-bit --enable-targets=all build. For anyone wondering how you can do a 32-bit build on an x86_64-linux box, the following does the trick. CC="gcc -m32" CXX="g++ -m32" \ ~/src/binutils-gdb/configure --build=i686-linux --enable-targets=all \ --enable-gold --enable-threads --disable-gdb --disable-gdbserver --disable-sim \ --disable-readline --disable-libdecnumber --disable-libbacktrace -- Alan Modra Australia Development Lab, IBM