From: Szabolcs Nagy <szabolcs.nagy@arm.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v2 2/2] aarch64: Test DT_RELR with discarded sections
Date: Thu, 6 Jun 2024 09:08:57 +0100 [thread overview]
Message-ID: <ZmFumSL+RV1EVm5A@arm.com> (raw)
In-Reply-To: <ZmEPh_v5tL-BeCF4@squeak.grove.modra.org>
The 06/06/2024 10:53, Alan Modra wrote:
> On Tue, Jun 04, 2024 at 06:41:45PM +0100, Szabolcs Nagy wrote:
> > --- /dev/null
> > +++ b/ld/testsuite/ld-aarch64/relr-discard-pie.d
> > @@ -0,0 +1,15 @@
> > +#source: relr-discard.s
> > +#ld: -pie --no-apply-dynamic-relocs -z pack-relative-relocs -T relr-discard.ld
> > +#readelf: -rW
> > +
> > +Relocation section '\.rela\.dyn' at offset 0x1.* contains 4 entries:
> > + Offset Info Type Symbol's Value Symbol's Name \+ Addend
> > +0000000000000000 0000000000000000 R_AARCH64_NONE 0
> > +0000000000000000 0000000000000000 R_AARCH64_NONE 0
> > +0000000000000000 0000000000000000 R_AARCH64_NONE 0
> > +0000000000000000 0000000000000000 R_AARCH64_NONE 0
> > +
>
> I must say I don't really like matching bad behaviour in a test, but I
> guess this ensures you don't have both .rela.dyn and .relr.dyn relocs
> against G_O_T, so OK.
i think we can fix relr behaviour and the test once
https://sourceware.org/bugzilla/show_bug.cgi?id=31847
is fixed, i will add a comment.
prev parent reply other threads:[~2024-06-06 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 17:41 [PATCH v2 0/2] aarch64: fix " Szabolcs Nagy
2024-06-04 17:41 ` [PATCH v2 1/2] aarch64: Fix DT_RELR support " Szabolcs Nagy
2024-06-06 1:17 ` Alan Modra
2024-06-06 7:57 ` Szabolcs Nagy
2024-06-04 17:41 ` [PATCH v2 2/2] aarch64: Test DT_RELR " Szabolcs Nagy
2024-06-06 1:23 ` Alan Modra
2024-06-06 8:08 ` Szabolcs Nagy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmFumSL+RV1EVm5A@arm.com \
--to=szabolcs.nagy@arm.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).