Re: [PATCH 0/3] GAS/testsuite: Make sure none.s is not overwritten

[Alan Modra <amodra@gmail.com>]

On Tue, Jun 11, 2024 at 12:51:18PM +0100, Maciej W. Rozycki wrote:
> Hi,
> 
>  Previously I have reported:
> 
> FAIL: Output file must be distinct from input
> 
> regressions, where the fallout is that gas/testsuite/gas/all/none.s gets 
> overwritten causing:
> 
> FAIL: gas/all/none
> 
> regressions for any subsequent test runs using the same source tree.  
> 
>  Running the testsuite is not supposed to clobber the sources and the 
> causing test is dangerous in that it specifies a file in the source tree 
> both as an input source file and the output object file for GAS, relying 
> on GAS refusing to overwrite its input, the sole purpose of the test, and 
> allowing for GAS clobbering it, should it fail the test.  
> 
>  This mini patch series addresses the issue, by copying input from the 
> source tree to the test temporary directory and operating on it there.  A 
> couple of helper TCL procedures have been defined, which is what the 
> introductory patches are for.
> 
>  No regressions across my usual list of targets, counting total 239 right 
> now, and the intermittent regressions removed.
> 
>   Maciej

Thanks, the series looks good.  Please apply.

-- 
Alan Modra