public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] x86: Don't check if AVX512 template requires AVX512VL
Date: Wed, 21 Jun 2023 12:04:29 +0200	[thread overview]
Message-ID: <a0ad3bb4-79cf-4f75-5c61-0114c6531f9b@suse.com> (raw)
In-Reply-To: <20230620164436.432481-1-hjl.tools@gmail.com>

On 20.06.2023 18:44, H.J. Lu via Binutils wrote:
> If the ZMM operand in an AVX12 template also allows XMM or ZMM, this
> template must require AVX512VL.  Drop the AVX512VL requirement check
> on such AVX512 templates.
> 
> 	* config/tc-i386.c (check_VecOperands): Don't check if AVX512
> 	template requires AVX512VL.
> ---
>  gas/config/tc-i386.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

I notice you've committed this change already. May I please ask that
you wait a little with committing any patches where there is a chance
that there are going to be comments? (Typically I wait for at least a
week unless it's a clear bugfix.)

Jan

      parent reply	other threads:[~2023-06-21 10:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 16:44 H.J. Lu
2023-06-21  6:52 ` Jan Beulich
2023-06-21 16:06   ` H.J. Lu
2023-06-22  9:00     ` Jan Beulich
2023-06-23  5:59       ` Jan Beulich
2023-06-21 10:04 ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0ad3bb4-79cf-4f75-5c61-0114c6531f9b@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).