From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Nick Clifton <nickc@redhat.com>, Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 1/4] include: Add macro to ignore -Wuser-defined-warnings
Date: Wed, 21 Sep 2022 15:13:25 +0900 [thread overview]
Message-ID: <a0cf9df0-75e0-5e07-06e0-39a5c39cb4ec@irq.a4lg.com> (raw)
In-Reply-To: <5333c388-9fc9-1a45-01da-835ad81541cc@redhat.com>
On 2022/09/21 1:36, Nick Clifton wrote:
> Hi Tsukasa,
>
>> +# if __has_warning ("-Wuser-defined-warnings")
>
> I have not seen __has_warning () before. Is this a new feature of
> recent GCCs and Clang, or am I just behind the times ?
Nick, this is one of the Clang language extensions:
<https://clang.llvm.org/docs/LanguageExtensions.html#include-file-checking-macros>
and already used in Binutils, include/diagnostics.h:58 (latest master)
# if __has_warning ("-Wenum-compare-switch")
This and my new line with __has_warning are surrounded by "#if defined
(__clang__)" (a Clang-only part of the code) and should not expand to a
non-zero value unless:
1. __has_warning is implemented as either a Clang extension
or a custom macro (I will not assume this for obvious reasons).
2. Builtin __has_warning (as I assumed above) detects given warning
is implemented.
__has_warning is a Clang extension but similar standard feature testing
macros with arguments are defined in recent C++ versions (not usable as
standard language features in Binutils, though):
- __has_include (C++17 or later)
- __has_cpp_attribute (C++20 or later)
Thanks,
Tsukasa
>
> Cheers
> Nick
>
next prev parent reply other threads:[~2022-09-21 6:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 3:10 [PATCH 0/4] gdb: (includes PR28413), Suppress some general warnings if built with Clang Tsukasa OI
2022-09-15 3:10 ` [PATCH 1/4] include: Add macro to ignore -Wuser-defined-warnings Tsukasa OI
2022-09-20 16:36 ` Nick Clifton
2022-09-21 6:13 ` Tsukasa OI [this message]
2022-09-22 13:02 ` Enze Li
2022-09-15 3:10 ` [PATCH 2/4] include: Add macro to ignore -Wunused-but-set-variable Tsukasa OI
2022-09-15 3:10 ` [PATCH 3/4] gdb/unittests: PR28413, suppress warnings generated by Gnulib Tsukasa OI
2022-09-15 3:10 ` [PATCH 4/4] gdb: Suppress "unused" variable warning on Clang Tsukasa OI
2022-09-22 8:25 ` [PATCH v2 0/4] gdb: (includes PR28413), Suppress some general warnings if built with Clang Tsukasa OI
2022-09-22 8:25 ` [PATCH v2 1/4] include: Add macro to ignore -Wuser-defined-warnings Tsukasa OI
2022-09-22 11:26 ` Nick Clifton
2022-09-22 8:25 ` [PATCH v2 2/4] include: Add macro to ignore -Wunused-but-set-variable Tsukasa OI
2022-09-22 11:27 ` Nick Clifton
2022-09-22 8:25 ` [PATCH v2 3/4] gdb/unittests: PR28413, suppress warnings generated by Gnulib Tsukasa OI
2022-10-18 13:44 ` Enze Li
2022-09-22 8:25 ` [PATCH v2 4/4] gdb: Suppress "unused" variable warning on Clang Tsukasa OI
2022-10-12 17:36 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0cf9df0-75e0-5e07-06e0-39a5c39cb4ec@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).