From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 5C2B63858C78 for ; Tue, 12 Dec 2023 08:45:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C2B63858C78 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C2B63858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702370749; cv=none; b=dssN+pLFj0qbOTrOSAlBqfQGVZPtzeHMY1748xcDTaMyFR0Z3GaZTUmqQENLpxnaVt4ZRnmIoEEVFZ+iuB9LU7WTVp1/QYNgP7gjRDpocdOur87dHcGHSoJIw74J5Yk0fFbF7liwTOsdniyx9z9LxK+dszCk4dR9P/Cl8i8Dxr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702370749; c=relaxed/simple; bh=noCox+DCK9fBMK5jECiQNK9pLlTW20HaIOvfyde4KYQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=G5K3uXTpxhfMm1KKYZGp97PFrhDHdtFPGsy+Bg9kLWlO1MLycoSt2jQGFJxKozbTHZzLVYg4Ls7D/pyuypZVPqmMElauOcaytqoZYM+3v6SJ3bGAL3bfrswPEy5b4CDmw+Eu3dDRvSrxxknM8EjiVIUYp0L/1cTdOPst0m2U/ts= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a1db6816177so667110966b.0 for ; Tue, 12 Dec 2023 00:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1702370747; x=1702975547; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OnCvCAfVWjZLbs95z0K12sffruVfhtweh/E+R9sLN6c=; b=gRTQVQq2H//eVU8/gCKiOTmXB+S1ndvDrhMCurjbSyDIeuDj2TmwzWiK8E7Hd/bjb1 5A3IM6J8kub6tGcrsy0eIAZ46FpZvhgCao+Tz5yIDyEiNHW1zZSBUkDDqgiEFJNM+96v JHl5ayusesW2mbxQ5Ws5NkQ9F9RG+gQUFHTZiFTxComa6UGfkg9GrapIgz+JMw4WSNCp McJQUUguxlI58MLoaEDFNYwF8Z2P5Kz9ss7H2VUlaM85Kf00Qx6SltrbsouhPl545Q2D RZIGhPvErpG2DOr5ChJYKybGu5wWE4OWJeUSHbRjs6yrPzVcmXCC9/zVOojBV/6s8dP3 MjHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702370747; x=1702975547; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OnCvCAfVWjZLbs95z0K12sffruVfhtweh/E+R9sLN6c=; b=CHQVW6Bz7zI7h4THkYv3x+OxgzL65rz8024gcQEEhcnKZh0W6axEAcqNM3FDqmCZkM oCGdKtLZdmA6lRm/RULfEnv4LuzetuyXHlMtQ9ZHXBFGu61s7sFTOSuzeMsWPY/2c3RH JVhqSeIbZeaEzRtiZ+SLReElDQSNQRNjOPjjWRs2xXpF8oXnHD1SKyn0nlF07LFCCEqw /LM4fN04c9DGnZ22OikAcltQQ1jNheLG6okz2TLm+2vdxeP7xwohqarTOClot5rnnhzH DtLnh54KUtDF2TYRzVBP+yWUFUCuUkvQ8sH8u35w1LwGfNthtkODE0wYC0ISpgIL/I9J h1ng== X-Gm-Message-State: AOJu0Yyp5osoweTeqjxhIH61JE444Fe31TEnyXdlmRO98qH93Q8PaxsD vPxE2vTTLYtSbD9XtzFa5MNI X-Google-Smtp-Source: AGHT+IFBbwTjOZfFOqfvMEXvXmj2cdtENnfuEcgfIg+2P0fIdzS43CUjgkJp+ROqn26l/QvsTLWrOA== X-Received: by 2002:a17:906:1083:b0:a19:a19b:426a with SMTP id u3-20020a170906108300b00a19a19b426amr1582345eju.213.1702370747312; Tue, 12 Dec 2023 00:45:47 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id un5-20020a170907cb8500b009ff77c2e1dasm5855847ejc.167.2023.12.12.00.45.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 00:45:47 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 09:45:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 8/9] Support APX NDD optimized encoding. Content-Language: en-US To: "Hu, Lin1" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" , "Cui, Lili" References: <20231124070213.3886483-1-lili.cui@intel.com> <20231124070213.3886483-8-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12.12.2023 04:18, Hu, Lin1 wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, December 11, 2023 8:28 PM >> >> On 24.11.2023 08:02, Cui, Lili wrote: >>> --- a/gas/config/tc-i386.c >>> +++ b/gas/config/tc-i386.c >>> @@ -7148,6 +7148,58 @@ check_APX_operands (const insn_template *t) >>> return 0; >>> } >>> >>> +/* Check if the instruction use the REX registers. */ static bool >>> +check_RexOperands () { >>> + for (unsigned int op = 0; op < i.operands; op++) >>> + { >>> + if (i.types[op].bitfield.class != Reg) >>> + continue; >>> + >>> + if (i.op[op].regs->reg_flags & (RegRex | RegRex64)) >>> + return true; >>> + } >>> + >>> + if ((i.index_reg && (i.index_reg->reg_flags & (RegRex | RegRex64))) >>> + || (i.base_reg && (i.base_reg->reg_flags & (RegRex | RegRex64)))) >>> + return true; >>> + >>> + /* Check pseudo prefix {rex} are valid. */ return i.rex_encoding; >> >> Can this actually happen, when we're converting from EVEX to legacy? >> (Initially I wanted to ask about "rex" and alike prefixes, i.e. the non- pseudo >> ones.) >> > > This is to align with check_EgprOperands. I hope the function be more general. Not just for this optimization problem. But then the comment shouldn't say "REX registers", and "Operands" in its name isn't quite right either. Also you want to make the function be a proper modern declaration, by adding "void" between the parentheses. Jan