From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) by sourceware.org (Postfix) with ESMTPS id 77CC43858C54 for ; Wed, 18 Oct 2023 12:06:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77CC43858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77CC43858C54 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.22.76 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697630772; cv=pass; b=AEm1q3DhgR66IjdtAbROzI/vPYuT8anWWhOScNA/iQ2bjfiJBwXsKihjwhnvSYR1bH98pxIi/Jpcl82KJvWHv0K2lyAv3TWMXtTpSUm1Mfi+JZrQ7+lmgpqTJf/RkWiKkNH47hbCLFOrzE4S7G4n6oW7cYhAUkpuLiuZDgAsIo0= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697630772; c=relaxed/simple; bh=GmnY6qdMPfedv8dxvKKFNrcyzy2XCf8sWpHf/bhnp9k=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=L0NbWVIN97nMbCEHdxPzKS4+kjwUE59OEktK7Yc4k9Iun3zzaimxiX+0awDKVjuaA24t42mJIyKn1C9fQ+6osaJ/OQwGTJ3f5jwKmh6oHxgp5N0Xn1Ur2+3bMOOzL37ed8WfUGAZXZ+C3T891sBSkWttsqJ2Rv1x5EYFjXQgZmQ= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPubvD2dA/6g1zkxf8bzlTAkBGXFjajGoqKyQs0COMrRkzRGYVSswXxVxDPSvYDmCdnNJeYT+7TAU9x+4o+MZmo5HGojINt2CFd25186xzMltqXNdXekJxahyFhsTrVOsrGOMQQIiOgJFPBKXi5UYlszVzWe47yGFVFN+KdGvbb6umbPO4ihOV8fB7GN2IBk2peHSV5GobGxg4LlRniFPm0ZXXaPe+dvHmFHR/pCctgml7HP23n96W44dIiIeOow/1laLXGjVux6H0Jqpl7RfmIG8HOwViL9SqLB6uLEY8iIi0yr0TJ8kTTCKX/MwawDE++6kQS0cdvUZjzYnz9T8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LWkBsS53pHkpVEWmagr6v/ckzmNS8FarFWQpevpZ3yI=; b=Tfh3gPugiWOgCfUf9FAMe+ecpsEEU6d1wiAKyIuND6Rxu+uSr98ytXKVATX8XtMRHqkkuXSV1VCVMsH4OLI4jYQynXW8/2zH9wmqKJQbmYMN87sIrzawRAUH4ORa+IaTi+ZQVSsK3lhylBq0+KUi6UXAyoXsJBLq/99LJxX2oXQO4+gk5ay4JV3HRvrdr3WjhWVwxt3IBWg30iQb+qJo6iaqQyGbd2go7RQy7EdT0vNeTbDldwAOODjpdQklvLSy7gR25gHo0tHZyoA2+zky15t37wU+R4a3r//Lr4tMFHJtn0thdQQgFzF53/Sg+c5u2QFXODKgD18uFqNnpslQMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LWkBsS53pHkpVEWmagr6v/ckzmNS8FarFWQpevpZ3yI=; b=jIMwO3CMXUH8KCIF4GsEkGiFD6W8WRJaJvLc2zgZfqwBwkZ4l5+qL3OGA7rXjytIBAByGVBdT+yo8H94a3eo5AP/YsN5elYamzTo/HQ/gcCw8AHcB25CczEzb00vqEct2XUpoz9vxUyfk3/8W4UL+zKFfmxVpgifamqqCH5u4CpMfujCkzAe6cDQX6a7vvWI10YoMP038j2mUhzO0x5onYmQaAYuGoHEl4n1iXDDsmDvn7cBWxc1xA6vFRr2gJr7bfTGY5N4UdnXXcXTyloEYxdxurgiJzLgF3nHssfZcxVhXN47/eWEu4OzUvzt72zKsvR3wIgi7m/BDXDnsQ7nfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AS8PR04MB8293.eurprd04.prod.outlook.com (2603:10a6:20b:3fa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.22; Wed, 18 Oct 2023 12:06:07 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 12:06:07 +0000 Message-ID: Date: Wed, 18 Oct 2023 14:06:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: FW: [PATCH 3/8] Add tests for APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-4-lili.cui@intel.com> <152263a9-5e04-ccec-a5f9-b3cef851a85a@suse.com> <772023ba-7bd2-331c-57b0-0aa45b0cc60e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cb::13) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AS8PR04MB8293:EE_ X-MS-Office365-Filtering-Correlation-Id: c6cd1b13-ceab-4728-ba05-08dbcfd29c44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rZ/ZZJWAvQXmREQ6JiAEo/3fCMTttLxvv/wGNo9lS32v4z2elsllJ06v3NvF01+i3gsC8qADFfG4ihMiHSky5JMjpVEmhgrAND5eayEwOIFJS8TEf1jHh6rGeyEC3jc+/M5PPeflMmweaBgAlxDS+XI0O8WsFdkgDKP+yb642dV4N8MlcG4C/CjLdcTV0DuSXGN+n6Pjxo+FGVkirTpUXHFI6btlbIqoT8Cjw6n+djJ7hb2AB5urB7fO4XKEvCfoxYNdtbzNAzTPsoGbMwbxYt/zlaOuoFiCwrL73M+AA9VmC2QTugsGzPIkPXO9UkWleG9BraVUZZvz4F05jpnX0JEbeT8fr5O2YtGr3m0XABzt4fVlTlkqrV9ourSbYY4Y3h7ykXl7DiQQlntJhRPFE4aCw5QB/2QSqFc1x7Kv+8Cw4nueIqMbzkVQu19cWeC9zJTjJ5O4x5JPqoL0BX5y2EBhuL7HMwFmUWekr36k8woq0sEEk9XrIEEZ+hPRjNpNzqok6vFPookCenahifp9fFwYW/RRP156TqcksD+p+46LcLEd5k1g07sJIQexPCno2yi9gV8hoesFKHTAW1CEEJu1IPJ3ICAMSHhqa0OPPmUNnKnEjMTopmgKR6hkOaqaz0pH6AjkOAxjoZRW74+ZyA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(366004)(396003)(136003)(376002)(39860400002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(26005)(41300700001)(53546011)(6506007)(6512007)(2616005)(83380400001)(31686004)(6486002)(2906002)(478600001)(36756003)(66556008)(6916009)(4326008)(316002)(8676002)(66946007)(54906003)(66476007)(8936002)(31696002)(86362001)(38100700002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cSs5Z0tKOGx6WWJPWnBjSGVUS1JrQ0N0Q3kya3dOUXg4cjZDanZmR29PdXg0?= =?utf-8?B?cGprUUFxaENXMXZDTTBRWVRjalhDbHY0eUIzbmFVRkRPdEJIVDNsUEorRFhv?= =?utf-8?B?QVpEYkZyL3VNZkY2UC9CektVekNRWEw5SDNUTXNsTzJ3MldoY3hNT3dzemY3?= =?utf-8?B?aUUvVmxjb2plZlFRenpCYzRsaXFoVmo0NFdIOHlwWlE0NnN2OTAvanRwUDJk?= =?utf-8?B?VWpuV3pnVDhhTHpGRlFjakZsMnJGWUVvZmk0RzdHMElYQzlSZjIvamhDUnZI?= =?utf-8?B?VVpsNWdsb0s3ZncyTkVSak1iVlg1RytjUGk1Ums2ZDFGVG1oNjdieDkrTDc0?= =?utf-8?B?NkRRbHorczI5UTN2MHlHd0JtbVFhUVRhblNpenNCZlZlSzFHeFNtYnFxYi91?= =?utf-8?B?bTBuME9wNElBZkU2UGVCRlFoeXhTWXhYcFdWU3lPT3VPeno1b0p1enFvTDcz?= =?utf-8?B?ZWRjM1pGbDM1VlVkaUVnVFpTcUx5czE1Um5zdHZiL2J4NmZUYjAzUEhrMjJD?= =?utf-8?B?L2NuVjBzeHQ0ZkJKeHMrOC9Ncmp1NlN6V0xSc3lWS1ZLL3JYaGZBR1h4b2k4?= =?utf-8?B?Qkc1RnVYMGloaHdqT2w0cFdNbW5iK3kwY1Y2MGRCTVNteVN1VXBDenhVMVBH?= =?utf-8?B?TnYyd3dDbkNGSkdSbWlRdEVQWk5wQ2dVdU52S3pEQUREUlNlUVBDRWZXV0h6?= =?utf-8?B?YVk4RHZsMjJOcXRFY1lidW04Tm01SmI5QzhaVTdydTVrNndxYVN5Uy9TQWFT?= =?utf-8?B?ZytRYkcxWTBYeVV4c2Y3M0tNYVR4OHNERzBPaWVpWmNJSkhGNUUvaE9jQmRj?= =?utf-8?B?Szg0OWlUVFBZeko2aGZFaFFKNXVUVGIvN2c2dG5PN3VoRWl6SmFhbW1qbFpI?= =?utf-8?B?Y3I4Q0c5YktPRGRMMmhkdU1iL1czSWsyUGRTc0dIdWVSVkFmcVZubTI3UXlX?= =?utf-8?B?RERROWVlVE5rSHA4NFlKSDAxc2VNYkl3RUUveG1aRWFBeXhBK1JBUVNqZHlY?= =?utf-8?B?V3QrVXhWRmJYSzZiNFVyTkNmUE1rSTk4a1Z0SVpNamkyWmgrK1lYS293V0lh?= =?utf-8?B?RTRtL2wzeS9PQjlaZ29zb3FFSCtPbFRwYXNzbVM1UDFndUNJUytTa0V2bHlO?= =?utf-8?B?R1YrTUxkeTV0cS8yaFJpNjN1ckhpTlI5NmhvZlFSZStTMjZQTnprVmxRaWM1?= =?utf-8?B?TFplVmpLV3lkOWxrL2JGN1o3ME56d1VKaFZ5cWZPcVE1UXdORk1VcnQxdGFx?= =?utf-8?B?eEp1QmtQU1p6Qlg1M0VwSDRpalA5NVhxc0hYVFFoYklqckxvQStlMlUxemFT?= =?utf-8?B?MWJWbUQraDJnSzFneWp3Mk5WanB0WlNxVmhkYklxL3FPSEM1NVc2Rk1ET1Zn?= =?utf-8?B?Y294dWtWVzl3OW5OclZQc1pUWlc3c3R3OEpVclU0cEFINUFwR0t0b0tSSTNv?= =?utf-8?B?bk9JTlVDRTlMMFlDSE80bXRRTGFyU3Zkc092VVFRZ2c5RkJEV0dIZldWbU55?= =?utf-8?B?ckpuRlNZWnRlcVdDbnFWL1ltYk9OQTFEaDdvS3VHbkZOZmxvYTlqYXVEdEY3?= =?utf-8?B?UUl6cGtwdnRFY1RNUlpYTzQ5VnpncURkZ2pxS1FrSFBHZ0pESDRvdXpFS3B1?= =?utf-8?B?RU9SMjV4SU00N29wbW5HWHozZStOaXVOZHNpTlZSRktEd0xzeDRRanp6MUVL?= =?utf-8?B?aktVcTQrUmNaS0tMN2NhNjVETzNUMERjSWNTRjlpWlhNZE4yNzRja0FVMVVV?= =?utf-8?B?ZEI1MndwYUI0TTRDU2d5aFhubVpqY05ZeFcwcHNMZ1lkQnhPR3phSWpGOE5h?= =?utf-8?B?Z3BKcDdISE5DNkkwaUdidXhJdXBZN0ZOcnc2bTViZ09NcHB3NTB3bmxlczhU?= =?utf-8?B?N0p6clcvV2JQaDlLclpNaytCb1lIYkZBWEYzTXlyUVhZUVBsZjA0d25yZDlF?= =?utf-8?B?NGd2NG1kQzBxekx2ZzFTS0FhQmtMK3dMbDI2bjdHRGI5UGZpSEpnNDZFcE4z?= =?utf-8?B?ZkhqSUpkVmpIYjRPN2Zzb2ZJNzdJeGlLNEJJZko0a0dnYm42Vk1ZN0tLZ3c2?= =?utf-8?B?cjZqdUdhWGlKSDNYeW5ScVFzaUhobm9MZzMyMm1Wd2RkbG9hQlZ0WVFZbGtT?= =?utf-8?Q?GSC1ZMQFI+ZBe28H2apyP+jBk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6cd1b13-ceab-4728-ba05-08dbcfd29c44 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 12:06:07.6324 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /q9QXooevyCRSFE26EQ6+t1n4IRa5LCE9T+jWymkYhPkgGTQM4oGKJ5tobHXtJM7tRYVlZDJ0LPlEnzxkVSM+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8293 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2023 13:26, Cui, Lili wrote: >> From: Jan Beulich >> Sent: Wednesday, October 18, 2023 4:06 PM >> >> On 18.10.2023 09:16, Cui, Lili wrote: >>>> On 18.10.2023 04:32, Cui, Lili wrote: >>>>>>>>> --- a/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>>>>>> +++ b/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>>>>>> @@ -1,5 +1,6 @@ >>>>>>>>> # Check illegal movbe in 64bit mode. >>>>>>>>> .text >>>>>>>>> + .arch .noapx_f >>>>>>>>> foo: >>>>>>>>> movbe (%rcx),%bl >>>>>>>>> movbe %ecx,%ebx >>>>>>>> >>>>>>>> I don't understand the need for this addition (and hence for the >>>>>>>> need to change the test's expecations). Like was mentioned on the >>>>>>>> original >>>>>>>> AVX10 series, tests like this shall not need modification, or >>>>>>>> else it indicates people's code also may need ".arch .noapx_f" >>>>>>>> additions, which I'm sure you agree may not be required. Finally, >>>>>>>> if testcase expecations like the above would be needed anywhere, >>>>>>>> please generalize them such that a similar mere addition of a >>>>>>>> line doesn't require the entire test to be touched. Here this >>>>>>>> means that while for the diagnostics you of course want exact >>>>>>>> line number matches, for the actual listing line numbers don't >>>>>>>> don't need matching >>>> individually. >>>>>>>> >>>>>>> >>>>>>> Agree with you, but movbe is special, movbe didn't support reg to >>>>>>> reg >>>>>> before, but APX enable it. so I added .arch .noapx_f for this invalid test. >>>>>> >>>>>> To be honest I didn't really notice this difference so far. That's >>>>>> somewhat ugly, because people mistakenly using a reg->reg form >>>>>> would suddenly get an EVEX encoding rather than an error. This will >>>>>> need some further thought; please mention the "anomaly" explicitly >>>>>> in the >>>> description of the respective patch. >>>>>> >>>>> SPEC: >>>>> Note: The promoted versions of MOVBE will be extended to include the >>>>> “MOVBE reg1, reg2” form (namely, the ModRM.Mod = 3 case) for both >>>>> opcodes 0xF0 and 0xF1. This extension makes the promotion of BSWAP >>>>> for >>>> NDD support unnecessary. >>>>> >>>>> I'll add a description of movbe to the patch 2/8 changelog. >>>> >>>> Thanks. I did deduce the connection to BSWAP on the way home yesterday. >>>> Which made me come up with a (spec) question: Wouldn't it make sense >>>> to name these >>>> reg->reg forms BSWAP, not MOVBE? It doesn't really matter that they >>>> reg->use the >>>> same encoding as the MOVBE (then mem-only) forms. That would then >>>> eliminate the concern I raised. >>>> >>> >>> If we extend BSWAP, it needs to add the operation of reading ModRM.Mod. I >> think this is the benefit of this solution now. >> >> I'm afraid I don't follow: I don't propose extending the original BSWAP. >> I merely propose to use the BSWAP mnemonic with the reg->reg form of >> what's presently called MOVBE. (As an aside, in principle no ModR/M byte >> would be needed to extend the original BSWAP: One operand is encoded in >> the base opcode, and the other could be encoded in VVVV. But that would of >> course needlessly consume an entire row in the opcode table. Hence why I >> fully understand that the opcode wants sharing with MOVBE.) >> > > I think it's a trade-off between functionality closer to BSWAP and opcode closer to MOVBE. Since the spec was published and gcc has committed the patch to the community, I think it would be hard to push it to change. In which case I wonder how one could influence such decisions, when the first publication of such a spec already means things are set in stone. I was hoping that only inclusion in the SDM would mean no (easy) changes anymore. Jan