From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id E7D68385E01D for ; Thu, 11 Jan 2024 08:23:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7D68385E01D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7D68385E01D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::133 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704961415; cv=none; b=sas0ZGOzaMvC6R0VrbStoPurlQhTVxrL1Qg4+oH7bCIBDrIlAjjGO/1Wa2PLWOgdt6AnZj1BT7Hg6VmmjRopTIlU8/G5BskBrb5CvTPA8MIqHGCEvOJamhJ/7LMWONiNApgq4hr4VvFUmLuLPfakURdAddUlOZavZ3E+VGYXCCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704961415; c=relaxed/simple; bh=rsleZdgwAROc2n3T0y2zAHVRsE7ofEql3GGempviZNI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nyXG62ay9kuP/ARndvZTESgWSb6LyaygfEGoL8zHo6p+bueAPD0nUUdI3Do0jymcaGwreDNJ49ZHh+eaazd4Q879bAVxgduSy7FPVkLuSKWwlrr/GCCVm7s5Hwrm1fADsCCUmW9vcmQyr3VG7ejiNdpjWxi6tDpoy/z5C53YBYs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50ea98440a7so5138795e87.1 for ; Thu, 11 Jan 2024 00:23:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704961410; x=1705566210; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ze5Mjl5q1Wp2fYoWYBr/DC/oCsZO+uNJp7oPlxKM0jI=; b=QrSMZLtm2KOJdI2x+xeWeC+fR0cxsjPWjaC1w1kJ8rAgE9FfIXEkgbtWVt+3RyQpd+ mtvq2t36c9NGsmceRchD/LS9vkGvg66oviET4fEtD1GB3RDfj04/rU7kapdeRdoXq/r0 no99Lzj24RM7NUkj+RwlqMf3HMm02K1jT04gS4c468YKBL017acofNSvwvQ7Yk71u/5t IErkQN6FvF9ypNrHSNt8+RBrPFC7wzprYPDFCVbTuioBg6/VxhCFIK8Xrs09N794N90F 7gzgPb1ZVXAsAHkCPoAGTRlj9VlNoEQITcIV0Pq8hCYDKyh/zO+yE425Q/nJPcjqiAR+ gv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704961410; x=1705566210; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ze5Mjl5q1Wp2fYoWYBr/DC/oCsZO+uNJp7oPlxKM0jI=; b=HxgasAlqPvKzuX2s7T5k/Fzww8zZQoZbPuHOXPwltQIDPPvRLS74Faii7bW2WOKK/R CPBPYufGTab+qHNm9IiThd45U1/c0yXTZFKHDnDXg061fxVKcFGFIyDuxTcuj8Yt2Jow XwoYLn9uhAvXqu+M3Ls9mjUpNSr8M4xULT6oUkH2BR8F3kKqDUvfnYGTgw4FlPRaHDl1 1BjddKJwGlOEMrrRT/mPdl2J58hTfzIJm5Jrm3KvU1kb+p5WoS+kW6NN+thhmYpZAXIk RYd+SyCjA64B2SclL/yydY//lr+MoP4+gF0r9NOF8tbo29hKwfZ4C8ZnkZxU4TPl5DDL Ef9w== X-Gm-Message-State: AOJu0YwALpUYzFTuTW12ALZcCaTWKevhFuR1EI/GdFHYijR+EwSR5Mas sxv3pmYT0F8rcvrDUglsHCLfZB1pjGOe X-Google-Smtp-Source: AGHT+IFUWbpnTGjpzqTpeEHiO2PTsF5rIadcq7J5eLKtC7ysm82kTG8wjYzMuPq/dsd84WKT0OktLg== X-Received: by 2002:ac2:4144:0:b0:50e:67f6:18d7 with SMTP id c4-20020ac24144000000b0050e67f618d7mr189444lfi.156.1704961410203; Thu, 11 Jan 2024 00:23:30 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id h6-20020adf9cc6000000b003375d8b0460sm560799wre.1.2024.01.11.00.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jan 2024 00:23:29 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 09:23:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] bfd: make _bfd_section_size_insane part of the public API Content-Language: en-US To: Andrew Burgess Cc: binutils@sourceware.org, Alan Modra References: <0c54069e-d907-4f03-8d7f-15374d4bfd6a@suse.com> <87frz58n7j.fsf@redhat.com> <877ckh8fjz.fsf@redhat.com> <8803d3e2-688e-43ac-b710-5237fab8b054@suse.com> <874jfl88jg.fsf@redhat.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <874jfl88jg.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10.01.2024 17:20, Andrew Burgess wrote: > We're talking about the same _bfd_section_size_insane in bfd/section.c, > right? > > I don't see any arbitrary limit in there. If there is such a limit then > it's buried within all the very non-arbitrary sanity checks. > > This function isn't answering: "is this section larger than X", it is > instead answering: "can this section possibly be read from this file". Hmm, first of all I have to apologize for having gone from memory, having looked at the function only when I first saw your patch. Yet then what you're talking about is merely the final check of the function, which I'd view as fine to externalize. The whole rest of the function still seems pretty (but not exclusively) heuristic to me. Anyway, Alan has indicated approval of making the function external, even as-is. If I was to make a suggestion beyond the possible renaming / inverting of sense, that would be to split the function into an "is valid" part and an "is sane" one, with the latter kept internal. Jan