From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 68D973858D1E for ; Tue, 7 Nov 2023 11:38:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68D973858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68D973858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699357105; cv=none; b=RnmkqT+BzMcpHZGs8pX4rD5ib9WS6B04CSS+RD2I+5sALC2J2uvDjLi9dmkoczQpz9adYfLY/LTEAfu/lVgJaQvmLw2oOdbmjWWwi1AkY5IHmESXUYFo9sirvv1S/StW8HP5zAULHm0hEq2Et8qkQSWQZ024HskUz5RV+FZcMd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699357105; c=relaxed/simple; bh=IkQ764BON4GvC5T1Xmc6uFVlXwuuCHmO6mIzMygYA3Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=tVLnsow2OzoJ2838sR4//dyF/Pu94dwp/mIR3eJ/Yi76ch6K+mWSO+38snKQVq809/hhSlae/psV6v+8ioiXHbgKboAnHldvpdAVhj4umT2EATZRaWmIHYt0YbJPZzhlpn3mUj9pgskvjsDpyArdhiqvx6UrDvEEkOwttsqDvpE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699357104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FazEAJ7HD9uOjya4l8zrg4+tClbOiyNEitLrzvPl5mw=; b=OuyH+fsuXjhj8lHEnqc7YKEvcLNl5Ghj02p0vmowAllU5+EOR/2D10Suw9euZbv7ZukR8A qZUw49YlzXW0M3c2xDGAQp4IB8hPaYmk7vGdgv7hd+wdLpQy9u/nUlc4aq5SmLCw6jUoMJ JKnJ0IVOH+lweuv2lEAEYnnXGbZBgnA= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-mheQSXKHMaGhc0ITc0-3rw-1; Tue, 07 Nov 2023 06:38:22 -0500 X-MC-Unique: mheQSXKHMaGhc0ITc0-3rw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-66fbd3bc8ebso68700216d6.1 for ; Tue, 07 Nov 2023 03:38:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699357101; x=1699961901; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FazEAJ7HD9uOjya4l8zrg4+tClbOiyNEitLrzvPl5mw=; b=FxPjrfVkeSJ147fkxZkviuVeUsrkeb/ZoEWGMoxwmZaNFsBybeRzLzozkGMlYGzET6 IR9y+SKAxtNAaD/FbJ+1hN9qGCYtrruzSwxYiMgUbCQWv1vSsSGfaNJNC1smnYxwiO6p c/FsISDtQnQjvSZx9gyJH1M/Ae+/NI0/mtXX5ze46XaOejafQjQA2WKQR1TmszFWstzM 2/IIwEKL5o1iLFwWEMU/wXAa4HnOgSUwwmQA6aMIwnLKZffwnPQ6VUSJh2ldm1g9yAkx Oj5V55aNhJmdbaZ1Vdx/RPGaENPIzYfzI4S6WXPzFxMDZyEeHaVKZ/R1S6W3Vj9M7ioy HXPw== X-Gm-Message-State: AOJu0Yz2qGSR33Pjw1xryRkK6Ub3TzrF+IyjvVHZ/amB3dV7BA62pV7m xgQ3mef2/iRYOw4GS5p/VfBmi7SXtEEF1LYdF6GONdRcggkV67wfRj1U9ExxiB4vM4qkmCxEPf7 6IHGyOUcG1mWvZSU5TmoyUdgLJQ== X-Received: by 2002:a05:6214:2465:b0:66f:addc:9882 with SMTP id im5-20020a056214246500b0066faddc9882mr41777624qvb.0.1699357101703; Tue, 07 Nov 2023 03:38:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IFb6nFQDuMw8hA3Pm83If5vBp/qP2OEZSX/51yHNJYdt7PLznIO1RnBTozNuGpyQ8/DlaEi2A== X-Received: by 2002:a05:6214:2465:b0:66f:addc:9882 with SMTP id im5-20020a056214246500b0066faddc9882mr41777613qvb.0.1699357101462; Tue, 07 Nov 2023 03:38:21 -0800 (PST) Received: from [192.168.1.11] ([80.168.197.243]) by smtp.gmail.com with ESMTPSA id nc5-20020a0562142dc500b0065af24495easm4304836qvb.51.2023.11.07.03.38.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Nov 2023 03:38:21 -0800 (PST) Message-ID: Date: Tue, 7 Nov 2023 11:38:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] aarch64 BTI stub fixes To: Szabolcs Nagy , binutils@sourceware.org References: From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Szabolcs, > Large binaries with BTI can be linked incorrectly with > binutils 2.41 because PR30930. > > there are other less critical related issues fixed in > this patchset as well. > > Szabolcs Nagy (5): > bfd: aarch64: Fix BTI stub optimization PR30957 > bfd: aarch64: Fix broken BTI stub PR30930 > bfd: aarch64: Fix leaks in case of BTI stub reuse > bfd: aarch64: Avoid BTI stub for a PLT that has BTI > ld: aarch64: Add BTI stub insertion test PR30930 This patch series looks good to me, so please apply if you have not already done so. FYI - I did find one regression in the linker testsuite with the patch applied: FAIL: Check linker stubs with indirect calls handle BTI (exe). However there are mitigating circumstances: * The failure was for an unusual toolchain configuration: --target=aarch64_be-linux-gnu_ilp32 * The three other tests in this part of the testsuite also fail, both with and without your patch applied: FAIL: Check linker stubs with indirect calls handle BTI (shared lib). FAIL: Check linker stubs with indirect calls handle BTI (exe). FAIL: Check linker stubs with indirect calls handle BTI when target has BTI. Note: there appear to be *two* tests called "check linker stubs with indirect calls handle BTI (exe)." I leave it up to you to decide if it is worth fixing these tests. Cheers Nick PS. My gut feeling at the moment is that we do not need a 2.41.1 release for this patch, since AArch64 systems with BTI enabled are not yet the norm, and those that do exist are being used to test for problems like this rather than general use. Since your patch will be in the 2.42 release, due January next year, I think that that will be a reasonable timescale for getting the fix out there. Do you agree ?