From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6A6683858D28 for ; Wed, 3 May 2023 14:39:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6A6683858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683124776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+zgLbdB3iRJ9hn0t+nV8kik+Ru5bKpPlCBdNo6Zri3E=; b=GlkS+kDEOTDsKcNBNYU6bchc0Ubt1CuKfk8aAlHMGvb0oO8jA6tJORG0IPUudnJkCcEKtA LIe+/cR9/5stVPwONDQwx5YbgRmG6uvwrKRX/b7pOVff5cu351fCEOgAo+V4upjXAeqmzj 8Q58kS3K+2pdKfhxt7log4Ju8dxzC7c= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-3MnS2EN3NuycG4rSdHOVog-1; Wed, 03 May 2023 10:39:34 -0400 X-MC-Unique: 3MnS2EN3NuycG4rSdHOVog-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-3ef1dfd44cfso28224951cf.3 for ; Wed, 03 May 2023 07:39:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683124773; x=1685716773; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+zgLbdB3iRJ9hn0t+nV8kik+Ru5bKpPlCBdNo6Zri3E=; b=N4cIADEvAZWY8n1iU5KIC6s5k4IqTVDTOU1u6AB6//fPIjqVh2wt2aAhWQUuy6kc9+ ogtNCHIUi+QwhBVhaWvqAZURlYdDy4viWnW8BaRPJgC1deHrRsUumJfPfr+5qmT6WOxa ynBfKFCqP0UgoRaZC+a7IXq2wGmfWdu+H6mLCbhcDFqCZf31X/S1VenosXSUFvyIXkWz qb4GDs3RAw4Ki1oxgz5fpSbrgRKi1sU2WV76NFqkxFaH/80YtWx5szTPNYSKIEzOm0Zp 0tbltytbvLjsxUXZ8JOgsDb8GptKphIZcOLcVSpPzlImwFHuu7kUyQy0rbEPIE1xOeKi PWSg== X-Gm-Message-State: AC+VfDyjBCsrRhtfMKyHZQJqBXsWstpK1rAiCWda58puRgln9z8HkqsK Z2my3meBZi5KINm4Kqw1AAe2h02KutgZfiPVudRn2sFoBWHsDJKJ9NcXsiuhk25PRY1QMaOjDhG pwsr7yCafs86LM37RpgUimXWfDw== X-Received: by 2002:a05:622a:1a17:b0:3b9:b6e3:c78e with SMTP id f23-20020a05622a1a1700b003b9b6e3c78emr635701qtb.8.1683124773784; Wed, 03 May 2023 07:39:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5m1CPnZrZESoZtG79r7lHDHChfapma1ssZRFtVbtglTsiHPTiHtO8Ue/AwGKSEuJ+980OLzg== X-Received: by 2002:a05:622a:1a17:b0:3b9:b6e3:c78e with SMTP id f23-20020a05622a1a1700b003b9b6e3c78emr635674qtb.8.1683124773508; Wed, 03 May 2023 07:39:33 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id g13-20020ac8774d000000b003eae8609f64sm11439968qtu.13.2023.05.03.07.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 May 2023 07:39:33 -0700 (PDT) Message-ID: Date: Wed, 3 May 2023 15:39:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] make coff_compute_checksum faster To: Oleg Tolmatcev , binutils@sourceware.org References: From: Nick Clifton In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Oleg, > This makes linking faster by reading 8 MB of data at once instead of > reading 2 bytes at once. This drastically reduces the number of system > calls. Thanks very much. I have applied your patch with one small change: > + buf = (unsigned char *)bfd_malloc (0x800000); I replaced the use of a magic number in the malloc, and subsequent read, with a #define'd value: buf = (unsigned char *) bfd_malloc (COFF_CHECKSUM_BUFFER_SIZE); It just makes it easier to change the buffer size, should that become needed in the future. Cheers Nick