public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: binutils@sourceware.org
Subject: [PATCH 3/6] ix86: enable 2nd CFI test
Date: Wed, 3 Jun 2020 13:10:28 +0200	[thread overview]
Message-ID: <a3ad99be-1ae2-b91d-0660-d0831671afc8@suse.com> (raw)
In-Reply-To: <98893054-6c55-637b-703c-0cfd349a3154@suse.com>

While putting together the previous patch I noticed that this test,
forever since its introduction, was dead. Update it so it will pass,
and enable it.

gas/
2020-06-XX  Jan Beulich  <jbeulich@suse.com>

	* testsuite/gas/cfi/cfi-i386-2.d: Adjust expectations.
	* testsuite/gas/cfi/cfi.exp: Run this test.

--- a/gas/testsuite/gas/cfi/cfi-i386-2.d
+++ b/gas/testsuite/gas/cfi/cfi-i386-2.d
@@ -10,17 +10,17 @@ Contents of the .eh_frame section:
   Return address column: 8
   Augmentation data:     1b
 
-  DW_CFA_def_cfa: r4 ofs 4
-  DW_CFA_offset: r8 at cfa-4
+  DW_CFA_def_cfa: r4 \(esp\) ofs 4
+  DW_CFA_offset: r8 \(eip\) at cfa-4
   DW_CFA_nop
   DW_CFA_nop
 
-00000018 0+0018 0+001c FDE cie=0+0000 pc=0+0020..0+0029
-  DW_CFA_advance_loc: 1 to 0+0021
+00000018 0+0018 0+001c FDE cie=0+0000 pc=0+0000..0+0009
+  DW_CFA_advance_loc: 1 to 0+0001
   DW_CFA_def_cfa_offset: 8
-  DW_CFA_offset: r5 at cfa-8
-  DW_CFA_advance_loc: 4 to 0+0025
-  DW_CFA_offset: r3 at cfa-12
+  DW_CFA_offset: r5 \(ebp\) at cfa-8
+  DW_CFA_advance_loc: 4 to 0+0005
+  DW_CFA_offset: r3 \(ebx\) at cfa-12
   DW_CFA_def_cfa_offset: 12
   DW_CFA_nop
 
--- a/gas/testsuite/gas/cfi/cfi.exp
+++ b/gas/testsuite/gas/cfi/cfi.exp
@@ -48,6 +48,7 @@ if  { [istarget "i*86-*-*"] || [istarget
     if { [gas_x86_32_check] }  then {
 	set ASFLAGS "$ASFLAGS --32"
 	run_dump_test "cfi-i386"
+	run_dump_test "cfi-i386-2"
 	set ASFLAGS "$old_ASFLAGS"
     }
 


  parent reply	other threads:[~2020-06-03 11:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03 10:13 [PATCH 0/6] gas/x86: adjustments to register handling Jan Beulich
2020-06-03 10:15 ` [PATCH 1/6] x86: restrict use of register aliases Jan Beulich
2020-06-03 10:15 ` [PATCH 2/6] x86: also allow %st(N) in CFI directives Jan Beulich
2020-06-03 10:16 ` [PATCH 4/6] x86: restrict %tr<N> visibility Jan Beulich
2020-06-03 10:17 ` [PATCH 5/6] x86: simplify check_byte_reg() Jan Beulich
2020-06-03 10:17 ` [PATCH 6/6] x86: also handle %k<N> and %bnd<N> in debugging helpers Jan Beulich
2020-06-03 11:10 ` Jan Beulich [this message]
2020-06-03 14:26 ` [PATCH 0/6] gas/x86: adjustments to register handling H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3ad99be-1ae2-b91d-0660-d0831671afc8@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).