From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by sourceware.org (Postfix) with ESMTPS id 8581F38582B4 for ; Mon, 8 Jan 2024 08:16:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8581F38582B4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8581F38582B4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::12c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701769; cv=none; b=fnFAzVmvcryNMhTpc6zKcCgJnCMzG+vPPukRljcgHwTjo8yCXsCKYfiW4IvsSla0O2TTyIS6D1qnFRjAab8ITlY8oZAv9hHyU4OpFgu90Mh0cr54kFJm1at2U3c5tRQauPq8HQwTlUs1CeBukqugs55o3G75La1qQ5nhLSA3X+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704701769; c=relaxed/simple; bh=bEytL9gFSsplrCKaIt8MPTodXT8QRwlAAEzA1IyDnss=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Z04y7AWrG5UKk5biNGD2XzyVoNKxme+cCTBmKiu11oKC6lzgdk9IngUTiTshF1bMJvmMznd+Gch2bCOkDnvcKJ+yHlwIzRedDTqqmDjyeclYSiKZi9i0LptPYwOp1GTaKtcGQdZ93bi9le16oOGcRmZznOGJrJFHx63to1WmbaE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50eaa8b447bso1323902e87.1 for ; Mon, 08 Jan 2024 00:16:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704701766; x=1705306566; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uqAPA6BbhO8EEBY1P6kQr+XVEhibm+qOwHV1cy7vyng=; b=TMJ3HAvmoFNi+2HEk4L8If045AbCw1zr6oKURVG+tq3Y65LGsnpSsv2QTXCZrEppy2 2OptiYROIF/c2t0HyzlCukruItGU3M8j0FIbPJzLj1F13Fv0F4Pw0T5xwOZXsjBf+XRs 8CYsbo4T09qi/wxZww34TgWa77WKgZ3TV2QRqEtKAjjp3D9Y4mFrasHk00/l9zOH+vY4 yOBrTHb0hnGMPnIG4odCJYDhP+quuACERccN2j9w0ncEeY6PUqKUVadMzRwhTj5YnzDX 0uRtqelavmU6nse2Z9Ip4ZFq6AR2oOUDALjRStCNckzkoOE6ndJuYhXxOwwnmMqUx2oj Zr4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704701766; x=1705306566; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uqAPA6BbhO8EEBY1P6kQr+XVEhibm+qOwHV1cy7vyng=; b=P8NJqNT6oeAxIF2yABTe2nfF2Xy2FKikLZod5CTHDHeyp1ChaMfXhY0DboLYN1WxOX 83rri0w4GUYqjTp5isIPufkW1loL/JQjNJha3Fl8hT9nUGBUkhrNqHd2ifYGrIVHf6fI f/gj7pn9jtOEeckiE2Y1NjnL0uMnhaCqFCej8VDWoolDFkUwrND9xmwy1CjkMy01GzBp xdWtKeVf0/9/utBtT0+/r91K9EwOTW/iW8FwQLSyqqLMbZRYEQx0IW9cjtf5uSs1PsNE zgP9WTwOuRIgWjemGK+Lpqcn6wlaBHd4xWJA+e1GEFUeP37dk6Otmd0M0E6p/ehdtJKz 3Yew== X-Gm-Message-State: AOJu0YyFMw7dTKPKjQCOMC/cPjwikIb6CuKjuNAb86LerXsuiJx1Auua 57MQI0nh/Adou6+3ckNe1W9FAHSAc+vv X-Google-Smtp-Source: AGHT+IHY9/yKrfWa4zjlXhZ/yOa3Iet+pwRD8CpL+ut5dSRC3bn4/lVZ3MzSHQPkKUejjVWfu3TVgA== X-Received: by 2002:a05:6512:10c5:b0:50e:44c9:b839 with SMTP id k5-20020a05651210c500b0050e44c9b839mr857592lfg.47.1704701766041; Mon, 08 Jan 2024 00:16:06 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id y28-20020a02ce9c000000b0046e2621a448sm448327jaq.135.2024.01.08.00.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 00:16:05 -0800 (PST) Message-ID: Date: Mon, 8 Jan 2024 09:16:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V4 10/14] gas: synthesize CFI for hand-written asm Content-Language: en-US To: Indu Bhagat Cc: binutils@sourceware.org, Nick Clifton References: <20240103071526.3846985-1-indu.bhagat@oracle.com> <20240103071526.3846985-11-indu.bhagat@oracle.com> <0ecd9240-0700-4072-91d4-ccf9bdb56071@suse.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.01.2024 01:46, Indu Bhagat wrote: > Hi Jan, Nick, > > I am working on addressing the review comments in V4 and will continue > that review in a separate thread. > > Meanwhile... > > On 1/5/24 05:58, Jan Beulich wrote: >>> + dwarf_reg = ginsn_dw2_regnum (temp); >>> + } >>> + >>> + gas_assert (dwarf_reg != Dw2Inval); /* Needs to be addressed. */ >> Without actually addressing this (and possible similar cases elsewhere), I >> don't think this can go in as other than experimental code (which the >> NEWS entry then should state, and where there then should be a plan for an >> easy approach of probing gas for no-longer-experimental SCFI support). > > ... in this specific case, the /* Needs to be addressed. */ comment is > somewhat stale and may have lead the impression that this is an > unhandled case (EIP is the pending unhandled case, I will deal with it > in V5). > > Moving forward, I would like to get consensus on whats the way forward > for SCFI series, especially whether there is agreement on releasing what > will be the V5 with binutils 2.42. > > My take on "SCFI should go as experimental code" : my priority is to get > this option to users and to continue development of SCFI incrementally > with the help/reviews from community. If the reviewers/maintainers > think, offering this first as --scfi=experimental, which later is > established as --scfi=all, in a future release is the best way to move > forward, I can make the necessary changes now. I'd be okay with this as a plan. Before fully supported, I'd actually hope to see at least one other architecture to also use this machinery. Yet maybe that's asking for too much ... Jan