From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id D0CCD3858D28 for ; Tue, 31 Jan 2023 15:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D0CCD3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8143B22A83; Tue, 31 Jan 2023 13:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675173379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u17E4ui2JdekzbvdlMCUsd38iN/GhzF7fqcPLKV4aAc=; b=C3zcJdx4Oy8qLk+BwCMe+wfLjgdII4L590k6aSr/R06lThXxoK87qPcBwco0wN3e7OYaj3 xhUvln/ISjiCEUChqi6fMy5TYlP9slHgAj+Ct1JtM2s5gnEemo8quGJTSpLquvN0udQAp+ eQ3VP6Pa4o/2i/brdfzjHVCJEi3H1wc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675173379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u17E4ui2JdekzbvdlMCUsd38iN/GhzF7fqcPLKV4aAc=; b=D8hSYlm+S30ybIWyBbJ2ZViw5NnYLoFhbXPeFHp05N3WYJi8jNZKqfiyL5K30d3652uz9H lHgvB3ajOhDaY1BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 67A72138E8; Tue, 31 Jan 2023 13:56:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 10AnGAMe2WPbNQAAMHmgww (envelope-from ); Tue, 31 Jan 2023 13:56:19 +0000 Message-ID: Date: Tue, 31 Jan 2023 14:56:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] [gas] Emit v2 .debug_line for -gdwarf-2 Content-Language: en-US To: Nick Clifton , Andreas Schwab , Tom de Vries via Binutils References: <20230131114257.4585-1-tdevries@suse.de> <69336084-4fe7-0030-cf5b-968804af9954@redhat.com> From: Tom de Vries In-Reply-To: <69336084-4fe7-0030-cf5b-968804af9954@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 14:38, Nick Clifton wrote: > Hi Tom, > >> I've updated the comment, and I've also updated the macro definition to: >> ... >> #define DWARF2_LINE_VERSION DWARF2_VERSION > > Does this mean that DWARF2_LINE_VERSION is now redundant, and > could just be replaced with DWARF2_VERSION ? > I suppose so, though when using DWARF2_LINE_VERSION it's immediate clear what it means. With using DWARF2_VERSION when dealing .debug_lines, you need to know/remember/lookup that the version is the same for the two. > Anyway, patch approved - please apply. Thanks, I'll commit then. - Tom