public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nicholas Vinson <nvinson234@gmail.com>
To: binutils@sourceware.org
Cc: Nicholas Vinson <nvinson234@gmail.com>,
	Sam Jones <sam@gentoo.org>, Nick Alcock <nick.alcock@oracle.com>
Subject: [PATCH 1/3] libctf: Remove undefined functions from ver. map
Date: Fri,  1 Mar 2024 23:59:59 -0500	[thread overview]
Message-ID: <a4924ddefb57e18acab76ab54aa0e73671d335a6.1709355051.git.nvinson234@gmail.com> (raw)
In-Reply-To: <cover.1709355051.git.nvinson234@gmail.com>

Starting with ld.lld-17, ld.lld is invoked with the option
--no-undefined-version enabled by default. Furthermore, The functions
ctf_label_set() and ctf_label_get() are not defined. Their inclusion in
libctf/libctf.ver causes ld.lld-17 to fail emitting the following error
messages:

ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_set' failed: symbol not defined
ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_get' failed: symbol not defined

This patch fixes the issue by removing the symbol names from
libctf/libctf.ver.

Signed-off-by: Nicholas Vinson <nvinson234@gmail.com>
---
 libctf/libctf.ver | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libctf/libctf.ver b/libctf/libctf.ver
index c59847d012b..a685c4e3b9f 100644
--- a/libctf/libctf.ver
+++ b/libctf/libctf.ver
@@ -80,9 +80,6 @@ LIBCTF_1.0 {
 	ctf_enum_name;
 	ctf_enum_value;
 
-	ctf_label_set;
-	ctf_label_get;
-
 	ctf_label_topmost;
 	ctf_label_info;
 
-- 
2.43.2


  reply	other threads:[~2024-03-02  5:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-02  4:59 [PATCH 0/3] Fix ld.lld-17 libctf version script symbol not defined errors Nicholas Vinson
2024-03-02  4:59 ` Nicholas Vinson [this message]
2024-04-17 17:58   ` [PATCH 1/3] libctf: Remove undefined functions from ver. map Nick Alcock
2024-03-02  5:00 ` [PATCH 2/3] libctf: Add comment for conditionally def'd sym Nicholas Vinson
2024-03-03 15:10   ` Nick Alcock
2024-03-03 15:56     ` Nicholas Vinson
2024-03-04 13:57       ` Nick Alcock
2024-03-05  0:37         ` Nicholas Vinson
2024-03-11 15:33           ` Nick Alcock
2024-03-02  5:00 ` [PATCH 3/3] libctf: Regnerate configure Nicholas Vinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a4924ddefb57e18acab76ab54aa0e73671d335a6.1709355051.git.nvinson234@gmail.com \
    --to=nvinson234@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=nick.alcock@oracle.com \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).