From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2043.outbound.protection.outlook.com [40.107.241.43]) by sourceware.org (Postfix) with ESMTPS id 166E83858425 for ; Tue, 14 Nov 2023 11:20:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 166E83858425 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 166E83858425 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.241.43 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699960860; cv=pass; b=cN7H2bkI1UtRjJTJLlgmKsU0N+3hRHq4YzydmKAtN31dJXr5qusXN0aj3AAySOjDQv1r7G0jQ6dXijtTOdCdYzoYu8/UotQaMFguX7dGr/r16ck6p0NqKQOKeOZEsm8Lch98HPuHBsvXUGMLeDqjNPc2qYVGu95WvgOXFcVofQo= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699960860; c=relaxed/simple; bh=JSt18hO2JuuEb1tDlFrEn45WToPNdXCA/8Z+UXEDjtI=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=IXNcUI64yqXFvPk6breBHXZrZw9ML++B2N8RvjgyHqezREwlDqlFtZMT+XKEKfDfNJL3PkMOaYHXyOD//1b+zMuRp3w+D8iIXYja3p4xRRUz5Yn0Ceu7j9VjAa+TWKDk74pP+IRUvmxQWkNieHuomSd4rRqGY/doBjs2L9PhKA4= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ivIOvZrH/jRonfkHQl22MTguG7/ZCCyWBvrzDozWuHVdFL3flBzX5vppYRLXUqhsREOzPNzrzpPDFrZELWlCx9DP3kk+QpgQu6UIGc3mmtuDOQ9nCYriK99hYV4eJhvqJI2Ig6xKqiuAM5FCdLwC+/0tKDd7wRLl9Y7h76ngGpinAjMlS3FcFgLglnpbDNKfC3q/ujCsKbaaNPWALPAYS5CB2t8m6YvLvAPoTsS8oklImaQib4hmmQPty81k4Ggw+fHrlg5Br9fRHmyIY5oc9aBR7654p1D249thH+97I64Pruxld7iQv3khtO4uow2uRHC6IFbpKHOfsCkN5thcPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iLAqBtt7mbqpyHUM3r9yeGr7qCvxC7EuNY6JXfhkrGU=; b=BsY665NKsUQRoG2F5AJbbwG4rHxjA32HxYxY90wDYgA7vVATbvNZOh6NPXOlwB/rDM0RTAOijj50kNcNU2iXIl0DsXm4HoQ+3639qWDveNDQSvY7EwpKB7HVm0n5NzLAob43d4464n/4AlxWjKOL51fAlhlCe6sf6INYfdtIRTfTfNp61lc6bWNPVfqpN5bnAnvGIG7pANxluHsAIGrRvgyWWa7LLZsIDGNqTyvBb8dQfJ5p4FiUriuJvYgfdBmKxilzu3DE9SMHJUSN9slu2E+A/ipkb4dsdMR7X5EQG2NZIsabHY/9wF7wIyHUacv42dMNEUq7/n+vP3NgttTUIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iLAqBtt7mbqpyHUM3r9yeGr7qCvxC7EuNY6JXfhkrGU=; b=k9+Jh5L/TeM+sW5+PCflPRmnAsY7vf4NTC3DqArm2iHELrdOuonIZehkPJXYJn2Q4RMKGDn3u2hamdy7BRJskzpq+c9og+/apwKpT4CqGJeD3Rm1HqnUlz0HwiozFKYi+5fVwHkNsez2Bbq6yARaKxTrvaPDs/jtyhWmGxyRDHxGUnBD4dCv849dyWLAuZUfZxdIFU5YrVvknfVbvNkZyjh7pyYWAv86/joZXZHwEPaLyAzC+QnxSQ8b6Gv0X4ZH21rkdqAQrbTRB79Upx2vEbZrOfLj4RKCNeIn8ufbjvqpYeUb2SCwvOrWCuGMYzulVJ+9RCcWkLVsb7ryEnO7KQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB6992.eurprd04.prod.outlook.com (2603:10a6:803:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.17; Tue, 14 Nov 2023 11:20:55 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7002.015; Tue, 14 Nov 2023 11:20:54 +0000 Message-ID: Date: Tue, 14 Nov 2023 12:20:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/2] Reorder APX insns in i386.tbl Content-Language: en-US To: "Hu, Lin1" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <20231114025856.863065-1-lin1.hu@intel.com> From: Jan Beulich In-Reply-To: <20231114025856.863065-1-lin1.hu@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::19) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB6992:EE_ X-MS-Office365-Filtering-Correlation-Id: d781688d-bf37-4c17-5ef2-08dbe503c482 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QshNCmGvmdtIA6sS+SBS6viZratNc4Um6fwFlszsP9Tt+JuSnovh3ctU+FYItzy169oJi/UOGPknfPo0oq5MYZNSbo2YAlWwbM3R0y4p2tiIlPvJin7ecjqxicbWEFdl0yrZPoYEGeh8q+Pg8wu4X3JAdNgXD8GVTZfMvThgEzOR/B3MRk457ARNM4oBiPQniM+0H9uTpM6vB9i8avpQY1Eu55kFzyvPuqbCcJOdTEqMaRNl4N8b0rrVK0f5oW+8WdnRjQVH0pxPwftjBVw4prkJLl1O1uRHEH7h+StdXsD8kBxYwd5uTG9JcNnJlDWRSBU0cG2H6ruXAuf2vlB+2KOcGxdGrMOckM6icIPXfEMgsiSlJEfveB62IkYxhVjaSGt8WmJkjQ5Rk46pNfTa53icGPOVE/bMEz1VnOD4X++UQ3ygJhCy5BB3jrqmbQWN/fe+++MK4/VMsnJtV7waFkMxnENhZfTXSDNZx+KirvfKG3TOPoIWuprX2zCIO7z5yOHoxkqrgLm/mE4JxdBul+jnBfhQzFnuIizgC4YAnyqU9ht5u8Qnh/Cy5Gf1bmdTMTnWPSebGc70S52jG0G/LMRzrtvIKZtIfsqh6DCsi6mcHF4kP8a+z/zRmn4ssccwdc4sRiZ3ZOsGaGR3fs7F+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(136003)(396003)(39860400002)(346002)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(38100700002)(6506007)(53546011)(83380400001)(31686004)(8936002)(2616005)(6512007)(41300700001)(2906002)(5660300002)(86362001)(8676002)(4326008)(31696002)(36756003)(66476007)(66946007)(66556008)(6916009)(316002)(26005)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1BSMzd1bkhla0FMNmRUaWNNVzgxQjZKUE1raHRZbFI5TTl1WUc4clZaa3FT?= =?utf-8?B?NVQyTTlkNVRYMW9UMzdaTk44T0Z1Z3IraDlRQ0kzMU8wcUMrUkNKenNjS0Uv?= =?utf-8?B?MDVyaHVWUFVEdjdYUTB0S1VNOWhtbEp4d3I5YlV1SXRTQndMYlFTSjFObDFw?= =?utf-8?B?VTJRL1ZvL0xuV0dlbkVLM0x4UnUwMUV1bGdFSFdnQ3Vyai9BOVVsN2N0VkJv?= =?utf-8?B?U05POHRTejBUTFY4VGZoRnhiRmRMeDRIWkIzbDhkc0thc1JabERiRWxqLzlL?= =?utf-8?B?alMxM3BnMGl5MmIrcGhmSktPY2NWNUNoWGpab1dyd0JjbXhUK2U0cEoxY1FQ?= =?utf-8?B?eml5UDVtNW41Rm9rQ05NWjR5bVFBR1B0STVUZ3Z4akV1OUdDbFpjTFdlVVZI?= =?utf-8?B?ZnBiYjV0MjBtY2kzNzM2SXQyWFh5R2lNMkZBWGdUUnNuSGtEMVlGRWVDUDVW?= =?utf-8?B?Zllwb2JxK0pucnBlVHUyWEExLzNkRThZcjA0UkdRLzdkT1hTYUVWZ2NURVJm?= =?utf-8?B?TFJKSEV2aWwwWTBYRDkvaVB3aklqZFlxajJvQ2R0UUNXSXZoc25tclRTQ2xP?= =?utf-8?B?alRieTZFWlZ5WFRvL1Uya3Fsb1RzZGlVeUk3ejVLVWUyQkpXNmhoY1MrTEVr?= =?utf-8?B?ZnVaMkhNTnBLRGFNNmZHRzVtR2h0b0Z4TDQrVHBZNDNRVldWellzU2FiTDRH?= =?utf-8?B?aGJEVDJCelhKSFpnVFhMSCtaT2I0YzFyTjlnU2xVZitrVmwyUjFzMUVhRVU0?= =?utf-8?B?cVMwWjRSKzZEWHltRjJVSjNZYksvQTREMzBteTZBRmQ5dDR3bGl1bmc5NDhF?= =?utf-8?B?RkZ6K05UTktsTW1aY0ZEbTNvZ2YvVXZacnF1NDhmVGlhV1pnRHkvU25mR1FP?= =?utf-8?B?eU9uUFFEVnpMYzIvNENxbnVheWxWcm1jYmRVSkdrTFdtdUxPRmlmRExZcnh0?= =?utf-8?B?KzllbDBJTnN6S0M2enhKNlh2SXB6WHZDMXppc09EUlEvNGlxVmJ5L0g5OE9P?= =?utf-8?B?MGVNMDg4T0lSZFlyYTlOK2liOTBJVmEvZnl5bXpaa0ZtYkxmbW1JYmdhSkJj?= =?utf-8?B?UXRESGJ5d3VldmdrUzNTZUdDZ2ZKVXhYVjVkYVVITSt0cnJDZVkza1U0T2J6?= =?utf-8?B?S1JPalJHUG1HTkNOanJzS3Bta29vRzVPNXhSUDd0a2RJTWMwVUhsenVtUjdu?= =?utf-8?B?amhtVEpMTnFpVFEyUW1ZTVEvYkoxRm5iYytuV00vU0ZxQmplMWVEVXBrVjcw?= =?utf-8?B?U1JXZVRnbWJ4OWlPVFlCVllSSGVnRGtOMjVYUnRRMjBpOE1ka1AwZlBTQVBC?= =?utf-8?B?eFppVVBwTktsMW5MSStiemtSSTd2RzJ5QUtWV1VQZzdndkhNYS9QY0dCZTlL?= =?utf-8?B?SVd3UUYxMnM0U0k4Znh1dktxQkRVb3NMd2FLSS9qZ201T1ZGekJEWFdvNEg1?= =?utf-8?B?L3VZQXR4VkxJVHdJRk51MmNkVTBwUGhwWG9PdnJGaGh4UnFoay9aRUZEdC9q?= =?utf-8?B?SFhkaktGS081TEtKb0YvSDlRcUNPdkdjRlJRb1EyUEx5UFI2bFpNM2VBcVNy?= =?utf-8?B?N3BWWFNZOFI1L0crSC9WcW1KOXVObmdrRkd2d1VWSmNSZFR1dFFmTitqZ1hu?= =?utf-8?B?Ti9UeWRrSzUxbUxWb0ZwK1RKYWtMTGVoK09STzFuOHNkWWh1T0lqTWRKT3I4?= =?utf-8?B?S0NTSmpnTnp0bnoyQUFmd28xZlFVMm0rdjNyN3NPd0FMYXc3Unc3dHBtVk42?= =?utf-8?B?UGFWeS9YcWNVMU9wUHA3QU81dWpZV0dRbUpsYUlBUXpkY2ZwQkdOUjJGVzF0?= =?utf-8?B?eFB0ekZtT0pRdUZMODRNemFGN3hHUURTZjdOZy9nREVtMmNHb1hCejdMMDhs?= =?utf-8?B?Z1IzS29SdnU1UUxINHc3b1ZjU1lUNUg4QktSTE1RVnAra2dmdXRvTlNIM0RP?= =?utf-8?B?bU1NNDNxcDNrWHRwWW9OWXoyNTZUK1NwRzJ1L2twdmx1MytrMkFNZHkyb296?= =?utf-8?B?eUFxSjAxNlQ0RFNra2RlMFY1RVljdUdGV3Y0clQzcUtaSEtScGgvRGp5QTFx?= =?utf-8?B?ajYvWVJBbmNqQ1lSd3RadFh0UTkzdG14Z2Q4cDhPNmkrUndiT3hVd29rMzBs?= =?utf-8?Q?2uDuKd2iKQ3eenNFzL26lAwI6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d781688d-bf37-4c17-5ef2-08dbe503c482 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2023 11:20:54.8641 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: E/hnV9jXi6qGoKFJX7OxLUHXNUfvUt/ti+WPe1lluBb8UvFvmPJS4igWMzCqplJUmRghOq3O950sScP8Wn5V/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6992 X-Spam-Status: No, score=-3028.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.11.2023 03:58, Hu, Lin1 wrote: > --- > gas/config/tc-i386.c | 4 +- > opcodes/i386-opc.tbl | 156 +- > 5 files changed, 13189 insertions(+), 10771 deletions(-) What was the goal of sending this patch to the list, without any further comments or explanations? It quite clearly doesn't apply to the present code base. The diffstat is pretty odd, too: There clearly aren't as many files/lines changed. > @@ -2124,12 +2126,12 @@ xcryptofb, 0xf30fa7e8, PadLock, NoSuf|RepPrefixOk, {} > xstore, 0xfa7c0, PadLock, NoSuf|RepPrefixOk, {} > > // Multy-precision Add Carry, rdseed instructions. > +adcx, 0x6666, ADX|APX_F, C|Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVVDest|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64, Reg32|Reg64 } > adcx, 0x660f38f6, ADX, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } > adcx, 0x6666, ADX|APX_F, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } > -adcx, 0x6666, ADX|APX_F, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVVDest|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64, Reg32|Reg64 } > +adox, 0xf366, ADX|APX_F, C|Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVVDest|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64, Reg32|Reg64 } > adox, 0xf30f38f6, ADX, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } > adox, 0xf366, ADX|APX_F, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64 } > -adox, 0xf366, ADX|APX_F, Modrm|CheckOperandSize|IgnoreSize|No_bSuf|No_wSuf|No_sSuf|VexVVVVDest|EVex128|EVexMap4, { Reg32|Reg64|Unspecified|BaseIndex, Reg32|Reg64, Reg32|Reg64 } What is this part about? I thought we agreed that ADCX/ADOX aren't suitable for NDD->REX2 optimization, at which point the ordering of templates here could as well be left alone. Jan