public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Tamar Christina <Tamar.Christina@arm.com>,
	"binutils@sourceware.org" <binutils@sourceware.org>
Cc: nd <nd@arm.com>, Richard Earnshaw <Richard.Earnshaw@arm.com>,
	Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>
Subject: Re: [PATCH][Binutils][Arm] BFD: Exclude sections with no content from compress check.
Date: Tue, 21 Apr 2020 17:51:25 +0100	[thread overview]
Message-ID: <a524b172-df96-56b5-b233-567aafb82747@redhat.com> (raw)
In-Reply-To: <PR2PR08MB47475FE56630E27A00D2BA83FFD50@PR2PR08MB4747.eurprd08.prod.outlook.com>

Hi Tamar,

> Ah I have tested x86_64-pc-linux-gnu and it's clean, I have also tried one configured with --enable-targets=all
> and while the build seems to have taken longer I don't see the number of tests actually increasing.
> 
> I am just doing ../binutils-gdb-fsf/configure --prefix=(readlink -f .)/install; and make -j; and make check -j
> 
> Do I need to do something else?

No, that is great - thanks.

> In general should re-open old PRs before committing to them?

No - if you are just adding an extra fix and not reporting a resurrection of the problem, then just adding a comment to the already-closed PR is OK.

Cheers
  Nick



      reply	other threads:[~2020-04-21 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21 13:41 Tamar Christina
2020-04-21 13:58 ` Alan Modra
2020-04-21 14:01   ` Tamar Christina
2020-04-21 14:29 ` Nick Clifton
2020-04-21 15:50   ` Tamar Christina
2020-04-21 16:51     ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a524b172-df96-56b5-b233-567aafb82747@redhat.com \
    --to=nickc@redhat.com \
    --cc=Ramana.Radhakrishnan@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Tamar.Christina@arm.com \
    --cc=binutils@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).