From: Matthias Klose <doko@ubuntu.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jeff Law <law@redhat.com>,
gdb-patches@sourceware.org,
binutils <binutils@sourceware.org>,
Nick Clifton <nickc@redhat.com>
Subject: Re: [patch] update zlib to the 1.2.10 release.
Date: Mon, 23 Jan 2017 09:10:00 -0000 [thread overview]
Message-ID: <a55729f1-7167-0ac9-d3cf-4f0cc5a5b3d3@ubuntu.com> (raw)
In-Reply-To: <20170123040915.knf76kwgwxji2ng4@adacore.com>
On 23.01.2017 05:09, Joel Brobecker wrote:
>> On 12.01.2017 22:17, Jeff Law wrote:
>>> On 01/05/2017 07:45 AM, Matthias Klose wrote:
>>>> These are the changes updating zlib from 1.2.8 to 1.2.10. It is only used when
>>>> building without a system zlib. The new release includes fixes for security
>>>> issues CVE-2016-9840, CVE-2016-9841, CVE-2016-9842, CVE-2016-9843.
>>>>
>>>> Checked with a build with disabled system-zlib. Ok for the trunk?
>>> Were there any changes that we needed to carry forward or any changes you needed
>>> to make to the upstream sources?
>>
>> I backed out the changes to the configure* and Makefile* changes (and
>> only these), which are completely different to zlib upstream. There
>> are no additions/deletions to zlib source files, so these build
>> changes still work with the updated zlib.
>
> Can you tell us what these changes are? Currently nightly source
> packaging is broken while configuring zlib.
>
> Here is what I am seeing:
>
> $ cd /path/to/gdb/sources
> $ ./configure --target=i386-pc-linux-gnu
> $ make configure-host configure-target
> [...]
> checking for strerror... yes
> checking for unistd.h... (cached) yes
> configure: updating cache ./config.cache
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: executing default-1 commands
> ./config.status: line 1191: ./../../config-ml.in: No such file or directory
> Makefile:10001: recipe for target 'configure-zlib' failed
> make: *** [configure-zlib] Error 1
I didn't change the configure and Makefile files at all. I see that Nick synced
the configure.ac from the GCC tree, and that introduced one extra change:
--- a/zlib/configure.ac
+++ b/zlib/configure.ac
@@ -4,9 +4,7 @@ AC_PREREQ(2.64)
AC_INIT
AC_CONFIG_SRCDIR([zlib.h])
-if test -n "${with_target_subdir}"; then
- AM_ENABLE_MULTILIB(, ..)
-fi
+AM_ENABLE_MULTILIB(, ..)
AC_CANONICAL_SYSTEM
Builds with srcdir != builddir still work.
Matthias
next prev parent reply other threads:[~2017-01-23 9:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 14:45 Matthias Klose
2017-01-12 21:17 ` Jeff Law
2017-01-12 21:27 ` Matthias Klose
2017-01-12 21:38 ` Jeff Law
2017-01-12 21:39 ` Jeff Law
2017-01-13 12:14 ` Matthias Klose
2017-01-22 18:01 ` Matthias Klose
2017-01-22 18:12 ` NightStrike
2017-01-22 18:42 ` Matthias Klose
2017-01-23 22:57 ` Iain Buclaw
2017-01-23 4:09 ` Joel Brobecker
2017-01-23 9:10 ` Matthias Klose [this message]
2017-01-23 16:01 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55729f1-7167-0ac9-d3cf-4f0cc5a5b3d3@ubuntu.com \
--to=doko@ubuntu.com \
--cc=binutils@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=law@redhat.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).