From: Jan Beulich <jbeulich@suse.com>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>
Cc: binutils@sourceware.org
Subject: Re: [COMMITTED 2/3] gas: BPF pseudo-c syntax tests
Date: Thu, 27 Apr 2023 12:05:16 +0200 [thread overview]
Message-ID: <a585c79a-553e-5d0c-3728-8bbff6546150@suse.com> (raw)
In-Reply-To: <87354labni.fsf@oracle.com>
On 27.04.2023 11:59, Jose E. Marchesi wrote:
>
>> On 26.04.2023 19:31, Jose E. Marchesi via Binutils wrote:
>>> --- a/gas/testsuite/gas/bpf/alu-be.d
>>> +++ b/gas/testsuite/gas/bpf/alu-be.d
>>> @@ -1,5 +1,6 @@
>>> #as: --EB
>>> #source: alu.s
>>> +#source: alu-pseudoc.s
>>> #objdump: -dr
>>> #name: eBPF ALU64 instructions, big endian
>>
>> I may of course be reading binutils-common.exp's run_dump_test wrong,
>> but is this having the intended effect of assembling each of the files
>> once and checking objdump output for each of them? It looks to me as
>> if only the assembling step would be performed for both, which I don't
>> think is what is wanted.
>
> It was an attempt to avoid having to replicate the same contents in
> alu-be.d and alu-be-pseudoc.d. Will look into this too.
I assumed that would have been the goal, but that's achieved by using
#dump: instead (in a new, small *.d).
Jan
next prev parent reply other threads:[~2023-04-27 10:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 17:31 [COMMITTED 1/3] gas: support for the BPF pseudo-c assembly syntax Jose E. Marchesi
2023-04-26 17:31 ` [COMMITTED 2/3] gas: BPF pseudo-c syntax tests Jose E. Marchesi
2023-04-27 8:26 ` Jan Beulich
2023-04-27 9:59 ` Jose E. Marchesi
2023-04-27 10:05 ` Jan Beulich [this message]
2023-04-27 18:07 ` Jose E. Marchesi
2023-04-28 6:10 ` Jan Beulich
2023-04-26 17:31 ` [COMMITTED 3/3] gas: documentation for the BPF pseudo-c asm syntax Jose E. Marchesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a585c79a-553e-5d0c-3728-8bbff6546150@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).