From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130070.outbound.protection.outlook.com [40.107.13.70]) by sourceware.org (Postfix) with ESMTPS id 4C5093858D39 for ; Wed, 19 Oct 2022 13:35:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4C5093858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hF7MhATd102Jsq55gs6+U4cKMWY27pUI4d+sLkGiijkCc/QWIkg0pUB5VB8rx+9mQGJeN1KuwpOmp1yghSQ0q2xxxUUoUKAo4MlHxJZtZ4OnWZOu9SZANJT2eyQUCpYCHX1zk+kBbvpkosHqG5qg1alYjg35nXtDiSKsl50soWN2L75PnmIt8mD2kfLuLk+0h17xavUwh4kkNFEGBOfIa911Ad9WDH3+dLvCTQ39wtxjFyHgVI+NjqDcCByHEZD6JmgZ255Vji/qH/unSIJHIlvcCuj3xJ/XO4yA59Ovea4WtjZqmzBrn4naEdkOM8URvvoeYyVkjJaTKgbd+VFgIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JTiYwdwt1fsi7ha6qHq39Kqife+t3dlVbYn7DagPnjE=; b=lTkzJkbzXMz9nTz33nvpJ2gAGs3He8xzX351RkNKJPwhELMpqPyDH8SICxhYiZPDRXQDnqc2wPhlFGik9Mb0cwdmLqDPWDn4/KxoKdNAfuj1GTKTLBfPQBH9yjTK5geu4hc6W/sXk2TKPsCSntoRzeP9JbItjlnqqFz1M6KC6h/VDeywgmPBR3ShFfdUP49rqWkHye2S+bB1dKeFqw2+AtuTmPHd8qJWsWy/VNKX6Vs2517ujrt9/IYm45FoQV6JodoEhKTHAf+TT3oV8l7kmq8VuknYPo2/mQpZIlZy36ORxDiKvnJ0HDYOPFBjVm7uGQNjpv3EPRFeap+Z0r8yHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JTiYwdwt1fsi7ha6qHq39Kqife+t3dlVbYn7DagPnjE=; b=ufvuh524NT09Me8gFz6l7uw1RjClviNNn2mTAjXqRVYDbHLzpIxF+uYlX+mRElns6Xf/WcfiVUPpDQdq8Xz6BpyF1yvGLrNfC1Jf21wNnMk2sMJczFzRtPJ3b7voovXrFI721ezDzXGgPVwhAn11gS7zid2JYMIpTY4IKgHuUBOYxI2UJIVYwHptlK5x1u+BvfAxLi4RGOo1KYd2wiGPlu4p7icMFBTIPsIubcsrD/PnuAx0DA1H+FY/bODdCCgQZplcVCrN5NMneRXZsCsBkVRkFdm/FE++c6MoN9qb34SIok+KK0qURup1no9I+Ae4wjitxZlnTnFC7RIey3LbSA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7253.eurprd04.prod.outlook.com (2603:10a6:10:1a2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Wed, 19 Oct 2022 13:35:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.034; Wed, 19 Oct 2022 13:35:56 +0000 Message-ID: Date: Wed, 19 Oct 2022 15:35:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 09/10] Support Intel AMX-FP16 Content-Language: en-US To: "Cui, Lili" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Jiang, Haochen" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-10-haochen.jiang@intel.com> <8e2d8a02-1521-5fa2-d97f-3de4c997818f@suse.com> <5b7c68cd-3e39-7b5a-bff6-3b966ab33be7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7253:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b130419-3a5a-4bb1-cca1-08dab1d6d9f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EJTxRgdT7Ytnp7laOjJnIS+prqHzMhknup60DNQWXx8mexedSH89ajlm+fUXqBrb9Tn2BV+erPx52yxktl5h2Svs5yj4fhZ8K4kd21bSEsc/LtA/bP5t6AeXvHdnDy+7qQ0vWksi7OYQF4524x26wURzeWpz+vyMArmFu1oJcy7BrqxezXrDrf/5pO5bczFvLJkDy0myhcyPjAbcUF2frm9Jvcq0h6+pMTebZ+BI4fzFzuOWaQXqi9ilSb0LdL/DEXvU51cdAr9IN9zEWhnV9aRmuvw0bxedpw+yhyy4BAhK5clXlJaoBhHs2G0mYSNDhnRuSgLL0aOyjoc8ze1D84+CVXReENoW15WUTSHpkM48ws5fFxRE8ODcRev5+zRRyJ842z78pPEq9i5ibzTq4yMaSvXpxQVn8uarE1X4A+WwbUNDZ3GD93DpCGZafh/9Z5+9+FKzSEnvUq/wL0B/b5D/DqsFwq7gE6FD/hXzsJa0kB5KN62ihlNRsUsGBVBND6vuzf7Ara1LXXqswcp10zANQyP8rcSuNYVud/hfd6flfQduZSf77U/VR3ozPrmOSMn3pinmPSskomxnii7eK39vb+Ii71mYmHgFmEz62hnAC/8kqyoC8IOnJjcPy2aJe66sX5X1WuCAE4gtnMyJmE9S85OflUoLKphjoUBtFl2Z6KXuAJhqFEiiCVZ+jBEXdWcEH9oIZXrx/wNgPI8qk0X+1WLWc75ET+yhKZ3ncV7zk5g0rtfoCIZ1n2SqLtM6KHTSKomLFN3V9QY51Vd6DB1GFy43Maa8mEOlazNZseE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(366004)(396003)(136003)(346002)(376002)(451199015)(8676002)(6916009)(54906003)(4326008)(66556008)(66946007)(66476007)(86362001)(83380400001)(31696002)(41300700001)(53546011)(6512007)(6506007)(26005)(36756003)(5660300002)(316002)(8936002)(31686004)(38100700002)(6486002)(2616005)(2906002)(186003)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OTJJY0Y4N0lOaVFOSTljZEZUS3ZKc0lnM1JNcWZoeEFVenFIQzZHM2hOMGIr?= =?utf-8?B?SmE1TmFiZmI0Y2orUVprNEkxWk05cGhNWXM5aDZHcjRFbFh3T1NUaS8wN0xL?= =?utf-8?B?TkJyNHErUG0vYk4yTEplZDgyZjNoVjFMN1B5UnNJcms4OXRvR0JhS0Nsa3gv?= =?utf-8?B?QlorNFBUVFM0Vi82MTlNdWRDKytqcXBYUlZyN0F3SDZVQmVkeHBEUC82bHdY?= =?utf-8?B?SnBKOTNPdFUrYi9kdzhZc3pCTDhjVHNJUG8velBlMENPTlBqVWw2VlhLRk15?= =?utf-8?B?cUFNVVpvMmFDVHFsLzA4N0pKc0x1bGZHdjlKN2R5cHVrR0Q4bDdzYlZHdmtJ?= =?utf-8?B?MDQ5WXJ5ZGcrbkFhUTJnZGJTMnRZQytmNDRWYy9ianNnQlVYZTJJOU01YmFh?= =?utf-8?B?K2JlV0pTOHJZUDZ3QWRUcDlSWlFFMi9MSERrTFFXMTNUamgzSmlDVHlVR0pv?= =?utf-8?B?TThib2w1Tis1dWJwMW1ldE5wR1ZQcUpIYW1qYThSYkNUQ3hRUHQ5ckZlRFd5?= =?utf-8?B?OURFOTgybEE3MTJTc3hINVVUVU93SjNXN0phVlU5RWQ0QVpJbmhJb3RWQXc0?= =?utf-8?B?QnZqN1EvQlQxdHZGbUU2aDlKR3R6NVZlWUtpSDVYSGpmSUNIc0twU2RwWGJJ?= =?utf-8?B?T3lCNlpjQWIrSDNCNjA4KzlsNG4xcmRNZXl2d1RjVUxTWHNMS25OR1h0RUdL?= =?utf-8?B?K3Z4U3dhTjRUdVJtM1FxOG9iQ1k0WlBBZ29TaTZ3RjROM3RxOHZPUE02WDho?= =?utf-8?B?RVRuVWZ6Vk1Kc2VPNE83QmNOWm9SWkpGS2RSWTBPMzZZcW1wSjBHVXNheHY3?= =?utf-8?B?aUJ3ODdBbWwvUEdqdWFDdUFEQzBrSU9oRWsrYitiSVhwUm9aSDhQSFRMY1M1?= =?utf-8?B?UmVhWUowTXZrdGVRUFpVUzNxa0ZhRitzMll4U2Y1TUJkUWh5a1hIcHk5c1lI?= =?utf-8?B?bjMwMUFvOGpJb3JoTmt0VFlmaUI5Mnh5NWNvNWdMQUdKOVBKTk1VWmtiR3Ns?= =?utf-8?B?NEs4b0F5azJHbGZ4dDZVNmNpeGxsNWlyMWlONlN6d3k0OVhWTTJqcFU4d3B2?= =?utf-8?B?VmN6OGx1cnRpV0FHc2ZtcjVZR1RUZGJJTCtSYWJ6bXY1N3E2UFZSdGozV0Zt?= =?utf-8?B?U2lEL3ZRYmM4a0w1K1RiMjU5WldBeHBqdDEyTFpCbklxM0ZBa0UzVjJLdkVC?= =?utf-8?B?UVMyVlIzblcxbFlLWmJlUTFHTVNMZ3RjTzFxY3dTajFmclFrbENodTdYZGVs?= =?utf-8?B?YVpuV0c3cVpYUHE5TEZSQVJ1MlpKRyt6NEdUTzc3bGRvUkhyaGV6d1Z0dHo3?= =?utf-8?B?Z0FGbysvUEsrek52L0NEcjJKN2tVaUtvd3hUMlZLL2FKMlJHOU5TWEdNZDha?= =?utf-8?B?R3ZXd0FwazVTcmU2NlJRUmJ4MGIyT0c2dE1teWV0WjdXY09EZ1pOZEpuWmZN?= =?utf-8?B?OTk4R0dGeExLbUhnWmRYeDdpYnBtWWczZXlybzdKdS9lRHcrL2FDWlJkQnlr?= =?utf-8?B?Y1RiUUtaREdPMFYwbVRReGlBeXpYNks4WU9KalExYmgwMmRwV2grbEQ1ckZu?= =?utf-8?B?VzVpNDZ2VTQzOG1zVGpYUUdZZm5WM001ekZzUERBck5CVDhuVHVKRHlvRHZU?= =?utf-8?B?UGdlQVV1eVp0TWdTTUZkb1E2dlVwMEVUUEtTcC9GWXhJVUpKUXRJZE9MS3M5?= =?utf-8?B?WVZTaVhyaElJZGRNNFl1WVBLcmNrOGtwOTFtcXRpK3BPaXUzTnZ0SGVKbVFY?= =?utf-8?B?SzRpNExyc1lKakRwbG9uRTQyTGFkZjBSbHZNU2tWNHp0NGx4NEN3M3FlWTdv?= =?utf-8?B?K1pZVVFuRFA1UkJMS0N5OVVLdEJrZjBERlY4MzMwSWF2cG53bU85TUQ4YjJt?= =?utf-8?B?Z1dxOFYxTU1FbEt5MFdvekNYcWI2Z3F5cnVwRndyRTNJSENCUE9WaGxJU290?= =?utf-8?B?NlpQd0JFd1VEYWVFRW01Wkpka1k5S212Z0I2cHBEc2s5MUtDUXZzQUNlUG9q?= =?utf-8?B?dHpmNktBVExHOGc4QzdqOEJsaytVU3psTGlxT1JndVVWelV1aVplSjUxbDRu?= =?utf-8?B?YkFidVZSdXU3LzFHc21RTEtLV3ZhWTEwdjBLSWNGeW5veEFSYURvanZaRzFQ?= =?utf-8?Q?rISm8Qe8ee5YHUWsGxcjtDNuP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b130419-3a5a-4bb1-cca1-08dab1d6d9f7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2022 13:35:56.6547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qu3FSFqrdhoPjOkyUgO2C17EMdybZhveDZKLDopRJqNuYWxXprw3Ty77TE84rE1kk0Z/hOFoFJcZz3piIFVaxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7253 X-Spam-Status: No, score=-3029.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19.10.2022 12:33, Cui, Lili wrote: >>>>> - "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16" }, >>>>> + "CpuAMX_TILE|CpuAMX_INT8|CpuAMX_BF16|CpuAMX_FP16" }, >>>>> { "CPU_ANY_MSRLIST_FLAGS", >>>>> "CpuMSRLIST" }, >>>>> + { "CPU_ANY_AMX_FP16_FLAGS", >>>>> + "CpuAMX_FP16" }, >>>>> }; >>>> >>>> Same here then. >>> Done. >> >> I guess my comment here was a little misleading (I'm sorry for that), in that in >> addition I was expecting you to consider the comment regarding the need for >> the *_ANY_* constants that I did give for several of the patches in this series. >> I think the question applies here as well: Are there dependent features >> known to appear? If not, there's no need for the extra constant. >> > Get you, there are no known dependencies now, and I will pay attention on it in future ISAs. Despite this reply, ... > --- a/gas/config/tc-i386.c > +++ b/gas/config/tc-i386.c > @@ -1076,6 +1076,7 @@ static const arch_entry cpu_arch[] = > SUBARCH (cldemote, CLDEMOTE, CLDEMOTE, false), > SUBARCH (amx_int8, AMX_INT8, ANY_AMX_INT8, false), > SUBARCH (amx_bf16, AMX_BF16, ANY_AMX_BF16, false), > + SUBARCH (amx_fp16, AMX_FP16, ANY_AMX_FP16, false), ... you still use ANY_... here and ... > --- a/opcodes/i386-gen.c > +++ b/opcodes/i386-gen.c > @@ -319,6 +319,8 @@ static initializer cpu_flag_init[] = > "CPU_AMX_TILE_FLAGS|CpuAMX_INT8" }, > { "CPU_AMX_BF16_FLAGS", > "CPU_AMX_TILE_FLAGS|CpuAMX_BF16" }, > + { "CPU_AMX_FP16_FLAGS", > + "CPU_AMX_TILE_FLAGS|CpuAMX_FP16" }, > { "CPU_AMX_TILE_FLAGS", > "CpuAMX_TILE" }, > { "CPU_MOVDIRI_FLAGS", > @@ -425,8 +427,10 @@ static initializer cpu_flag_init[] = > "CpuAMX_INT8" }, > { "CPU_ANY_AMX_BF16_FLAGS", > "CpuAMX_BF16" }, > + { "CPU_ANY_AMX_FP16_FLAGS", > + "CpuAMX_FP16" }, ... you request it to be constructed here. Jan