From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 1C94138715A0 for ; Thu, 8 Dec 2022 17:36:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C94138715A0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B8Fxixn020269; Thu, 8 Dec 2022 17:36:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=kHzspgjUCLK642/xp0kGn0R1X80vK0WikaAAuppOhGg=; b=l6cRjcB3zWKR+bBgrntpirCwnCirzv1PQx4nflTl9SfJ+GRLjZwzZkJ0E7qyYhJPnmzH 9khzod3O3HHmP4qpnP7Zv0eXhLCt5RQGldIuX91JRP6gcSVDBImOVvU5lZVDWyUhKmtr 9vTTZACr7yeDs13YCJFCPI9ecVGjfLyx8o/iGFiBdkRO3+T4v81U0xwW8s3CN7WMKChF jvfVWCqkTFhfpxPgEWaeHPYJ1ui8KFwmEcJsPJGe+pWKYZ+xwmge6EVLkxVRvL/Hsfn8 8AIMetRslP9WTiTSK8wLpW9P05GKXskT53ou2FwsU+t3Oa/37ncd9XqViZGzoHLYL1Hl AA== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3maud73fka-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 17:36:25 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B8GmoFS033852; Thu, 8 Dec 2022 17:36:24 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2044.outbound.protection.outlook.com [104.47.66.44]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3maa6b99ff-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 08 Dec 2022 17:36:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fTa1BPDBFI95wNxOBeB/rfbl4a6dq7VdHnie22GFVnxWPeae0tzc9zpdOT8iTGqrdLq26TKxwPdF8/OZZHcJtYrC3XYDtxEJRwJnLrguXzw5qXooaZjR79+au1Su0vQbQO4tChqgsm5pm5wWIDoxLTh42sYqcZ+M2y9FzyYWaX4CEtPIlAd1ZmPXRUhdUa4lTL9OXappV/bqxykLyQU0hzJPEH/bHRYFyJ2XrPmj4cAIogOcQOQSnR4oIHuIEJ1niOMr0O3HB5DIt65+9r4LYVLrut613lVVywJJnT3aWgF+9Tho1Kc685AQe0Nd4FxnZJjobm1N7ywbqVx5wtzErw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kHzspgjUCLK642/xp0kGn0R1X80vK0WikaAAuppOhGg=; b=Y4Shc7XR9FjNR28tzS92nhTf94iZuYIpLZnDjIfoV/CU27h1NXE3ST3R2C/kBX0nwwB1Mzns5w8OrCDziIhAkeO7O5VET79DHbDAbOTSdGQyoGyTkvxCwXfV1kr7QP17I+hpQgvhHqWWO4GW8CFBJGG4jmST5S4v2xXKKE+Wz6EnivUASdc2KRhktzj2yZkX/T2piPk8yGzU/BKzPQO9yFRjq+/HQPc0us++7s+S3pq8AtCDELGY0XR8PwEwfrUZXay7r8nL//xjNLXyMglQ78PibJqhtFYFoioCl8oI9CiZ04nZRM49yjCl9D0BYQEpG5Ok4pmyueAXiBKArfWXyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kHzspgjUCLK642/xp0kGn0R1X80vK0WikaAAuppOhGg=; b=HBbSaOHhP+dZqoVy/dGup0u6Wonbe2Rits9h38NewRmAGYoG22esd2v2baeU6qvZWJ35/VHg6EIJEVlyxvFpsnLfCoK12agGzNNbOtQn0CAjpcg94WHJqnq8DhYkIP6q9QFeZr1t9t9/rHJ1XVQoraiw/dzDkTJk5XlZZTC2hNw= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB7007.namprd10.prod.outlook.com (2603:10b6:510:282::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Thu, 8 Dec 2022 17:36:22 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::ee70:1952:4416:1bdc%5]) with mapi id 15.20.5880.014; Thu, 8 Dec 2022 17:36:22 +0000 Message-ID: Date: Thu, 8 Dec 2022 09:36:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 2/6] sframe.h: make some macros more precise Content-Language: en-US To: Hans-Peter Nilsson Cc: binutils@sourceware.org, weimin.pan@oracle.com References: <20221207195222.1182788-1-indu.bhagat@oracle.com> <20221207195222.1182788-3-indu.bhagat@oracle.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0380.namprd04.prod.outlook.com (2603:10b6:303:81::25) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB7007:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c5c64e3-0efc-4023-7a1e-08dad942b8a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: knrZrBLM1bleq05NcD5h+OwDSCvohzWBs42QZy97k2E6NcV/t+F7O1XKsQpJ8IyxX5CWSuOBSHPj2Lxunf+f0/0Rki3jh9pwedd0D+rHakOMxoO2tiKh6twM+xgKLOmjLpklsIRLugsZaRWl7dFVyLa2akJ1KpnIP576SR6A+4eo2cKj2wRbBbWJ7rpNx7DrVDPgLl9GGJOkyLZO9cEAG524NksC72lxI9dMmawto9Y2cqopxXE9EVQl+JSMQOXTQ7vzxf95EJ/LMPO8NuowK+UMOv90KzwMLVFFwHNoRiYG7XaxiP8kk/CiBU+Hf4zwY8xiqszjTxDhSt+rZdeD7sWjD0h3+ENkMI+WAAEOPxj60cNYVccnSrtKYSVvcwyHYk0GSfH+2lEKuSeL03byY3zI9K5Xt0Ii8OZtpVv5sYDynPTo31fX74ujhv9DthWc0HN9g4c402kgqrnh2ssYjBkK5JldDf4Co/6xt1Z5sEe2c73s/5l9h+6WoDvTkcGvupDkrEYQYLY9TTQtSyezI4PWYJmnlfnlX9YskRDW9fHnXNLl7T35FzTxl5RNlU4Vge7AKkDJOaUuxb2mVzDwouAuWEiVGvRxdXRpjMovLj+HqaHp6BnklAnoLz2JVgkH2B7qlRVpdTu05nehUlIhrRUCZaOaWvO/Yop5ZjKgwOgg8YyPaTbxxD5A/D7XdSH+Rlp5gUrjokWKA3jYx4owfALccAbnWvNbiLhmRY8z69o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(346002)(366004)(376002)(136003)(396003)(451199015)(44832011)(83380400001)(86362001)(6916009)(4326008)(66476007)(41300700001)(316002)(66946007)(8936002)(66556008)(186003)(2616005)(38100700002)(31696002)(6486002)(53546011)(6666004)(107886003)(6512007)(6506007)(36756003)(8676002)(5660300002)(2906002)(31686004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UCtZZ0gxZlptUC9lQk1lNURad244K2xNTVFsRjJGVWI2WTBIbDZ2YkNlT1No?= =?utf-8?B?SjM0dng5bjhLSytUMFRPekVtNHVmaDZkU2tMUnBsSWYzNDVuY1VZV1JnK1ZH?= =?utf-8?B?ZXNEYjcxY29zazcxZnl1c3FUV0JBVitITWx0TGhRQWtwa0FxUWJQZlZ5TzhX?= =?utf-8?B?L1BhNmtMd1loNXFMNzR3R1VFc1FRSmovbENDaUx2VGZuRldGZ3I4QUFzRDh5?= =?utf-8?B?c3lkazA1SGVXQnllUlc5cWZrclg4VnFBNWpSdGg5R2hyT1loemtvNlN1WjdY?= =?utf-8?B?K08yY21WM1dQTXcwQndKVy9jd05WK3VVbENKdW0zWjN1VThOWjJhNlpJWHVw?= =?utf-8?B?eXFnd0NhdjByWVRYekRoSXo4RHB0WldGTVpmMmthdFYxVU5MUG95NzYxRWZi?= =?utf-8?B?bUgrWWhoejRRQWQvSkhIWVY0T0dyRGR3K0dQeHNSRXZvWUkzS2pzek92N3hi?= =?utf-8?B?QU5rbnpRU1NJUTB1UXBDcUtqcHR0WGo0R1FnRGNkaWpOaFpaQjJ4SDhqcnBE?= =?utf-8?B?RjZKWU9XQndrZzlIR0doOWVkeGhZdkg3RzkxZEppUm93ZWtPUncxaFRtQnRQ?= =?utf-8?B?ZWNzVG9HdGxreEpJUmVsSG5wN1pEYUorbVc5b1gyWVlHb1JFaVB0SnZMQ3NW?= =?utf-8?B?aG51SGxHWllmdHV3dytXa1RLNmhyQ3ViMWNWcmZ3eHNQakFQc2N6RHBZS282?= =?utf-8?B?YXNCVS9wSGtHZll6OEhXK3VPOTRMTzlMaFJjK0QzaS9yYXNsbnlFcERZbnlo?= =?utf-8?B?bWNweWV4c1ltalpHL3NtZ09TdFh1Y0xpWXllNHMxcTBFZTN1akR3N3FDYzhK?= =?utf-8?B?aWk3Q3ZNNm9DRG56Q2s1UzlIYmNjMmQ4YVVFaGN6OUVRbWdKZm1rQTlzOWtX?= =?utf-8?B?bmVQbDM1U215TDFBNW5JSjhQTW9xQ1Q2azE1TktwaHpJay9BWDgxOTRyZGgz?= =?utf-8?B?MGVrR3graGF5RVVmanN2OHVCSlNlYXRpM3NNa2Q3T3RlYUNzWTVZTmVmL25K?= =?utf-8?B?cXFTMjJrQm4yQm43M3FpWGNMWFVsb3V3dHJsMUN4bUJzUjRyN1hrU0JkVitq?= =?utf-8?B?OGFFRUhkclhrTStMY2EwSS9QNksxS3JvTE1xY0RjbjVlVnBxam5VeEE1Mnd4?= =?utf-8?B?L2V6S0lGSFdRREVSZlBhZHB0Qmdkc3hCR3Zsa1BCRkdMYy8rUWo0OW1KamJX?= =?utf-8?B?NXE1Wnh3VlJzZlJyTGdtQVNYd2tEWmdyYUNLbHE2WXhzakFEMm1YZXZJWWlG?= =?utf-8?B?d2FhUy9GMWhuSVFVanBXeVVjU01VRnMwaitaT0JJNEphMGVZaHhXZjhYc1ZQ?= =?utf-8?B?amlXVEFwVXpLQkZhY21QMUZIOG1VV1FnN0hLSDZvNm9VMDdLUzcvbU90MFV3?= =?utf-8?B?T1NiUlhqZ0NYK0NPdjlFUFFVa2cyZlR6UUpJQzd0RFZib2MzSEJmMUNJbFA2?= =?utf-8?B?UG5EckZiVk9mWXMra2ExcDhhZ3A3Sk84RHgwcmdVUGdBZjQ4WGZCcFltallB?= =?utf-8?B?MitZQmlwV2p0WnVCNjQ0bERuS21LbkNCSlRYT044b2FUS1lsZW1GMVVOOVR3?= =?utf-8?B?eWtwblo5emtLVncwRWFqVlgrZkNGUmk1eW1PZWE2eXg5L0g2REtRSEo1d05D?= =?utf-8?B?T2JnRG90RllsRUZGK2pOSWVodDVKRmZ5WDRyenV3a1VQL241Q2NEbm1aTDVR?= =?utf-8?B?NWgvdVZwTGM4Q3lycXFQcXpJM0FGSXdyUFNQQS80emdYQXR5OVhLRnprdlMy?= =?utf-8?B?NFM0MVl0ZVhyWTdiL3pMUHJPVEFkN0tqczVyR1RySS9qc2xTMUlnYXBZUjlT?= =?utf-8?B?c1JuVlE5c1pscFdwNy9yaVUrd1VLNFhBMW5HM25JRmIyYnpReUEzS3ZCT3Fk?= =?utf-8?B?V3hRSkp3bXFFYmdiSlh2RkRMY1JmVFoyekk3d2QyNGl4LzIwNExta296Qk1t?= =?utf-8?B?cG1VWnBISmN0RFJsTHpDWmtzVGVmQ2F4RjlRK2dWVlVIaTRNdzQzcVY1akVR?= =?utf-8?B?N1Y5V0FQc3BYdjZxVEUrY0lqVlRjWHRDTTR2NGRJT2tKelZnUEkrbXpKb0ly?= =?utf-8?B?T1BObzlteU1lOUlhdWpBcVg5SjhYOURaYXRuWmdWdy9TdWozWVVHODR4Ump2?= =?utf-8?B?d1NkYmw1UFAyRy94MTNlOWNFUTZSSkk1QzkwUkRyRE9wZGpwS0ZRcWRWNW13?= =?utf-8?B?aFE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c5c64e3-0efc-4023-7a1e-08dad942b8a5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 17:36:21.8548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7U0JGKCYO7lTCD9qNGSKpwNZr37fFFUALWbgcq/y6Bdhuo8rNTJAUc3zOmnXad9seJoIS9kFojdnJEaU4QAbRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB7007 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-08_11,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212080147 X-Proofpoint-GUID: OqW_9xXA2K_6v2ekCHxxjmVBGvOpy57c X-Proofpoint-ORIG-GUID: OqW_9xXA2K_6v2ekCHxxjmVBGvOpy57c X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/7/22 15:52, Hans-Peter Nilsson wrote: > On Wed, 7 Dec 2022, Indu Bhagat via Binutils wrote: >> include/ChangeLog: >> >> * sframe.h (SFRAME_V1_FUNC_INFO): Use specific bits only. >> (SFRAME_V1_FRE_INFO): Likewise. >> --- >> include/sframe.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/sframe.h b/include/sframe.h >> index 7e31284e4d8..ba557b7bf7a 100644 >> --- a/include/sframe.h >> +++ b/include/sframe.h >> @@ -192,7 +192,7 @@ typedef struct sframe_func_desc_entry >> /* Macros to compose and decompose function info in FDE. */ >> >> #define SFRAME_V1_FUNC_INFO(fde_type, fre_enc_type) \ >> - (((fde_type) & 0x1) << 4 | (fre_enc_type)) >> + (((fde_type) & 0x1) << 4 | (fre_enc_type & 0xf)) > > Random comment: you removed the full parenthesisation (sp?) of > macro arguments here; compare to handling fde_type. ITYM: > + (((fde_type) & 0x1) << 4 | ((fre_enc_type) & 0xf)) > > Looks like the SFframe code "has improvement potential" in this > regard, because right in the context of your patch, there's: > >> #define SFRAME_V1_FUNC_FRE_TYPE(data) ((data) & 0xf) >> #define SFRAME_V1_FUNC_FDE_TYPE(data) ((data >> 4) & 0x1) > > (Pre-existing badness for SFRAME_V1_FUNC_FDE_TYPE compared to > the goodness for SFRAME_V1_FUNC_FRE_TYPE.) > >> @@ -240,7 +240,7 @@ typedef struct sframe_fre_info >> /* Macros to compose and decompose FRE info. */ >> >> #define SFRAME_V1_FRE_INFO(base_reg_id, offset_num, offset_size) \ >> - ((offset_size << 5) | (offset_num << 1) | (base_reg_id)) >> + (((offset_size & 0x3) << 5) | ((offset_num & 0xf) << 1) | (base_reg_id & 0x1)) > > Also, here too, you just added one more. But better improve it > than making it ever so slightly worse. > I agree. I will fix these instances. Thanks for reviewing, Indu