From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 886D63857BA3 for ; Thu, 11 Jan 2024 07:57:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 886D63857BA3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 886D63857BA3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::334 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704959879; cv=none; b=tAu198m/X9OnegY7MziLkZVqGfhEabuFGMkFDXrCKvUUgvkVkiRJQwuMPKfkmU0F6VV8diYEn/4HMzZsdYPQUbweo7xXdNGizt25puTjk+dqT9faAnG3xr28LvUuvaZ+dVFE9zNfMfY0Px7oxmAetazIQZGLmriKrRaUQAG4yys= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704959879; c=relaxed/simple; bh=1Ql3jB3X/t1pAESS3TuZX5QBzLhSlcs/CxE4nA3pJlQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=geZ1lA8LVO4ROIBgRXjC1+oCGjNZucAoVNRwQjMGCrXhCQnFcf3ox77yoGL/CNSNcF6cPwHTDWfbvjIlZFpLgM1Q+PxcGl8OuFGYaABcegFz+UDWdQI0qjuXtgg8tyHty4UwI7lNF/z47SSPtoePn10/idHzhXVmwNnLiuJVUrM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40e5701cbbaso8261245e9.0 for ; Wed, 10 Jan 2024 23:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704959875; x=1705564675; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7JfVc64Ln5zSzJkmlP61hzIJUGgPqk7tdU4PANBChh0=; b=W0RBJfJZkHdE4eRi+FHv71N5DGBmlzIBNsmUKCxBkyjmeeTDH0DCHWGX39UVwKb1Pl oJi45PibvdH04o3kXgKFLbeP/ywJZ6AxNAuajqwowPOII0M3nFC95qliN/yKBNx7eZpz p2+JAPu8s2n+8dDAU859Hc0Dl6PvLsEJ8QdykxW0RC32B0Rs6anwkm90i9gJKTwQKdt7 ekATZlJAyu5AB55NhvlhFnLqnfxabqiCIZszo+6vaR0Yk2aBHN9scCOESMtldVCa1UAo B1lE9oeXYkC1rCByw13hnCxTa3k+EBSR3jKBN54KxWb1CA3t8h+JNqnbxKn45pH8ZU4R e34w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704959875; x=1705564675; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7JfVc64Ln5zSzJkmlP61hzIJUGgPqk7tdU4PANBChh0=; b=RKy5zeRGnZgkUqgYCtKaXCACVZxaTIbOV1SCXQLdXM2AJq2tP4sItXFxZX4/okxP1C lS4wCCMYA6md8FUitKf4CwMiNnQfRt0rI6QbqBn/qggRhnfobnC6iuFzxFpXNjAoYfyv 4YraqyXkg5adCKySJ2M6u39pNOHIQ9ERGa1DpP45/4Z/JMWAAkShYaBZFC4JiI2uF/gy 4kwXuTXTXC8P+v9XifdJbP1l9NjHqIuQSrWiiO88OQtI3U2Q3rEzTtFhPwDRy3tyEtyG Tnp2LpOm5olvmmlzsNvoJSr1feTwkn+0E9JLB2gFuCXhfu3jSW2eez26Ir1ezQcxjaYD c/dg== X-Gm-Message-State: AOJu0YxdJ9jxNgOHh4aWvllNe32GjZpeM7+jtiV3jNWFlaDo3HjezmVQ EGCnL9Nfz4YjHzhjsnGW/UK1+Qyy9Km31lrxeA6OUyLtKA== X-Google-Smtp-Source: AGHT+IED0M97tv4tZBt+FLOl3kI8aowKO4u7GVRhPSk0jmg0nv88kGvgmDT9C5db3ESbHINY4pVKdg== X-Received: by 2002:a05:600c:3d10:b0:40d:9236:cd9e with SMTP id bh16-20020a05600c3d1000b0040d9236cd9emr123337wmb.35.1704959874887; Wed, 10 Jan 2024 23:57:54 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id p21-20020a05600c359500b0040e3488f16dsm869340wmq.12.2024.01.10.23.57.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 23:57:54 -0800 (PST) Message-ID: Date: Thu, 11 Jan 2024 08:57:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH, V5 11/16] opcodes: i386: new marker for insns that implicitly update stack pointer Content-Language: en-US To: Indu Bhagat References: <20240111074820.2677826-1-indu.bhagat@oracle.com> <20240111074820.2677826-12-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240111074820.2677826-12-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11.01.2024 08:48, Indu Bhagat wrote: > [Changes from V4 to V5] > - IMPLICIT_STACK_OP as a new constraint (was attribute in V4). > [End of Changes from V4 to V5] > > [New in V4] > > Some x86 instructions affect the stack pointer implicitly. Add a new > operand constraint to reflect this. This will be useful for SCFI > implmentation to ensure its correctness. > > Mark all push, pop, call, ret, enter, leave, INT, iret instructions. > > opcodes/ > * i386-gen.c: Update opcode_modifiers. > * i386-opc.h: Add a new constraint. > * i386-opc.tbl: Update the affected instructions. > * i386-tbl.h: Regenerated. This and patch 10 are okay as long as not committed ahead of time. Jan