From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by sourceware.org (Postfix) with ESMTPS id 33F923857430 for ; Wed, 4 May 2022 08:54:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 33F923857430 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2176.outbound.protection.outlook.com [104.47.17.176]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-23-lALP3VuePV6XcBzJGpjLSQ-1; Wed, 04 May 2022 10:54:27 +0200 X-MC-Unique: lALP3VuePV6XcBzJGpjLSQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4jGrXfO9NHdo7RdaMJqgv/33udLfj1sy94gH420FBeiRNmq6OPQBBChDJF6SzY23XzssqIitF24xiFln83OIHjQxuoOFerLo6HacGoP21cYseVRcDp9pyRYZ+ilOQHkyGcyK5jN3PDUrvc0SKfTmhQwLiYIrQL6DLDjHJgq6E70rw667AhQvIuURQwFP3DXFc3R5OKPMF8fcil2oWcLdLctr+0UJBgmf/N5dcdqcTlS8aEi6BTDLXtfW6mpuB4DXrNc/ZMy4kgtfsYGPfrJrghlsxUwTtM90aTurEWTZM+Tkw0pdefKLk5+SMpWLVU2nCnOMLF1cvwDSfJ+7ZRIrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EZcTZOzWFlzC5d8e4FR5E3FFg0agVpRmSfLdxOAIshQ=; b=MM4mYPOqVYy0AsmfGyqI1pHbmNpsZPrKVqowL14dhIcf6L4HvtTRF+f9NmPEi0E2eCXl/YIZjrFvv98lwpM83AvR3af1RVZNe6+YREYKduMoYJT6EmhWEnPa3McICkSiZUsN040RajYtdtnpkkE7pt/cvlM3D4tbXObpeLxQHyq9ChYoCTcnQBhUO07ltI/mjyME99mOJsZn/VUDYQrYk2lskW+1k8mQOuzCyb15YRkqCyTD40LOj2ZgbOZ/5he/isww5I3fIAbt54Bk/6NLpF5ODqTs8gEE2okZAgMFHNZlw6mbaPRIcdbSqIiOruQDiZwCzsy93+NKVrZkF49o4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB4997.eurprd04.prod.outlook.com (2603:10a6:20b:3::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Wed, 4 May 2022 08:54:27 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%8]) with mapi id 15.20.5206.013; Wed, 4 May 2022 08:54:26 +0000 Message-ID: Date: Wed, 4 May 2022 10:54:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Alan Modra Cc: Binutils From: Jan Beulich Subject: gas: set_symtab()'s setting of BSF_KEEP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0049.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::26) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd78b86f-1550-4d46-531b-08da2dabb186 X-MS-TrafficTypeDiagnostic: AM6PR04MB4997:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nWVs3BqUNE98uWXWjofHd7KYIn6YvP5JD2SdP2xWc/gSUbIkk3y89j5DZPqR7fxHQQHV54swV2Y3jX0VBs8HlazjseQ+jHcqZjAjPtmhJqU3XzTe2xE887C2ZFay2i9uJiLJ3F0AptOmZ5M23GWuzL2DC1gM9IrtUDM+2e1J/OU4qzlWew9EQCQIrxTGTpi7kdbEQz4vl2umxIVEIx6loUKqFTGJNVoKPlUEAVZVnWyWr4TC2dA9bQ/Cbf4Vc4zqOCH6jpgKdfmO66KYzmtlSLQmiGKR2pmR89B+cb5TtUGVDDhHq4MvjC5mRHC81Qiii1YCWbmRN0rZF1aXbeBHwA4oZg2ncwp7DH2ngaQqCax5hnWDVoGeSVC6uYmR8bdESSJBbKDfVwNOerY5qFHxVO0n5vD12l59V5xpDr+0dDkndPACyuWzWVH3z5AugEA8HPspWRWq8e8GVNpMtlx68lCNXlbNd5RaW4nW8/E2677hF+aTAVxD77/1ZIvME0ZnyKRsto94Hqg86wLx0Y1MB0Hk5YIXbs7DqP6+NimXebpBc/ICkzH5es/XMXGgq4ZetwHyzrSnoFjKvqtV/jtyoJ4Agq2AJLVUs5/L+dhBEUMRLB0FJdKf4b3clJQAz4UL8s0U40RV3JDVc7cdNgncjNFfs90LBIATZMxW7aDab+aSLIYtwM2XHYE1ayAYst5X94NhOPhOQF5/q1nUcjmizqIpxahkRo6o0k9GQHg7omA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8616.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(6506007)(4744005)(38100700002)(2906002)(86362001)(186003)(2616005)(6512007)(31686004)(36756003)(26005)(316002)(4326008)(8676002)(6916009)(66556008)(66946007)(66476007)(8936002)(6486002)(508600001)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekVyOFcwQXEwOHNPcWdLajVEYjFaclFoSTVjUk1ydTA4cXFnWnAyUFhIR0Zm?= =?utf-8?B?S2g4bVBWR1l6R3RWY3dxcjY2ZUdTU1Bva1Y3L0w1TVNvNWIxOU9rbkJlMW1r?= =?utf-8?B?RmcwbWExZTQ0YVVuOE41KytXdHA3MFIzbmpUVWQ5YWRqUUhvRnZvMVhIS0lP?= =?utf-8?B?YkNUQTJLY05SZXI5bC9JV3YvS0JJTCs0V2d3VVZ5V3hHWHgzQzlwd2RuVkpE?= =?utf-8?B?TVpCT1dQdEFIZ1FXYXN2eTA3eUtkVVZGbm5aMFRGYng0d25PdktBSEpkeVVL?= =?utf-8?B?bjd6bDFqRzFBdy9JUVo3R2VQbm1ucUxRT3VzSFdkU2lrUnpFR1dhTVp0SUJM?= =?utf-8?B?SmtBV0h2SWcxZzJHRDJZWFFkcTlaZko5ekVST2FyeVJrWEpueGN4UE84M1Ux?= =?utf-8?B?dnZ6M2YwODBPV1VzR3A5WnRkVmVVQ1MzMnF0WDFvbzMxdWI1RE9vQlBJQjNH?= =?utf-8?B?cE4vbWxibmlCQm9pRnlNRUhJL05hVkJPWTV1VHNaM21qUHdFTGt6MXNFZW5B?= =?utf-8?B?aWpvNWhOMXVLeHdDc3hqNGJ0WGxyNE1hcVFPSTNCRW1qWE04bW44Rloxa25X?= =?utf-8?B?U2tGc093N2RJTjNPd2hONUNYZ0Y4Y1QxdEV0OUx6cUxSWmp4ZGhXWWg4dGZG?= =?utf-8?B?OEFRU2F1N1lsYXlPeGVkNGhKNjhEU3JKNTRXRDh4L3Q3eUdpSWcxTGY2T0ZN?= =?utf-8?B?clJjSFdwQUQrN0lSSjJHSmNtZVhncWZ1R1plRGdLTHBrcmQ2YW5QWVU0Y1pw?= =?utf-8?B?ZWRoSjh4SnlzemxOWFJhSDU2VXpGc3lLaCtXdjVORmlSSVIrYVJ6Tk5rYzdT?= =?utf-8?B?OXZPL3YvTXIxSVF0ZUk1dXZRMmhTZ3JyYUl5MTI1Y2NOdzN0SHhLdW9vNm9C?= =?utf-8?B?Kzc4ajBIaFV2NFMrMHkyLzJzNlFVMS9TLzBjV3lPVTlPUnZveEpRbGQ3QUlJ?= =?utf-8?B?QisrK1VCSUxSQi93ckNGSkd2ZGxncjhtR2d1NmswMlNTL0xET3hXbXdCYU9N?= =?utf-8?B?azl4eHUzaWZqa0hlWmRDTmlKa012dHNnT2R2bHBEd0hsTERSVGczaVlDTDVm?= =?utf-8?B?V0xNeGFZT1Y5N0o4cVArNDhzZzRlT1BJSjZLNUdYbWZISE9SR1prcFQwakxy?= =?utf-8?B?NmhJeW5tWEJBUWl1bjJETDZKSGlMZFk1QlcvU2dDZmVZc25xU28xMDlvQVln?= =?utf-8?B?Z2YxMktWT1FFWTdjV09iZkFuWEdDYjhTMlR5ZHNzZWNGNjFMRGhPTXY5bEtk?= =?utf-8?B?VC9Zc1NlUlRMN3M2Wjh0ek9SeUJ6RTFaTi9TNUE5MUNUMVprZTMxTS9oOTdP?= =?utf-8?B?bENxc1FkSEw3NzA1UHJ3VGlRc2YxQnFmTWZ4VFF6SnVMTUVML3BVR2xOY3Bt?= =?utf-8?B?MWtzTXFmdUIzMk44T28xQkFuOHJQQ0JDY1dXNnFwZG9ka0ZsUDJOZll2VDJZ?= =?utf-8?B?SDhkbG1MZ2dJcUNGOUI2bmFBYUI2MEg2TkxxL2JYNkdRNU5HV1lkMUJQWjlK?= =?utf-8?B?WjBNdTdRZzkzcCtJN3pFbkFTcEhtbVJSSjl0TXloUHdVODZ5c04yQmQ2bzls?= =?utf-8?B?bDNhWCtCREFWUzIxcFZCcE9xZ1ZQR1M4WWhOS0JnOGRDbHpFbE9wbytORU0r?= =?utf-8?B?MDZ6a2F4dlcrRkFvN24yT0kvb3h6L05LSkpMSFJDYk9SWUdwKzVGaktTandH?= =?utf-8?B?blpkNU5pdHBwWktSRW1NRXlHOWVNbVRqK3puNnBhclJ3SFVzTmo5U3lvMks1?= =?utf-8?B?WkR3N1ZiSTJhYmczT3BTQVdVdmhBcC9WWVRYVEZqWXhpanAzWXlDZ3VxNUph?= =?utf-8?B?cmIrNURaTkc2a1B0NzlTZkE4MXBZbk54ckQrQVUzV0hyMGlGZkp3bUJnOTc4?= =?utf-8?B?NGs2dFBwV1ZYaDBtaUsxL3hERStCTHNPYmNlbFhqeVoxa2phSzg0MVZVbU80?= =?utf-8?B?NjFkUlJPcUhkQVdHWUk3UXdzUlhKbWFyUG00b2Zyc1V3YXF0YmNKekJrTmlo?= =?utf-8?B?TEhQNkVnYmxnM2g5a2NnbUpuTnlYWG5scmZHVVlnM3EwWFlDbm1EaFRIazVk?= =?utf-8?B?ZXVnbFQ0KzhuUWIrRWROYkd5Q0hiNi9SdGtTZFdBV1JEaEF0bS9EM0lJRFN2?= =?utf-8?B?d3FMVkRpdzVxY2tYdG12dTF0QVRGdCtVSVNvVW5FRVNIZHR0UWRnZXRqSzdF?= =?utf-8?B?ZURnQ05BSksvNU9mWWxJWEFhZmVlcXZocHR6MWc5Sitrb1poZjZvaGx1c3E2?= =?utf-8?B?Y1V0V2hCNGZJZFNXV1kvNnYrQ1dNeDlRS2JreXd2RnBVMVN6VmJXb3pxRmp3?= =?utf-8?B?TS81VElTKzk1RmVYMmtFY1F3VDlSOEFzQVltelN2T1VZb00wRUF3QT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd78b86f-1550-4d46-531b-08da2dabb186 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2022 08:54:26.8936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ytOgf4WBAEXMRlnTGWk73l9C9yPJRAJB6N3bcmyv3rYz3EZXjKr3jFvsQUIxyTKNPyuf0qdvCwqjgasIEDCz9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4997 X-Spam-Status: No, score=-3031.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 08:54:31 -0000 Alan, while looking into how to address an Arm64 regression I ended up coming across this code, originating from commit 76d129399558. The first thing that puzzled me was the != for checking BSF_SECTION_SYM. Shouldn't this be a check of just the single bit? The other thing looking slightly odd was the mix of || and !( && ). After transforming the whole thing to if (!(asympp[i]->flags & BSF_SECTION_SYM) || !bfd_is_const_section (asympp[i]->section) || asympp[i]->section->symbol != asympp[i]) asympp[i]->flags |= BSF_KEEP; it then occurred to me that the last part of the condition ought to be redundant with the combination of the first two. Or is there a way for *ABS* to have more than a single symbol having BSF_SECTION_SYM set on it? Thanks for any further insight, Jan