public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Maurizio Papini <mpapini@redhat.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 0/2] addr2line: new option -n to add a newline at the end
Date: Tue, 10 Jan 2023 16:50:14 +0100	[thread overview]
Message-ID: <a67e7ffd-6fd4-3e89-c5c8-e9fb2ea770a1@suse.com> (raw)
In-Reply-To: <CADCMg4M+B2YaShBQ0wnj3UC7+sqQw3eALRyw6JBLCDBmhXr2=A@mail.gmail.com>

On 10.01.2023 15:17, Maurizio Papini wrote:
> Thanks for your feedback Jan.
> 
> Yes, I understand that one option for a single newline smells fulsome but
> the
> idea is to use it to mark the end of output when addr2line is used as a
> "server"
> process: right now I see only the "-i" use case, but there could be others
> in the
> future for new options.  Said that I would propose adding the "add-newline"
> long
> option only to trivially add a new line, that could be reused for other
> output.
> What do you think?

I don't really like the idea, but I can see this being a compromise to cover
your use case. Yet in your reply to Nick you indicate you might go the route
he proposed, which I understand would allow us to get away without any such
option. If, however, an option is still needed from your pov, then please
make its name more meaningful than just "add-newline" - that doesn't tell at
all what the real purpose is. Maybe "separate-<whatever>", with <whatever>
suitably replaced, and then possibly also (in the future, not necessarily
right now) allowing to specify a character to use as the separator in place
of the (default) newline.

Jan

  reply	other threads:[~2023-01-10 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 13:53 Maurizio Papini
2022-12-19 13:53 ` [PATCH 1/2] " Maurizio Papini
2022-12-19 13:53 ` [PATCH 2/2] addr2line: test to check -n option Maurizio Papini
2023-01-09 16:04 ` [PATCH 0/2] addr2line: new option -n to add a newline at the end Maurizio Papini
2023-01-09 16:17   ` Jan Beulich
2023-01-10 14:17     ` Maurizio Papini
2023-01-10 15:50       ` Jan Beulich [this message]
2023-01-10 12:19   ` Nick Clifton
2023-01-10 15:28     ` Maurizio Papini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a67e7ffd-6fd4-3e89-c5c8-e9fb2ea770a1@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=mpapini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).