From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2067.outbound.protection.outlook.com [40.107.6.67]) by sourceware.org (Postfix) with ESMTPS id 8F7B03858D28 for ; Fri, 3 Nov 2023 13:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F7B03858D28 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F7B03858D28 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.67 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699016718; cv=pass; b=AZt2dKxKFjLhc5UVL7YYwcB9YksSx4clWjwJaASg3svcLKREJBve1valVfSzhjKxjAbv0CgtPszXD+NlROnKB8+IvY+sJuRPbIR6faJoiKsmdKFOpGjHpGJmKk3BoXz7U/d3UJN7bMWGeQRbR/EkOT7J9pCDsq3wA1LNlqCu2bs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699016718; c=relaxed/simple; bh=BHaF3hvNUaVfDJ+hampbK2D3kg2nVXsbJA0QdzCCseE=; h=DKIM-Signature:Message-ID:Date:Subject:From:To:MIME-Version; b=tiUUFB1TABrwvUSXm/HDYqcLGz/zgPDVF8QHGBmzGQO6G9b0B73eiLdAb3750PCUg1pt3TaV4xHUYvdFHr6nn8d5kRZaelecb8KJzFLa0jrKpIkb/NjwQULirjPB/irnoYqfP4BE3QBYWTeAIC3sMNxRx/aLGsOM3NsEV/FJVqo= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qug65S78NQvx1EUbWqoGHrxdsiPyawxgr0r0HLVs/2xtdfbWVmwIs4DwM+24kmQkIZeaVEKvvgZoCwwoMNXd8+bLQqdfk6VLmAO049wKgAIWRYaFc8jgQxnpYaP3mVe9p+2JU61XTH+PljO3bIMOMVnt7/fhkvd+dY99HI34r9iJoa+2Oj820lNjeX2hsNN6rdnH4xU51hXGFxA2yL3rKNgphMPUUs2++lCCuZJYMsaXxtmWyPImqPY99rgyaNyJob6lBrlX4qs2/OOxyKoczDx1sfQcCffR/5ht7NrbKGmwQSqfoO2m84qbTiH9E1f/TRwxPm2TRToADhz2pgJIaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BK6AksPjpcFuiPk77pNLCHMi3hNGgrgW4RQgUwnpRuc=; b=nL36165YuAbaU5s6LQEHF2MdavJzxdfg4KkHCS8ojp7x9q1uaMnmi9sR5v62hmA5rf0xqeIA+t52Eo5bD29G3RiQWOIwQEarZU2D6fqp2Xn4CyH2m9YMTbahDv9ahjl4mQ/jd1REkFg+eEGtLlNejfGSV9UUgf0r80aeEOysNx57ZIGWw0IDtr3jJbaa6SFFEXM6bctHLVPm4LmR82B+FuKtSVJ51V02P4t7/NAX3Fj/TyDZLKTjgNMFrT3mYKBGtr9OHwV5CYOgqHHqD4gCB4wkROUmuzjnBnFkhL/HY4B+0f7tRwAh9nvLaRwz0sqUMTL1JoP7jH3nXmhFTZYyzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BK6AksPjpcFuiPk77pNLCHMi3hNGgrgW4RQgUwnpRuc=; b=fyYqRJMwdo5WjinQeIXUZLiv6ZkBwZJmgRmQHKlECKFv9jTpVie5I5y+PuuW/fCLgOLUt0n2bXipjsP+M7MTIJAC7uWa4MLVD+1hVAeHLzv5SnnO//6mVyQspdgn27uDV85NPbl7D8yT9ZRLdMQkm8CorqHfDaz/ZHSG4dND4RtGSqF801fagacfYmeFJYq1P9EqLxXQhhRpnM+K1UeE2DPycazgbFgaN/ZDCaFxTWs1UdidFo7BemPvP/qDmpL4nM0PSsYGrQidwF6rlRsF2HFMcDHWThvGwZyiJ8pGphKWgmSZ7R04NkGBsnCyCC0zGYiRb08Lnd2O7Y/7x6UnJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8677.eurprd04.prod.outlook.com (2603:10a6:10:2dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Fri, 3 Nov 2023 13:05:05 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d924:b650:a2ad:7b25%3]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 13:05:05 +0000 Message-ID: Date: Fri, 3 Nov 2023 14:05:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/8] Support APX GPR32 with rex2 prefix Content-Language: en-US From: Jan Beulich To: "Cui, Lili" Cc: hongjiu.lu@intel.com, ccoutant@gmail.com, binutils@sourceware.org References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-2-lili.cui@intel.com> <53661c86-511b-b4b9-bf19-69b972da7a5a@suse.com> In-Reply-To: <53661c86-511b-b4b9-bf19-69b972da7a5a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8677:EE_ X-MS-Office365-Filtering-Correlation-Id: 3cd72855-d15a-4fa9-166b-08dbdc6d7fcf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X3i9U47Or+ej7+/HlA4Y9or3SpKq0r8O0N0dTteazQuTs/mixXIh9j7EFZE+sNw3q8jKHnijzMhG4tgAHbVRAG2alnxTDTvYwYy6b4Bs65m32bXBAzEst1xRojBhna8CQGvut4DE3iqSZcZM4D+VSluWL+AmEW1Iw3fIMH4TXCSMNN3uavIHKQTvniBSJPQeC47VRokEe48AnUAl/uWK4e3I419kbL1frTm40Z+aH2UI0vpzY4KG/S/CyXPQGrUFOn+uK4gwNZmkIGL1J6JaMU4jHnCxvC0eoBMWXhkTpHzjzzviaOjxatjFIwBV9a0+SlF0HtTCmQBvPv7AuqtnYWQxRd4QC1Ap7iP09u9Cx1YF6zw0fKEJzAzTjZGu1mDR4UGBeLHBzwKbFW2Wktu97SGkxLAQH2yCnegDUwEsB/uzYnUM5xnAtoU34MRYXXtu90rwqUxDiokZCYwXV6ZsCnTDHx0hNEqtXr983j0gDQQqhBRG1mSD7AgZIzvk6HyQiNhDka28j+1EGix3EjEsgoziNQ/1v93mPZHuePVi5DIVvAlGOmMJpOSgJLjosinrTGlLtWg8uKp2oknGdNmtTRXQbBblhhfELx7cp6LXakgSf//mnEGNGMe7n1YabVhph9UO0VErVwVyhIRSHd2Big== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(136003)(376002)(39860400002)(346002)(230922051799003)(1800799009)(186009)(451199024)(64100799003)(66556008)(66476007)(2906002)(4744005)(41300700001)(5660300002)(31686004)(4326008)(8936002)(2616005)(26005)(8676002)(316002)(478600001)(66946007)(6916009)(31696002)(6512007)(6486002)(86362001)(53546011)(36756003)(38100700002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkZMaGFSemdKWHloMWJoUmlnL3hxMGdRMlh5WkdxWDZYVU42dmEwVVBlQnND?= =?utf-8?B?UVFnQ2htaWxGRWUrK3JRaXFEanAyOGVKbnFRb0I2cXlRWHZRQ2tBM0lWSjN0?= =?utf-8?B?RnUxdEdMMVRwQWZBOGEvMU1uMnFUY1pkZlFlS29iRCtLL2J1UnBIYUZ2K3g3?= =?utf-8?B?YnJRdVBndGxPdDhqSXN1Ym1mSC9XblNWT29HOUpBdThCenArYkJ0SXB1Rkh2?= =?utf-8?B?WllpVk4zOEpmT3JlOVZQK1JGRmlYallLdkEzVHhaeWx2a0lOelJzajF4THlR?= =?utf-8?B?Q0g5NTljbGRIdkxocUgyTDREQnp6Tm9RZ0NLY0NFUVA1K0xwb2t5V1pNcURp?= =?utf-8?B?TEI5akp0U3E3OXZWd2pjM1NqS3BucEpzNVkwYnpOKzQwVkxleks5MFNNSEI2?= =?utf-8?B?NUNxYjVmRzZxd1RCMlpjMGFwWTlSMjRSTnBJbFE0UFd2enlRZzNIUXd3MEF3?= =?utf-8?B?VXhyZ1Q4NU5udFFPd2tBRFdzWHRtTHc5NWFsUTVLY0c5eGJlMFZjcERKaE41?= =?utf-8?B?S09XUWhoaytncFovdWlDQmdXVG83akhYQUpVMmMwZFc4SGhqdE1nd2tnczd3?= =?utf-8?B?QXpYdGM3SWZubHI1dW9hdmtGZnFOak9pVW1UYUZhdFVmYzBDUGFYNzVyd3dw?= =?utf-8?B?WS9YamlBaWV0dG1JTzFUaXhJRkpOZ2oxd1BrbVJpUWJvWE5qWXVoU2l1aVBX?= =?utf-8?B?cXFsbUkwbXB3Q25DNENGYnNwQ2h4NTlmenNudU11d0JMdkg3djZ2U1hFUk1t?= =?utf-8?B?dllPdTdCWVUzblFyWWhKbXR5Z2tVRG9sNWZ6OG9mSHN6QW9wTVVGRTh5Znox?= =?utf-8?B?emd2Qk9tcGh0OWZQZ08wL29nWVlzWE04M2VLZys1YlN0Q1N0elhSVFp5WWhk?= =?utf-8?B?NWVBWFFDOGZ5SDBEcFZnL2E4b1dUWldpZUNwSzd4RThjSmMwYWJPWDRzcW80?= =?utf-8?B?SFNrbHFBbmNESVpBTlRJMjdEWjNDUVZaSlN1ZkxoY3M5SlUyQkFXR3dqOXdw?= =?utf-8?B?cjZZVUZYQk11N01qMW9vWjNtSGtKeHdkSmxEYzd1QzhBVll2UUgrQjhabXA2?= =?utf-8?B?NkYvUGNsbGpGdVBCUTI3SWhoaWFTczRvUWp4RzVMMU94MlRjSngrekFFdWNv?= =?utf-8?B?ZXAxVDE2MHZ6enhLNWpLVnNkU0grQ0tXOEZnS2x4Z21QZ2dQNnBxaWttYmtC?= =?utf-8?B?YzE3dFdDL09KUUJ2VHB5dWZoV0FtRzdXdkIwTmkyUnk4bEhvY1doUXViTmls?= =?utf-8?B?N3BFd0xHWm9jYy9IS1UwaXovWmI5ajhaUWsxTXd5WVZZZUk4T3FyMGtDVHl4?= =?utf-8?B?VTVyeHdXbHZwZXVjemEwLzZ5bERqckkxay9yME9DdVpKRm1FbVJ0YXcyVzc0?= =?utf-8?B?dFRSQWVZc0JqU1k0aitycmswdWozR09aa0pnaVhNczJtaDVQNGVUZlNCYzhU?= =?utf-8?B?UFlnWVY1bWEwM05GOTFML3JCWTUzeDEySHE2RHF5L2cwVjNraXd6MW5lUVVx?= =?utf-8?B?bkZvR0dqSjJ1QnlrUzVSU1VBRFh4VGx4Q1Boc3l3YUZBVnNJQkNod1pVdGFr?= =?utf-8?B?U2xPMVBrUFRYcjluMFlPOFd4bXN4YVQ3TkJhVW1HTDdiM2FURjZpWVZUUkRN?= =?utf-8?B?SGlkWkVnNWpuWjQxUUdxeWFnaFpaaEFRdVFDVXoyUWVFaFkyMkR3Uk1WTkxZ?= =?utf-8?B?WWY2cU8wWUw2LzJWc1kzNEdSOWVtdDFXcE4yUnMwZHJkQ1hzKzl5bjZScVFv?= =?utf-8?B?NDQzQVpHTGpUOXNFS0k0ekVIQk5nak1reXpveXprUkVjN0wyVyt1S1ZNQUdJ?= =?utf-8?B?bGljMnhzOWFVYjhGWTM5VDRKOFBnZjdSeGNreFMrU2RXL2QyYzRmbjA4V2l3?= =?utf-8?B?cUZDUElNRmdSMVZyWnNJUjlqSm9UYlk5R2hDWFhNVUhCQm03bU9zUVpFQUNH?= =?utf-8?B?OFhFejNTMlV1Y0l6ZUx0K3pQUlNTU3FFdFlOUDNiRHB3Lzk2YU9aaU9aRmdr?= =?utf-8?B?RTVkam1JOE81NW1mL1VZdW1IQnJWK3pYTDdXcWJVN2FMYkowZ01pUlJkdXJO?= =?utf-8?B?c1l1QXVMMWM3VFZjajRYTUJ3OFVmNlBBTWVJTFR5ZHk4NUZXNGxhRUgzR0kx?= =?utf-8?Q?pJGlT8G1RqpXWgOKjP+x35eZe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd72855-d15a-4fa9-166b-08dbdc6d7fcf X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2023 13:05:05.8238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rrvhKEEPLjd1Mv9kQP2GnpEBP6o9v3v0FeBTsJzSvPuHRf4b/AsZ7xHyiONLPPYfF4OzhLnCtmghViZksDdFzA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8677 X-Spam-Status: No, score=-3028.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 02.11.2023 18:05, Jan Beulich wrote: > (for now only comments on i386-gen.c changes) > > On 02.11.2023 12:29, Cui, Lili wrote: >> @@ -1008,10 +1012,35 @@ get_element_size (char **opnd, int lineno) >> return elem_size; >> } >> >> +static bool >> +if_entry_needs_special_handle (const unsigned long long opcode, unsigned int space, >> + const char *cpu_flags) > > This function wants to be named after its purpose, e.g. rex2_disallowed() > with its current return value arrangement. "needs special handling" is a > term that might be okay now, but what if you gus come up with REX3 in a > few years time which then again needs (a different kind of) special > handling? Actually, depending on its significance for later changes, egpr_disallowed() might be a (longterm) better name. Jan