From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060.outbound.protection.outlook.com [40.107.104.60]) by sourceware.org (Postfix) with ESMTPS id 2163A3858D39 for ; Fri, 26 May 2023 07:00:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2163A3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnvnwN1OrTsmqsdTGx3EXeK97TyeaPLPDoi66CEnqMzrfweYylYOMKmjoNUMnZ22LB5OJTX3ol2UPiVR1Z9dpLZHhSS71lxozk6QJWh/O7dG3uCNSsBjCPihx5+qm+oqDQvaCmW52INJBEfSipTgIf6O0Iu9ipTdeRQ2qmaa7mnhh8pQH00TmJwqHTqLkX+6pwpWkL03KnVN6lLNta/Ym6nXjNRAu1LzRVT20ZMsqEogF+BlLC++MJOaGJzWVeLC32FZZbiAizcoB50ILJyIBL8D4jBZowwOBdqgN138F9JHtj6izqwnnL58liCFeDGLT74AEZkE589PDoEokcOlJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gnKmVkieY6waMAUL9UbpXx+CUjgsI3MSWCV/7Io6D20=; b=QgoOFKJDbP73/tMQjLFIGmZAFjPu0DIydCGCoEh8y6ejHLNJ1V4EX4FevGSduoYq7palP8Xf0ukAUpjYVn9Pks5f/lTnltocwUCQ/OQ9nMvcNErlOIGxa9cVU/Zj85taafkS9+/ehQC1LPrFqCEY4iLno5B8RTN9D/Ou0PBYoqtsfMpQEy49JeoDjVCCLmr6Wtqe+lpB3rQFLzMMjNsfsmGBfUKM5DxXBASgTPxH1699aVV/SP174YeRxd6E7YwicmTDMEJ8QK24+9V8gkovONIGOtrb8SNMscnfmRwF2o1sD08+t1VIXJSaqern7fyIRb4MOeaR4L6P2iKPp7fJMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gnKmVkieY6waMAUL9UbpXx+CUjgsI3MSWCV/7Io6D20=; b=n9h2PzXZIJP6ursFknzG5JLyj2qsqoAWdlE9YyC02N8REC0f7Qm3+RipOnpf0JwYqZuPQlkfB1IbpCzHEbO2e/wpdx6RWzGjEVT8ikUfyfMTjbiYQYzRkslxhhx2aBV6UtBUP5sYKwtrJzXuHAPq3R+oNXVUrE4vR/TmmoLFFW5z0KF9FhE6aTuN5w/H1uBzCrFQ2LCtrFFI3v80y4wpnxvx6jG3vQEJHUSUImtUx6GnPCKJIYDzRIF9Y7HDsKjTUnJXx6ufADW0p0ShTdk22OHQysnwV4QMX5mPb4o/Rq+8gwDe3rbvUvmL72PvtJrScSK/V4cmE3EmAR/B4DStfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8437.eurprd04.prod.outlook.com (2603:10a6:20b:3dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.18; Fri, 26 May 2023 07:00:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6433.016; Fri, 26 May 2023 07:00:11 +0000 Message-ID: Date: Fri, 26 May 2023 09:00:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] Support Intel FRED LKGS Content-Language: en-US To: "Jiang, Haochen" Cc: "hjl.tools@gmail.com" , "binutils@sourceware.org" , "Zhang, Jun" References: <20230522060726.101037-1-jun.zhang@intel.com> <6ed7cdcd-c7e5-587b-9d4b-95c1cc18f703@suse.com> <130cc200-e35b-57d8-91f5-3624194269c6@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8437:EE_ X-MS-Office365-Filtering-Correlation-Id: ea17240c-e0fc-4763-0ed3-08db5db6d962 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xT0f9RY6EikQ0wvjXX/lRutjUO4UlKsGb4F2ulnWBKhxmndqJY+cpY25n3KuF6h2C/a6u1ZI9rZwmANFAlfyC9PR5khjZzXo07VOw9rhjCqoM2CnoRwbMZaUYjzXlDSejEmkDhHlRIob0QDfoeE/8wqtcJQX+QCUV4JHlQAHYs3+SeXigSei4hjeLUhkskeDZBjUw9yzispGNpJKt/65UZCGUxMs+318DmXuwDMUUv3zSIG/urRxvlbLvUh1l9ZczS0izpin4bYPhm8zmUNBZ+K/lk1ECYs9+rK9Gcf8Wvd1MOqndNgn5VztY5Xcx1nZWNxmPt1BgxnIUzGpsJnMU/dra+EBqIG18KGx+3ox7zvQWPMKh1IjSKhCol7d2phgf2lMhv+Oae9KETVqwzJ6cWv6ehSjYbP8KhQyKY9RLKBIkN5Dtm+infoshLmFcb0O19gt2ZQ5agNPjZuBFrxlPFsrpr2xPyiBC6s43lJNjFGo9ciDghKuermsU7k2aQUAFCz7JJCiF3KlR/c+eydhifL5IEpII+sqqMaNbKW9fj6dSSXdzaoKJ8kgB3MrW0yB2mWHpiEsWMgpOS4Turt5mUFdxlppbMpZUsCOZDCR33xlnBKiHndCEPkAk1mAtP21crxoyHKwY1Rhy6DuV8VDqg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(39860400002)(136003)(396003)(366004)(376002)(451199021)(66476007)(66556008)(66946007)(478600001)(6916009)(4326008)(54906003)(31686004)(66899021)(316002)(6486002)(41300700001)(38100700002)(6512007)(6506007)(26005)(36756003)(8676002)(8936002)(53546011)(5660300002)(2906002)(31696002)(2616005)(186003)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmQ3QUlXMEJOQjlOKzNhaUhpUE4vZXkyZDRMLzNiaUNrMzZkWU5iWVkxbXZY?= =?utf-8?B?cjZlZTZnL2lUa2RYRURoRUlmS0lvNU84bWRORjhqTEFQMzNCSzRhZGdzOEk0?= =?utf-8?B?akZWTmE3SGZmRjZXeGdlQVgwWnI3dDRGWFkxQkdua2hiVHluaytqTkRGdlF2?= =?utf-8?B?cmU1K0w3ZVdOWnAxVmZHUGVnWjh1VmhFVDdrdVhMZEx3d3hCT25mVGdta2tR?= =?utf-8?B?eDZ3QzIrWExLSE9YaUFSRkovRFp0NmdsT3N4MzZYMFlEb0ZBSUsxOFpJOUpV?= =?utf-8?B?TjFIUTdNTHRNWHFoU015ZXlDYUthZndCamE4MXN5RXlrZ0phbXpTYXZ2K3Vr?= =?utf-8?B?UFhpN0k4L3pJd3hNRlY4MmUvcTRzeStTQXpHaVdEeDV3WXBySUZIbjRMbkha?= =?utf-8?B?Y3FmRno5cU8yMlZDc1hyZjdNUUVNcGcwTTF6TDcwNERGMDFBdW5WRytrOVYz?= =?utf-8?B?Q0hHd1NTWm96aDQyajFkM0YxUzFLYnQ4RWFaSFUzdnFYYlhMcnM1TnZwZnAw?= =?utf-8?B?SVJ3ckxOVTlZMHhidEdaMU1PUXQ2dWVuRVNHVC9KVThuZnpYZjZMRUFNa1Fn?= =?utf-8?B?THpGbDg2Sm5ZNWg3bEg1K1dOQlB4STFieXhZdXN4ait1UUsxdUcrMUkyMUZ0?= =?utf-8?B?TG1oMDA3Nk5tZy9FY2lUWUFBZW5YdjVWcTV6ODN6UzJaZHgwYU5OU3RVZFh5?= =?utf-8?B?LzU0SHh5QllKWGRPUk1tT3RtYlVoS2loQmx0MC9MRHJFeW51SmVERVVvc2tQ?= =?utf-8?B?dWVpTDArdWl3Nzd5WStIOUI5a1NCeDZZeWxxZnlCQXBUcTU5c2ZMVllSZ1py?= =?utf-8?B?NG9CNktRZ3FWTlhLWVpwZkVOTHJqLzFLM3QxMHBrSlFZcWdEQk1ibTlMM2hM?= =?utf-8?B?ay93WHVKRG5zOUhPcjlWd0hidjJDcDlZYnV0SE5jV3FPRnhVNUJWSDFuL2xa?= =?utf-8?B?TUZRSzZIR3pZVDRPMnlXZmZLQW1NMGNqZ1BxTmdOT1JUNjZJanBRTTA0R2pr?= =?utf-8?B?RURocUZmZDVkVjI2RlA0NGowamRRVnBRSUo1UVV0bjJCT2thVUYweXJlVnFt?= =?utf-8?B?a1pxOG8yOXJzRUgrOTRRd3JiVzJQQzBlNS9NZG9pajkzTWpTSDhjQUNKQmlU?= =?utf-8?B?RSt1TXcwS3IvOWRWYytST00vZHM1TzZBV21rdGc1S0JKdk5oWUVMM0o2bHE0?= =?utf-8?B?d1ExUDcweVZGanFRaEZpVVNZeDNVNHV3Zk94VW4zQzBqQTJyTnZTU3d4My9v?= =?utf-8?B?ZWxNMllEUlB4N2tNY2haajM1Zm54ZXN5UEdiZkMxTE96Yk41aURPeDBRYkdq?= =?utf-8?B?c242aVhhUHZhQjVxMmhCUlM2d1RJL25Va3hQY1gyZFFreGs4SURRWVU2Vk84?= =?utf-8?B?blRma2dQMURnd2xUVDAyM1RQMFVTc0JRWm5nbE5GdWxUTElHWnFxYXJta0Mv?= =?utf-8?B?Nlk2V29aVDlHMjNRVHpzMFB0RlBoUTdqdGdYYVVROGZ4TXNiSFZsblJONDls?= =?utf-8?B?UndyU3V4ZEdBRFhnZC91L1gxWXBSdy9HLzdDaGtTTUgyZ1p4QUpWaU5vakZL?= =?utf-8?B?R0dmbVA1dk5RemFFVzVoM1gzMXhrckVMMDlkN0NNMzlJRnBseWYvMEdCblJv?= =?utf-8?B?bDh1dnJ0NU92L3JISUxCb0o4ME51UlhZMytzckVVckVZNVYzeXhxSHhoRDVw?= =?utf-8?B?bDIwUjFNd2dTalRWMmhwT0h5WUJkL05pV21Gd1d0azk0S3hFZVljdERTc2NR?= =?utf-8?B?THNOVllDZFhDeG5jdldTSTFkK2NaRzdWaW1WUFRicWRzMnYyMnkwbGFmei9m?= =?utf-8?B?ai83cThwQU93ZDNUT3JiRkU1WE5qbmJzMjJnQ1YvNFVEaDBLajVCcXlFbWNl?= =?utf-8?B?ZkNVcXNCQ3Fqb0wwamNQWnkvNVlYN0dHSXlVQnNiOFMwTEdMTGxRaFVQRmpS?= =?utf-8?B?T0hMdy9GMnloWTRQbVRtaHc0YzZpSEpxMVNSU1o4V1laTlpiUDVsMVhTcFZS?= =?utf-8?B?NkhybEF3WTk2UVhFNWVtMENmMmVxbzR1aWlIdjNnSjBSU2hLTTJmTHFnbU1Z?= =?utf-8?B?eFVTMHJmVHlCbU1EWE5xYy84Umg0cUdwRWg2Y0xIdStKMFRzelh6ZENkMVAr?= =?utf-8?Q?4VA21UqywinjShWN0MtzaqrKY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea17240c-e0fc-4763-0ed3-08db5db6d962 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 07:00:11.6889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n6sBgu801u3Ws+uMh1NTG8/+zj4Cqo/FpMUtgSlXmXsDN91RhDc9FBSPwPwvd9Mr4y/Of+J7KrZmBTLSf27zyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8437 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.05.2023 08:50, Jiang, Haochen wrote: > >>> I just take a look at the whole thing. >>> >>> From my perspective, if we are going to use the same pattern like SLDT >>> and STR. Does that mean for the instruction below: >>> >>> lldt %ax >>> >>> We will need to add a 66 prefix for gas to make it happen or it will drop >> to %eax? >>> >>> It will change the current assembler behavior. Is my understanding correct? >> >> No. The assembler was changed already. The disassembler simply wants to >> follow suit. IOW the assembler already avoids emitting any unnecessary >> prefixes. The disassembler, otoh, should correctly represent redundant >> prefixes (and preferably not as raw ones, e.g. not "data16" but a 16-bit sized >> register or an insn suffix for AT&T memory operands). > > So for all the registers, is the ideal case that we should not emit suffixes since the > register will always be 16 bit? The _part of the register that's used_ is always 16 bits. That doesn't mean that's what we need to print. See e.g. pextrw/pinsrw. Imo GPRs here (like elsewhere) should be printed according to the present prefixes: 16-bit when a data size prefix is present, 32-bit when no size prefix is present, and 64-bit when REX.W is present. (Obviously adjusted when dealing with 16-bit code.) This then eliminates the need for any insn suffix; that'll be needed only for suffix-always mode, and specifically not for memory operands (which are always 16-bit) outside of suffix-always mode. If this isn't what Sv + D do, then it probably needs adjusting. Jan > If we are using D, I suppose we will emit suffixes under the current scenario. > > Haochen > >> >> Jan