From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by sourceware.org (Postfix) with ESMTPS id C3CCF3852215 for ; Fri, 16 Dec 2022 07:03:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C3CCF3852215 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iURFKmLJ/ml3KCQrSyiyuaff/QEq5puWR2dMyj2KMV6eRmOX5/Hr89htqwPFram5aJb8BlwSOItBWTGya9FM9mR7D0tmBKcG5qNDXzn9bPYPTzpdPzwE+SPojevSG7+491of7gnRET6+E10wLfX9o3mft6Jwkq8rIss9UXLbUZNJBhLGU4PH6sJIsD43O0DUFWzqbb6xFb4YgA/j751QFZc5jL+Tu8DCK4bCl6CL4AfndzmsraRfQ9+VzJ7GhhI5lbZOp3rmoNk9URSI8Tv5kfb9uf2wVQkb1bwVvtuQOAP0RZK/zrRNC7IWH17hSdnuT6oZU1wBWOY7U+KzbHgoqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+sgVt637dwHTkkT3cwYNd/xBvcOjT2vQ3dHpzus+TU=; b=n3ucUh8BMFv/DpuDDDzv5g0/bdd/C2Nc1N+Rn9uBWvUzg91RT8vwdWo3UqJuHNvxDuIypUDDlbZisjQzBORUxL/6XNczLA7PvwW/5+Rzv7Jta3k1sOWBkL4iqtGRjteuO89MODbj2g52oImx960dxyMg4V2HsXogBt1Z7ZmcqlZrXq7mkyLM9/s7gyhbHz3PBUHG0hxudzyoYEDW7lYuT4krrJ8Qk9YIoJ4xT+z3Nl+SXW7SLkZjSA9pkiMDYX0Dmx6G3iokkbABNbzYCrX+S6cD00Uywhz0nmrDvVZwz+LqSlH/9wJiozQa1Av+NjkAoyA4zqHrm17N9xWOyJMCLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+sgVt637dwHTkkT3cwYNd/xBvcOjT2vQ3dHpzus+TU=; b=VftL20L0hX1vpgNzkZgNLctQOunplLK7kUfTDYqwHwXCXEc1OirlpUfeSRDxJt17cwgTlFPWuw3jHJ0RfvGH/lWNrSmEzpn9RWAi0rZQ6kzhMGnJCuswLbbvVC+yeSu0xyKk+uFYp+1kaW3tVEsGF8jUbkpU448AyjLxmG50Uh45PTk7C16odSS2YWGy47B2gZjiTK/I3S0BCUhiq5Nz91LJCnn+3QhPFBIYWg9q+20DLXlEOJMxEhr67JPEGsXjDno9RQV/HidYzbASR6CcOz7HZQo+can+d5ocQjUUyZbh88YOPXEnAWV5GtU7YtyDr1b6yXm7oMmpIMqJgyQuEg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9389.eurprd04.prod.outlook.com (2603:10a6:102:2a8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Fri, 16 Dec 2022 07:03:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5924.011; Fri, 16 Dec 2022 07:03:53 +0000 Message-ID: Date: Fri, 16 Dec 2022 08:03:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/5] Fix size of external_reloc for pe-aarch64 Content-Language: en-US To: Mark Harmstone References: <20221216021400.22309-1-mark@harmstone.com> Cc: binutils@sourceware.org, wej22007@outlook.com, zac.walker@linaro.org, Tamar Christina From: Jan Beulich In-Reply-To: <20221216021400.22309-1-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB9389:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c447a84-0768-4062-ae72-08dadf33b127 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Hsdq6X3dKPgahqC5S/5n20hbDQYKsvi6xYA4WOCpvYfXg+5sF+y6RoxMXATT8hpUt44Il8Jntw95ALWinJkyVIxfCFbFv7y1raHXg4M5C5jRRrzjL/6i/HhVPxMms2XKLGIOOOsBA1uUf53RdXN7uEVrNv9IK+yVQNPhlhFXZv6jRHfMK6ldlGc8OqB+wcKBiffUFl2r6ieF2JtFaSPyJPAA/ZDkMvQuVGTJyuo34nIyA+nZK4FBN1OfeewUWZJwjohTlBEoEl5c+CXQT5+1Qs80mOm+EuLhIqml6cGsBBrFFdyZfYwS+8D7/7t2fALhz6bWRIhl4IdUh7vasREdqXiiCrtanktrept1z/XFInje3Vlwwb9R5eG2U7XrpzPRayqdE/rB+gtWyKAAsCuY+hLdUPY9WuXZACcRJ8hJAMhKoYHeOfjErR0D94rkcV1UvY7Mg2P3wEh4TQhGCYu52GRiyZuIk8SFT6S7M73IJuZmI4RMJzQibowOM+b3ISwX3tuMNpy94swFa42GD9v8pa2vT7tQGCen63lfTHAek4nKCO17CZTs+HNbf3WYCGtKaGjibUZ5UqgTO0CTKbVfKacjQWJZSNfg9bfD9m79PSImX9H2B7aTZIQpR76tfeF6N6K8xnIGadfnGBjMwSO/ZfhodyJb2wWMD7xDWAOBjUC3VWHwQ/6NGPUgItwc26e2MGegvQDa7h+rMnxDWy3Dp52FD81cVPJVgYZSm4jC8Vr5KDdf3o/qlYCVtA8DGJOl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(53546011)(31696002)(66476007)(36756003)(8676002)(66556008)(4326008)(41300700001)(6916009)(8936002)(316002)(83380400001)(66946007)(186003)(38100700002)(6506007)(6512007)(6486002)(2616005)(26005)(478600001)(86362001)(5660300002)(966005)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW9zbHNuS2hYcUpwSEh0aTVwZEE1SVZ4UVJHMC9nSkdmV2pWVzl5NWZ1UVRG?= =?utf-8?B?alJocWErK2JiZnJxTDRBa0pEaUszWjdaVHVLS1VWUW1mWXFyZVpkV2hpcFp0?= =?utf-8?B?ZThRRUY0TC9hdnM3Q1kzdzcwR0w4R0tQY0V1S0tMZVh4OTBKSDAwbXdJTEJx?= =?utf-8?B?cFRwa3kzWE56QmdJWC8xUFhhdUpPZnhrSHlZd1dkRFFia002ZUZBR1A1ZU9R?= =?utf-8?B?enZTUFFIbEl3RHR6T2NQQlFxdkNGZDJSTUFYNDNVU0hiU25zU0FsSlB0V0do?= =?utf-8?B?aEd6Y3ErWHJybTZaczBzcjlFMDB1MVNDZThtbzdQbTBpc0Z1ay9UcllGOEQ1?= =?utf-8?B?S1dtMzhhN240cEVJRHB1NWJMRFFadDQ1K2JTZms5V0NXN2JTZ0FCZHBiY1VD?= =?utf-8?B?ckszb2VnRUxZRWxtS2ErS3JzUUEyckNvaUxkazlrazV0RHYzazY4aE1BU29R?= =?utf-8?B?RHpCTUdPVTNoVnlaWXVZQkMzV2pFQk5vdDhJZ2hxWnpLMkRzcUN3VnBrZ2hL?= =?utf-8?B?L3V1NENmY2pnYVVITGRUMUxSL3p2T0hmTkZvMnMxeWl6alI5bkN6N3J3bWhI?= =?utf-8?B?anNxYVlXN0NHK3E3WTQ4RWIrQlg1eEZuRU1jK2xsbU5zVUtXZTBEOWRqYlBK?= =?utf-8?B?STRFaU9KMEJlZXJpVmtPb0liWkVaTHRvMmVXZUVsSGV4R0VEb29tam5lZEo1?= =?utf-8?B?aThOTnowQzZhUytsWUk0eCtYcjA2emlZaUllVlB1V1BIRnV2TGNMTFJWZmtK?= =?utf-8?B?Q0JUTFY1ekVFaFFBRXZlMm9WR29GUVhKSFVFTEtuZnFqVGtFSyttUG5PcVBM?= =?utf-8?B?Q1NJWXpOQW9mM2FiV2U5V2ZhSmpJMTN6S3N1akVBRkRDd2F3RTM5cVF6Rm5S?= =?utf-8?B?aXphamdwazVsMEtXY0M0YXpiUGdiMFJvaEVmNDVMVXlyMjY4b3ZNcDl1Z3VH?= =?utf-8?B?SXBJeGpNUXhrcWIwbk1nTzN6ZjgyaG4rNFArL1o1OUl1aDNXTmllWFZjczRW?= =?utf-8?B?aSs5U2tFMUNZWFd5c25lSHdjQ2Ntc25zVDMyK3NXNCtkVi94M0RXc1Ftam5M?= =?utf-8?B?L0dRSm12MTZJTnhKQWtIMkZEUnFQQmVvK3B3eVVaNUNXVVRtWE9qNFMydFRR?= =?utf-8?B?SDVlNGdPazc3Njd3d0NMVFdSS05PaTVEZ2FGUHRIRUE5MHZUa25rdUE0dVZP?= =?utf-8?B?cHRpOUVPa2VlczYxS1R1ZDZiTDl2YmNxelVJR0JLS2ovWDRROUlpSkNQZkxS?= =?utf-8?B?Q1ZPSE1yMmJpc2tyVk05WEtOSEpTNlhNVDhYbXNJd09FcGVZZEIrMFdlc0pv?= =?utf-8?B?SW94dkxpTjFsSGJUbmw4SmpvZFhTeUROd25KK1hTZ1o0dFY2Rm5YOE1kUGs0?= =?utf-8?B?TGIzRFJ0Wjc2cVMvblE1eVhXOGI1ZW9Dck8vVWd3dmhmYmVNVVZwVmFCK2FX?= =?utf-8?B?Q1NYYTVpZFFxcW5LOU5CcURyOStXL0lDdVNIM1NZUzRuKy9JUEhRbFNoN1RQ?= =?utf-8?B?VW9TdS9KM2MzZjJLaHJhVVpMT1JPMzZQeThJdTNkM3FiL3ZZOTJSdVRoeTNJ?= =?utf-8?B?YkZ1TEhoQ3FiV29RbGxtOGo1UW1Ea1RRelN5R0plNVBYZDJJMU1YdFZjT1NP?= =?utf-8?B?b1hLdjduWUMrdTE0VVZZdWFQUmorMlNIZXBzRC9sd3dTdzRhM3Y2VjB2M09X?= =?utf-8?B?a0JNL25JY0ZIR2k3ZkNtOGxtMUV4elp4RDlUSWZTbzRIR0JmVU5mbGZYUzZV?= =?utf-8?B?YU94K0tvbkpaUFRvSVRTMUJsZXNIVVYyL1g4VjhZZ1BwcmZNRW9NUWJhajht?= =?utf-8?B?dEtrMUJBYjNFalB1U1RGaURJcWpNZHE1T09YV0JHZ01BeG5JSnZ3eGNwUUNS?= =?utf-8?B?dmdPQUVOK01rVmxhOTNTNWhJdEMzSWFHWHlYYmJiQlovWXdvZUxHWTE4WFpn?= =?utf-8?B?Y2RsY2plNWM0cWRiS2Y5ZFY3aU9OUGNnVTFBd3k3bnV4dXplYkwyVmEvSHV2?= =?utf-8?B?ZUF5Nk02L0V4Tkp4VnpmcE1aajIxTFp5QlI4cmpGc21tZHFVZnVkSmZ0RUE1?= =?utf-8?B?RkNWaVBPVXZRZ0FwZldEWjdadUZaYUZXMDExMTVWK294SVZVa0hTL0tWRU9m?= =?utf-8?Q?+19UyErj9xFLy/mbIGrnnE6qC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c447a84-0768-4062-ae72-08dadf33b127 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2022 07:03:53.6090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AKjpKcIdPNZKJEw2mxuleSTfbRB9bkKZkEEHvjypdqqCaJneb8CBwMtG5xGPjguu59zmBIaGciAXDTS9C4R7eQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9389 X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16.12.2022 03:13, Mark Harmstone wrote: > This patch series finishes off the work by Jedidiah Thompson, and adds > support for creating aarch64 PE images. > > This should be essentially complete: I've used this to create a "hello > world" Windows program in asm, and (with GCC patches) a UEFI program in > C. I think the only things missing are the .secidx relocation, which is > needed for PDBs, and the SEH pseudos used for C++ exceptions. > > This first patch fixes the size of RELSZ; I'm not sure why it was 14 in > the first place. This is the size of the "Base Relocation Block" in > https://learn.microsoft.com/en-us/windows/win32/debug/pe-format, and > AFAIK should be 10 for everything. Not sure - there look to be different formats in use, judging from other headers in include/coff/. See e.g. arm.h which even has two forms. Clearly in the original commit (b69c9d41e894), targeting only objcopy (and maybe objdump) for PE binaries, this didn't really matter. Does it actually matter for you, when you're also only targeting PE? Or are you (in spite of the title) really after COFF objects as well? Let me Cc Tamar, the author of the original patch, to possibly shed some more light on what the struct was initially derived from. Jan