From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2061.outbound.protection.outlook.com [40.107.247.61]) by sourceware.org (Postfix) with ESMTPS id 8D96E3856DF8 for ; Wed, 18 Oct 2023 08:05:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D96E3856DF8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D96E3856DF8 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.247.61 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697616351; cv=pass; b=xudBcjdfrW/MrsVNfHCs/JJvnEwcKvYNdn3Zq5JFgd1LKZqCL8E8b4bfoHeqBxo8rsyqSpww66iTOY4SBt2V0QG554idgGiPy1AdZ4jVQ9VKdJWvbuG3zAuffpeCABGipqp79Cao2k9blkFD5O1tB2l080MV4YmXO/mmJ4Fapg4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1697616351; c=relaxed/simple; bh=aYyDJJjsLSJLjGRcBXtcatWWCUJ9nIuH6BIUM4Jv/Rc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=sQOmPLwqA6As7BTrdzjvAwW4btgXa80yTAfjQd9Eneo2U5LmwnCGdYEYrRBty2OAWRFiB4ZaqAiZjgoXWbf/Hl9ABaPoh8b289Hpwby1VzuWGEqN4XODZasixPBO7V3eDi2YVbRug+np1wYcs7Cz24IIX+jEzSnutu52IHJcKCA= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jXCzqZ8uLx+H1Bksd3u//cH9TYJnA07xvdBiAAMP6MSDz6+4AuAfoOB+6ZHraxksAkZyE+/SuF3C8mF28J/Hqs4B8obyf6RH0nTeHSOwLgO+mfQyvrmPNi4kVhdgskJmR77tBQb5RcrG/dxujcuJmYJSK9nXj+YJDYpTBIb5UCD5dc2KKPJwDQQgzLaYkEJUU4WeFzuShsK0BBcBfEgFkVNwsfNAeImv+96MzJzCXjqzyOken7Bc9W1FY8ARKtxCp/PGrJQWxX5dPbVqeKdK9XiXTdUBGu6S0JxNOoCXvpVnBQuUGZt35qx9oFQUfbKYBigerRjee1HFhujIHwm8cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zirvru0yfaZIicWjei+j8YZHztXpSx0+BD9ZC9msQG4=; b=RotHOlDhPGtv5Lgy8QXF6GJ0U3MFMigEgykHLL8No+OU33j8d8DTBXqQ8vQg2+pkA+d8CP7Y5fjXTze3P6yKNdp9NYo293p6bH8oB9Ks52S8bcehiSBSZXPMjc/2YeEzQvKQuiRsmvDwgtHC5ZSur20hY+Jz6BWT0fhVViA9HjTzOLHaECZ6UcXP/4zAyqBwjIY6diDnecTulXiNa3SIPBABMdHUtHjuqeiTwc+70FqqgrN/3sr1dpMt0tkl9btsRjY2hLKtVNsJ6z7mA2y2Fx/sClsEJMx4Ahdj8J+t+7M4STCEaDUoQsMujIR7d1lrZra/vcA5va7wxqux7zhe2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zirvru0yfaZIicWjei+j8YZHztXpSx0+BD9ZC9msQG4=; b=4viO2ibD6GcRJgE2p9IYX+NziYXy7EYbLBh3EctdNG6Vl72A3ilpq93clltlLf0BAqRd2G9XiQJeiXCJRXDDKoy5Nk7aAFrjWH7oUwFCnLbnY9bmsG8DYPCwUj0goF5Nb6FHP6/DP70CqjphpVuv6UE5nJE6btutyW+Cc1WFISHhXnjpovLxujqDDE2UChn9OpimQ4WTjmu9MSFubBEODjNU7alYD8TvAVrlVrlZWvERBX22tigwx5HxI4BxBpxUtpcShJUDPDS6u/tQauP5eI/nBNscAlwKv4bTQkwacc0YotHN0OMFzX2aholxoWKn9KfpNuRKnHb/lnH/3NQXiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by DU2PR04MB8775.eurprd04.prod.outlook.com (2603:10a6:10:2e2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Wed, 18 Oct 2023 08:05:46 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::d9c0:d907:4d2d:15b3%7]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 08:05:46 +0000 Message-ID: Date: Wed, 18 Oct 2023 10:05:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: FW: [PATCH 3/8] Add tests for APX GPR32 with extend evex prefix Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "binutils@sourceware.org" References: <20230919152527.497773-1-lili.cui@intel.com> <20230919152527.497773-4-lili.cui@intel.com> <152263a9-5e04-ccec-a5f9-b3cef851a85a@suse.com> <772023ba-7bd2-331c-57b0-0aa45b0cc60e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR5P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f2::14) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|DU2PR04MB8775:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c217fbe-4f07-411e-68b3-08dbcfb108d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sx5Vxl3KAJeC0xISCzpHRln1FgH2TZXpwP8cofIsvQewByqEsoR4Nt3vB0xQDQ8mPVYMHqp3eSGXgB4M5j0PmNcdjpmjrRGTAT6l0zRNoSJMGs6U2QoKjRnEOMyvGR4uD4/tytqAQ4DATWxEt8UR38jV89hrBGseLc4YBvSakgLUKZnA9OJMbYGhtK2r6mWx/ikTcaw0E+YqLw/JEHdmiY/p6wNgnmygsNxDgnhbC4zbXLTyynA1l4BpdoYmO3y14n2kq/bfssXAfUifgWyq/PSqK03418FPPsI7DRxpSEmCUrfWFxYYaWiqaq1ZQUsEK2qkswK8Mi+CdjlhF/AhaHpN2FZdnPMZ/5BFdMUtT3fAjez7ivh0O2OcreNpPP6DBj76OYpMRuk1FB9N5LJndXE30sAPbHXwLpNGZGtfBpiCmcv4uxtqv8+kCEINBPPg83UYjanaGpDU8xvRTw2pI/uS96WVICWMPXtcr8WpGjZKrstYBNKpBFQa7TQTeqoeYgxPWu6ARDTTCdf9AFq+0dGJke4eYaVP2hK0V1MyjQAEJbXOIkEJhDm0IOtsCrR/+ohbfYBXY20s4MyLwDDqKoboHiER4+FhPa5FjJmWH26eiiflhLKuhHUoT2QKoHZxgj+/3s1f748pUDWiwDeKlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(346002)(366004)(376002)(39860400002)(396003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(66476007)(6486002)(478600001)(38100700002)(66946007)(54906003)(2906002)(6916009)(6506007)(6512007)(316002)(66556008)(8936002)(4326008)(5660300002)(8676002)(41300700001)(2616005)(53546011)(83380400001)(26005)(36756003)(31686004)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnJCYk1peUlnNmxmRVhPSENueGNqMVpLKzFmMjFLWjlyaWNZbHRQWWZMNWFw?= =?utf-8?B?MGZvdGptRWlOVDBnUGRMV3JudHNHKzltalQzSGJyaW1iUlBFRTNVbkphR1Vn?= =?utf-8?B?M05UQUEyZUlnLzdHWUlEbzNhdHloUFYrWmJxaWltd2dCVWNhYUE5aXl2UGYv?= =?utf-8?B?NWxuSHVjWStIR1VjcExaUVRzMWRZakdyaWVXVmNVSFZ1dXBjU2dqd05nUW8w?= =?utf-8?B?YittblBPMDJ5UTlpeUdUa3BxVFp0RUFDNm5uSlJJYUZZaDFPeGMyYS9XSnhI?= =?utf-8?B?ZEc1VWVUMXhoN2RiWmVxNWtzbU9yQWxiYUF0UzVGSk92UXM0cVRqQnRMTnND?= =?utf-8?B?NFo2YWJqemdmallTb254Ykl3RGJPbHdUR0pBUTdqM3hDVDM0ajRMNkxhM0dG?= =?utf-8?B?M3piOWhkZUVReklBem1jZkF2amRiSnZiSGUzVUxqMzZuNDhaUVYzK2M3NFlx?= =?utf-8?B?UU9XMGhrdllOaHRvK3I3SW1NZzNWeWh3SXdrS0FkOTFIeiszRTVOaVBhek01?= =?utf-8?B?cDF1MHRXUE1NTkN2WGhVRk9WUlJOZG1WUFlMSlhZWG93ZTBNc25DRVJiYWtm?= =?utf-8?B?S0RaajVCdzVjbEZUY3VkNUFHTVpNU0kwaENiK3Z4eFo5ZmRYT2hCNkFLZ3Jp?= =?utf-8?B?QmZkRURxNXZTeDRYSjRPMWNCM1ZFTHM0MysrM3dieTZOcHVhZVNtZ3Z5aHRu?= =?utf-8?B?ajlpbkNpMlRZdUdkQ2JLaUtiTGR6bzJSSnBWenVFd1RyTGlVbWFkby92cHFr?= =?utf-8?B?K2MxY25KaHZyaHFDanU3d2F3Y28rT0V4cGoxRzRQNCtwT25rbGJiUlZtUFBr?= =?utf-8?B?eWdTaEhKVERxNHhFelpKSWdVSTY3TExXTjlXbG9WeCtFVEVoZEo2cUcxNEhj?= =?utf-8?B?ek9TU3FCei80RlN6WE9XaDAxYVprQjdVMWkrc2VmQlRrTlUzNXFROWtLNTFh?= =?utf-8?B?cGlOaG5uYU12eW0zM2ZwVEpGb0wyRVpJUDZaaG5IMHdEdzFhRGs1YmdXcG54?= =?utf-8?B?aTJpdTBMSEdDNWh0djZLbUZmQ0hBbEgzV2dwc2RLVkh5aGtUbVZLR25aVzI4?= =?utf-8?B?T1lGelVtYjlVdDAxbWJnVnMrTWlNOTZiZURsOEtPOFdWS08xa2hJVnRzSTRM?= =?utf-8?B?d3JTOUdCVVk2M05TRUlHLy8xV08ybGZwWlFQZU9YUjNkMGczaHFIb1dtZncv?= =?utf-8?B?ZFdiS09PTTBuL2VZUXZYM2FLRlBEb041QUR0aVh6TFVLUGNENlhkeUhab0lH?= =?utf-8?B?NzF1NC9DL2Z5L1lXRmFDZnZwWFRjMEF6TlJTalRsVytxSFhwU2NKK2liM2pi?= =?utf-8?B?WVBsSE9GQmxGRFViOCtlaUxlYlpoc0RObUFWbVhFWkh6UHJsM0drTTZzUUVa?= =?utf-8?B?RklQUEN0Y2lCQTI2LzJDZUpaeEF3RXpoZEJJSllnQWxQVFFZdW1OSUpXaENm?= =?utf-8?B?cUJZbnIzbTNLWWk2bXhVNklLZDRhaFpCdUF4NzBXUis1aVNyeE1oYnF1U1lF?= =?utf-8?B?d0pJMmNZWThhUFlPMThqajBsNDlndU5jaWhqVmtMT3NKSE4yek1pbXdKaUZW?= =?utf-8?B?U3RPOGJMb29pangzWTV3L1BnZ1BZcjlORUZsdlVaNzhJMDBUR3hUWU9lcXdn?= =?utf-8?B?VEg5YXRNNTZtVW5JaDl0UzFlSllGSmJpTXo0MExFOHBjYm1aQkJ0dEU4cnQ2?= =?utf-8?B?Z2hBcjlPcE1iVStoRUtzSEZESlhocmt2dFEvRzZ5c25reHpWQUU2TmRBcGE3?= =?utf-8?B?Tm1NZ2JGYVRNNUJ4ZTV1T1hsMHlIQzdtaEQ4aVk5ZVd3ZmJhdGRSSFlqQWxD?= =?utf-8?B?QW9OcVgrdTBPZWN4enQraDZGaGJMRXR1Wkp1WThPaGU0MUswV3YrREtmSjZK?= =?utf-8?B?Mkk3VmZKeXVET1p5ZWRQSzZ6dnp0QU5nUlFtemRiTEdwMmpZQnJ0ZlRMZmFX?= =?utf-8?B?eWovZWwvdGVsS3RzUko4ZXFyRXV4aytHQk91U3ZXOXhLdlhDenlMSjQ2THg0?= =?utf-8?B?UFJ1WitNdFFhTnF4Rm80aG15WXBSejBmSFJtVVRzQlAwcjRLbkJ1dEZDSFNE?= =?utf-8?B?K08wR0hlaW1NalYwbEh5ZTJMdFg0L3NNV1pjQ2lwYm0zN3c3WmRFblpVU2po?= =?utf-8?Q?N0KOklH9YL/6ZFhxi7lYjl3r2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c217fbe-4f07-411e-68b3-08dbcfb108d4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 08:05:46.8587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: urIIjB5wM3eZbKVZR0dI6NhgRfVURVB0UyDnaLZ/Q+cNgiQRyogj7a2YXHgpKlyqCR2633V/4kiCghKKEdUJOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8775 X-Spam-Status: No, score=-3028.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18.10.2023 09:16, Cui, Lili wrote: >> On 18.10.2023 04:32, Cui, Lili wrote: >>>>>>> --- a/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>>>> +++ b/gas/testsuite/gas/i386/x86-64-inval-movbe.s >>>>>>> @@ -1,5 +1,6 @@ >>>>>>> # Check illegal movbe in 64bit mode. >>>>>>> .text >>>>>>> + .arch .noapx_f >>>>>>> foo: >>>>>>> movbe (%rcx),%bl >>>>>>> movbe %ecx,%ebx >>>>>> >>>>>> I don't understand the need for this addition (and hence for the >>>>>> need to change the test's expecations). Like was mentioned on the >>>>>> original >>>>>> AVX10 series, tests like this shall not need modification, or else >>>>>> it indicates people's code also may need ".arch .noapx_f" >>>>>> additions, which I'm sure you agree may not be required. Finally, >>>>>> if testcase expecations like the above would be needed anywhere, >>>>>> please generalize them such that a similar mere addition of a line >>>>>> doesn't require the entire test to be touched. Here this means that >>>>>> while for the diagnostics you of course want exact line number >>>>>> matches, for the actual listing line numbers don't don't need matching >> individually. >>>>>> >>>>> >>>>> Agree with you, but movbe is special, movbe didn't support reg to >>>>> reg >>>> before, but APX enable it. so I added .arch .noapx_f for this invalid test. >>>> >>>> To be honest I didn't really notice this difference so far. That's >>>> somewhat ugly, because people mistakenly using a reg->reg form would >>>> suddenly get an EVEX encoding rather than an error. This will need >>>> some further thought; please mention the "anomaly" explicitly in the >> description of the respective patch. >>>> >>> SPEC: >>> Note: The promoted versions of MOVBE will be extended to include the >>> “MOVBE reg1, reg2” form (namely, the ModRM.Mod = 3 case) for both >>> opcodes 0xF0 and 0xF1. This extension makes the promotion of BSWAP for >> NDD support unnecessary. >>> >>> I'll add a description of movbe to the patch 2/8 changelog. >> >> Thanks. I did deduce the connection to BSWAP on the way home yesterday. >> Which made me come up with a (spec) question: Wouldn't it make sense to >> name these >> reg->reg forms BSWAP, not MOVBE? It doesn't really matter that they use >> reg->the >> same encoding as the MOVBE (then mem-only) forms. That would then >> eliminate the concern I raised. >> > > If we extend BSWAP, it needs to add the operation of reading ModRM.Mod. I think this is the benefit of this solution now. I'm afraid I don't follow: I don't propose extending the original BSWAP. I merely propose to use the BSWAP mnemonic with the reg->reg form of what's presently called MOVBE. (As an aside, in principle no ModR/M byte would be needed to extend the original BSWAP: One operand is encoded in the base opcode, and the other could be encoded in VVVV. But that would of course needlessly consume an entire row in the opcode table. Hence why I fully understand that the opcode wants sharing with MOVBE.) >> As to 2/8: I received two v2 thereof, with different titles, and a v2 of 3/8. >> But nothing else. The list archives match this. I may take a brief look, but really >> I'll await a full v2 submission for a proper new review round. >> > After we split a new patch for the EVEX_MAP4_ table, we need to insert a patch into the previous patch. I am afraid that if I change the patch number, the subsequent review will be easily confused, so I have not changed the patch number for the time being. But for V3 I'll create a new patch number for it. Patch numbering should always match the entire series, plus it should be the common case that complete series are sent out, not just new versions of individual patches. In the unusual event of nevertheless doing so, patch numbering can still be made unambiguous by e.g. (considering this case) using 1.9/8, making clear the new patch comes ahead of the revised original one. (Whether a new version of a series is shrunk or extended is entirely independent of that. E.g. in the case here I could easily see a new version combining the two series which were sent initially, for whatever reason.) Jan