From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id B77B93858D32 for ; Thu, 3 Nov 2022 02:45:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B77B93858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42d.google.com with SMTP id k8so792561wrh.1 for ; Wed, 02 Nov 2022 19:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=2ttOfcNqD8RwkZMkyYRhUSD5UVl+7dbxJLRUk2DwfWw=; b=PR1Cxp8vD0Wpg1TO60oFkpps5UdmjbCwkHqHEEFLCoYhhB5RKqeEoZ2Lxo3zAgAzrc yQljTbDzvA3DPJF/chJ+saB14y+b5B5w9aMnzx+yJDghb2XUmcN4lE+E7m8R0CwtK5br Nmdr28zBqQmWNcuMHBhFkOfQAJB+1nkc1uxafFnC+LFDW+BW5yNgU808YEV1GUk16Jl7 HrkRJbRS9Pez05waLV02zU72u1iv7zp6l4EU9ytGZxM/EozNM2FPyAoq1/CcAJBKtv4X qPHX7RdQFjxGnkB2KTjXnhiXqPL9eBSUKmdLj7ses2YgMP1lApSYrAfZVj3IXHcNDcaK XbLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ttOfcNqD8RwkZMkyYRhUSD5UVl+7dbxJLRUk2DwfWw=; b=G3QvghaRCHI0qneW7XbxLLkEYZz2hCqMGz7CLb2u3o/UTX7XvDXsBo5NMzEJL3v14s Fj0aq0I3LRSz5gk2boicsQvX7qa7DHzfpIAiK4FfJSGD78PLBPtH/hRaBQdsAAncq1lm meVCjqRkan5Dm3gPCDK3ocJJvh1z4VH4sqXVg6H//kalGDNADUwknvGf9tDyLE07iP6I D0Cl0xkIgMNc3deFZU1ZjQsE9IW+QgNEJczXg67yOKRImHL9PG3YT/3iPf5B7DH8oJvN gpzzPb87lYrfjH7u7MrIw0rwGvAtYTA71LsAHbBvrppdTVbu0+t5ymc5+Ju5skguDO24 Z9Bw== X-Gm-Message-State: ACrzQf34jw1B1E+z52sZgNUxGFsAz35nrHgrBGfUNta2PMO0AqdyYl2G 1MQ0uFjRYsGxYlY97HeNyDg0aLSVH7Q= X-Google-Smtp-Source: AMsMyM7uXRc9jK+r61wtyAHIMXSJaBATyI9M31kRFgaVwVNaCi5VmMvx6TWKK8AXT2UBSSduWFlXbg== X-Received: by 2002:a5d:4e4f:0:b0:236:7a40:ed01 with SMTP id r15-20020a5d4e4f000000b002367a40ed01mr16740646wrt.402.1667443509421; Wed, 02 Nov 2022 19:45:09 -0700 (PDT) Received: from ?IPV6:2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f? ([2a02:8010:64ea:0:8eb8:7eff:fe53:9d5f]) by smtp.googlemail.com with ESMTPSA id o17-20020a5d4091000000b0022584c82c80sm14584829wrp.19.2022.11.02.19.45.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 19:45:08 -0700 (PDT) Sender: Mark Harmstone Message-ID: Date: Thu, 3 Nov 2022 02:45:05 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] ld: Add module information substream to PDB files To: Nick Clifton , binutils@sourceware.org References: <20221102020752.24441-1-mark@harmstone.com> Content-Language: en-US From: Mark Harmstone In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/11/22 14:12, Nick Clifton wrote: > Hi Mark, > >> +  *data = xmalloc (*size); >> + >> +  ptr = *data; >> + >> +  for (bfd *in = coff_data (abfd)->link_info->input_bfds; in; >> +       in = in->link.next) >> +    { >> +      struct module_info *mod = (struct module_info *) ptr; >> +      uint16_t stream_num; >> +      bfd *stream; >> +      uint32_t sym_byte_size; >> +      uint8_t *start = ptr; >> + >> +      stream = add_stream (pdb, NULL, &stream_num); >> + >> +      if (!stream) >> +    { >> +      free (data); >> +      return false; >> +    } > > This fails to compile with: > >    inlined from 'create_pdb_file' at /work/sources/binutils/upstream/current/ld/pdb.c:1097:8: > /work/sources/binutils/upstream/current/ld/pdb.c:481:11: error: 'free' called on unallocated object 'mod_info' [-Werror=free-nonheap-object] >   481 |           free (data); >       |           ^~~~~~~~~~~ > /work/sources/binutils/upstream/current/ld/pdb.c: In function 'create_pdb_file': > /work/sources/binutils/upstream/current/ld/pdb.c:604:9: note: declared here >   604 |   void *mod_info; > > Possibly you meant "free (*data)" ? > > Cheers >   Nick > Thanks Nick, you're right. I couldn't get the warning to trigger with GCC 12.2.1 though, I'm not sure why... Mark