From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 193353858D38 for ; Thu, 25 Jan 2024 08:46:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 193353858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 193353858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706172419; cv=pass; b=cDT5tlslY8CkewQuMZeGwZvbWqlWW1TTAhQZNssuNoYzs9/T4R0aIcHrKfJZLsQH+HM+iLFEiUSST26+8dEURLSSmAlrXw8RUM25QhS+figKQfheAlQySR/VWPgHfmwKK4ycyBHi6nRN0RE5XhDPmMFPes4jpZTjKbnFpmQWD5I= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706172419; c=relaxed/simple; bh=NP6AZraE01113ZdfW6XZzKppaVlZHd4XiLVamjj3HN0=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=uUYNxGOY7eAhhYYY8qfdA0NtSvjkpTQseRXrcCx2AUBZlReerH2JPggfNj2a001ET9kn2uaWI5XjZoRtaiqMG1mfpYzkhO+pMkWXLIWaPb4sEJncEJM6JsmoHV/MySwu8Y6FaISUw+ZofWMApT6cIaAgDMD0cOzw8IxeLxdgWOw= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 40P677iP008839; Thu, 25 Jan 2024 08:46:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=3hFNQ0XbdUvrLhX/TQ4A87alN00ZAz/d9zMpdYeCylc=; b=hBDQ7Efd1AfvXUJqLOEsBMIIeh2QdN0g+qF0xR9q7qRIodYw98RTvcgjr3DGGsRVn65S 8HfsX5NziPNzjtG3f0Xt2b/tenqm8KDaKOdRXpHMO2Ft9xPVNUqS/klT6Zuet5PzI6G9 CWmzMOwJSNoS2V85kPosTLtLiotm11wa9nS7IjbR/qJLkiySUhxTDrHvQs8BOm3mxZp3 +9WQfBo/nYINM/BmDEISP7tvjF1FXgGjgw0cSkQaqm0r3pDCyHaYVG2h8bi+3EI/3zfN oHVjxIwRpptx38aQkhrw9HZQhgXYVKQJ0N046uAqYAyDlsoputS11+5pCuHEH7np9KVf kg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3vr7cwpau7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jan 2024 08:46:50 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 40P7RFql012060; Thu, 25 Jan 2024 08:46:50 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3vs325j7e6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 25 Jan 2024 08:46:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRXJb19N4eNGttG/s7PiG/bhY+RTFNrVKW7BS1g1i8obxuHPfyWMxqe7e9lpN8MQUbxDU/5Unu6au3DQiyiEj+2S8l/dgOtUYy24+xbtkSQujcHFr0E0U0LZuG/xu2MFyrEpGeudisYULl0SVWJPv77qkcbslC0thcRIMtNURutRdGUcsOEyQGiemYDkFC6dbup4ghDogYFnRgkxlKYxNxGqwjRtDxxZejzn9K7hO53FNdTZG0CNTrg5ef6DhpCdcSlCDf/fz9bNbXPzE3naCAxxiUxRoeJkQCfcjpwJPAl9We3EUxu0drM5f3enizdBnOLA9LZxiKhlD31xoNMl0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3hFNQ0XbdUvrLhX/TQ4A87alN00ZAz/d9zMpdYeCylc=; b=OAMqpyUZgvMbTjPxNGlxTe9fz+OviUZtdP8MrgH0PjvAxScA9uSD5iV1SgyU62e1/LvHXaWhgm4EELwaaMnDpIkBThrLwzCKnGfo6hufKYp2iWnJNV5wSp1qL45tdI8OPBrX1dN8RrNe3YwznztGgCIgauctP4RQ/uEEjPaiVrF60NDsSzIMPPIt/M6GUYfmG9SSKWCEeCnsbJSJs7gP4WP6qaEzYc8rqrIGWUYL3dE3+cWzpWogcff33rBn19XomzfKaP1rXdc75cyjcnWa2hLes3L09Ajdvpq6kANLRcvx/lt24300hEFaO31wzMWvQ5GHQ4pss6oWMyjf2qVW5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3hFNQ0XbdUvrLhX/TQ4A87alN00ZAz/d9zMpdYeCylc=; b=t+u2JVi+tDAnzUMk7+npEigUm4NxJQs5zRks9HpxqN03nK3nyOKaKPIQmh+wwx83eutESnVQw5y3/QRxiEqhm2uI73NnCzXR0jMOOMu147VDFA/IjV5j084+1L6fM5aRPa2Hlu00lO9KyBD7k04L+J4o609/YfShXfjvxJks31A= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by DS7PR10MB5903.namprd10.prod.outlook.com (2603:10b6:8:85::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.24; Thu, 25 Jan 2024 08:46:47 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::fde7:fb92:8ea1:a5ac%4]) with mapi id 15.20.7228.026; Thu, 25 Jan 2024 08:46:47 +0000 Message-ID: Date: Thu, 25 Jan 2024 00:46:46 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH,V2] gas: x86: ginsn: adjust ginsns for certain lea ops Content-Language: en-US To: Jan Beulich Cc: binutils@sourceware.org References: <20240124064046.1191952-1-indu.bhagat@oracle.com> <2c745a10-04f5-4994-a627-ea434218a823@suse.com> From: Indu Bhagat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0055.namprd03.prod.outlook.com (2603:10b6:303:8e::30) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|DS7PR10MB5903:EE_ X-MS-Office365-Filtering-Correlation-Id: efba7711-981d-4bdb-269c-08dc1d822a4b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tU0Cn+fL5O2EWA6rUSiekwlq0g7IhqZA4yzM5iFJdC/94oBn9LQXRkK8Ji2IQo3sF0yJ0EqhGP1o4Ir2frOLRk5P/XsAUi5VSOEocbpSUrVGCXbY7aDgqRkTwlXLQiA6YPWbBPbLFBpPMtTbn5NH1nY9vxpqPcq0KnyzHXLbZgMIVtfddwBM9/DBaYwnZbagMpm8XM2LrsmVx6X5gWwM+2Yj2O7Ui92F8CRvY2daliodKLyLsbGMlatzjy4NUVwMDHvXTTp/Wzdpp9Nw/wo66KWS/MfVsElXOIvyoZz3yP4n0gSJ38gyHegXZ6tLRWAJu24M0vSMtbkdMxEuprmBNnrE5/YmYXJkGm5vu+RhVLDPa7GfA7r55IqeSRYLXKSP4nCYrzMD8uqGI/JT61yBqZrwjHOVjCO6pdSM8uD5iq+Oifz0N4GcLShCb3vWctqCE5InwLVdLlOHJMVqGgHbn7KBeqgLKpdrLCiUd8AzbD3ZLkAE8OJq8/q5+PcxiEd4SWQubsly4MkyH8bx29DbncP6zi5bNeCBC0v0FLmE1cOuEpXacmjhugS5JuuHsK8yGx0lkwPlbSIyRUUNq2g4ilWYMuWtB0yzh8lHz9n5CmenIeadf/b7veleVmMOhA/TtlaxGPPjOw7bhSauhufcCXs6E4QZwbSrlVu+dz6viWzkhOW9plXjwHK70hDnJ0NH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(396003)(39860400002)(346002)(136003)(376002)(230173577357003)(230922051799003)(230273577357003)(64100799003)(186009)(1800799012)(451199024)(6916009)(41300700001)(38100700002)(53546011)(478600001)(36756003)(6506007)(6486002)(31696002)(86362001)(4326008)(8676002)(2616005)(316002)(66946007)(66476007)(66556008)(8936002)(5660300002)(83380400001)(44832011)(2906002)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NThRSG5CS1VITDJhVEpZTEoxREVVajNVNkMwSVNacU1YN2psMitiTW1MVXlB?= =?utf-8?B?VFRRVTFxT3F4RURUNW5HRFRaeER5ZGY0MU40SFdFck0zUTRGb2NGOGV6SDMx?= =?utf-8?B?T0x5MDJKd2wyQTk2TnRaUGtLRW81cXJXTmV4OVFWLzVwMUVPVVpPd3VIYW1G?= =?utf-8?B?bmg2Q21nZ1FsSFhOMDlkWkF1VVplMUdRMTRoNDVKak9ORzlsRGpaS2dFL2Ft?= =?utf-8?B?cEwvOG1QQlhZVW1qQzJkWnpKNzJoemxoNXgxdzdFWU01OWxUMmdRQ2pYcGZt?= =?utf-8?B?bVBmUDcrUTAzQ2hBZG9wNzJnd09maU1DSFBRRGkxY0RrZUo5VktXQWJsQ2xp?= =?utf-8?B?aUpWOUJKU2RpdUNnSkhFNkh2RW9OZGRMWklFNFdyT3BDY1NDajQraGJvdjFx?= =?utf-8?B?R3hJamJmZWVyWUx1ME1hSjUyZmxLajVwTXp0SUpjdFdYMXp6VTdDRG9kTXdK?= =?utf-8?B?UlNTZ3dmU0RQYkkwQm9RREh5T25xUmphNkZ1M3BMTFhlVVJoTWdENUtFRU9E?= =?utf-8?B?MzdabE9DKzFDSXJiYUltdTRYdzlNa2lwVjlxS0xlcTM2d3B1SEgwRE84RUd6?= =?utf-8?B?Y1ZaVVlldDlCOWtXbDNtSTFnVy9ZeW01Z2dsczBJN0RmRmhwRWg4RlBaTDIv?= =?utf-8?B?aUxnQjBFMW5wQWhJSTBiNDhUSHBIRGh2bmNzL2R1VHpUMEVMUXlOODNmVE1v?= =?utf-8?B?bEd4RmZkbkVlWWZteEJhdldDZlFEditvYmMzZ0I1V3IwR2x2M1FSbU1uQlBM?= =?utf-8?B?SWdjVmJxWGdkNDNOYjZzazdTdzBCOC9EOHNNcTE5QkEwbkgwbmprVU4yOC9O?= =?utf-8?B?YjduUHdGTEI0ZHZVbzJQamRVK2FvekN4eEVOejBtM3VXazZNaWJTcm9hREhG?= =?utf-8?B?K3QrUXBuMGxBVjJicHhLNm8yYUUyVEVCaWMyZ3YwRTVlaS9acWdHU3NVcUpw?= =?utf-8?B?OFl2UnFYR1F3Wm5PTkNaWHJKempDcWgyY0pvV3ZxaGR6Q2crSXlEL2w1bUpG?= =?utf-8?B?N0dua2VPb0JHa3pzWkNMQXd6RWpncTZRUEJZaTJSVEY1Y3gwdU1HRUROOExq?= =?utf-8?B?NjBmelVsYzFDTFhSWUhPdGJ6UXpOYW11SGN6TGpRZ2tvRFdFb2RXZWpVOGFP?= =?utf-8?B?QlkrYlAvLzNrbjY5L00vaGo3K093RVZqcCtXQnhVNWtIbkUrSFZmb0dkOE9O?= =?utf-8?B?YjYyNC9wZ2t4TGhCY3l2T1RJY1FDRUxYbXVXY090UmtoaTlpdURScFJkbGlo?= =?utf-8?B?ZW0yRlVvUWxEL1lDbGRBWnhLTlUzaUtXNytDYVBkbzM2OW5kdWpCT2tMdXVB?= =?utf-8?B?QzNhWlN2L2diVkZSV0tKQlRjNGxZK1VVcEFPaXkwYUE1T2dIcDZSdU5odVJY?= =?utf-8?B?OGhzSFE3Vlo2eEVEdm81eHVlQzlKbmJiNC9WaXJDUVpxTjRZRHZ0NTM5bjNP?= =?utf-8?B?SHJLVjVBR0FmQjJ6U0ZvWVNCQ0E3R29hanlQQlgydG80blBqcXhMaXhscHp1?= =?utf-8?B?Q2FybG5ncWhTZ1pkRlFrb2s5SmRhWEhqaHFlUUJpK01NNXlEUVM5bS9BR1Rv?= =?utf-8?B?aGFMRVMxOXlRanZ4K2Y4cXZOSVc3K2tvbmRTb1NUSDFTOWxlT1BSRzJQLzBJ?= =?utf-8?B?b1BZZWxVS1hqWDJIcEtqZjNBR1RRN1lWK0JLWFc1VzgrU2hmTmhSREsvSEhD?= =?utf-8?B?RmJCUkFvUFJqTGtDNnBvRFRXUFFFUEFPeXI4VnFFbVZ4ZGFOaFV0ZkRzVTlT?= =?utf-8?B?OU5kUEVxZkxxMHpUTlB4c29LTUMrK1lNdGRJSTlzbExMQ1RLNE4vWE9VU1ZV?= =?utf-8?B?Qk1ocWxuSW5Rc0Vka0lnc2p4TlRrcXhyaEVJNVlzYmFzYk5SZ0tFUTBLWGdo?= =?utf-8?B?a3JGYWZHR1B0dlBxc0pPdUlKK3RXWDl2ZWdDVkVOb1V3RUpJbWhsVkZ4UnB6?= =?utf-8?B?NExua0crUGVSeVFlays3OCs3V2NHTElJRjFtdk9zcnlFcUo3QUtHbHVPOHhH?= =?utf-8?B?eTY4ZURpYmk0ZmpaditvL2FWT1NuUWtxUWpxdzQ0YXFlV05pcitLODVuY2gr?= =?utf-8?B?N0RNYXdjUy9JQmc3ckpnL0VoOW5PTVBzNFU4cmJ2dFRUdTdmS0JDeFc4M1Bn?= =?utf-8?B?Qm1PVjRyN3R3SWF5UWx1Yk9KV2xiK2pZYnNwSDhaMnpzem9KcHFNZ2xJNXRi?= =?utf-8?Q?ZTdcWdDIX7WHR8EflOdwGsY=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: CdhSJU/+angw71+4onlKy+PE+88UjnF4v6KbchydB91huu3Ou1ncfzgWUs7e5eZTl8smaF86tYgINK0TjFrZW7IPiovUgQ+LotB88xtmE9WyOOoioMTt9CzWSCX2v2f9irIWbjel+k6VpAtWOjcXsyHyI1YBX/RR+XXLFOMXktb9IMcxb74uiK41PSepf3l+R1CONMTHYp5ZqNx6qWi3uVM5qUS2isq/hAQf+/pXZiBZ5y3C8F3ML2yu2QEeztY9lmm63L1NaCubonSzIgvnA/0r4vH+E88yhkJ14gStXrogxPRXrgOSq9HEzf4QXkBW+c+dtdl4Y6TKwOhZYalt+rW0kOZaKn4zfUCEdo9hd5l5NHrD58J1O4t3gSO/JONyZzued0CcRadJrYCqwBVJN/S9Ri5N6QhnAkHLO6Q+C4jrADOBty1CdVRytwipZy4oZk+LLHG/m3Uq0ns6Lq9GWqR5n7i3tAnQ+Lh8rTiy21fKj79WkX2tf08y4Gnt7Ruk1m8LRfmlMIcWhEhd6fffTJ7VZXr0EzOtKIHkMZMrZ4p1rY0IU4JdhvFL/m/w7GexulmFlhJAYXvfQD5PJj5oQg7U8+3nEuuk7RSmsbQ13jA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: efba7711-981d-4bdb-269c-08dc1d822a4b X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 08:46:47.3295 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tk1IulPF7mOQTlJ3IY+aSVnFvR/pWURdPYbY0RXVB7kLO1dLLgIPDBkmMx2u9rDA6cgLZCqkK8iNsvzkcMtF1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5903 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-25_04,2024-01-24_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=958 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2401250059 X-Proofpoint-ORIG-GUID: 7uE7WAEGpi-SbRgsukF-4TSIXxYzUXsv X-Proofpoint-GUID: 7uE7WAEGpi-SbRgsukF-4TSIXxYzUXsv X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/24 23:33, Jan Beulich wrote: >>>> dst_reg = ginsn_dw2_regnum (i.op[1].regs); >>>> - ginsn = ginsn_new_other (insn_end_sym, true, >>>> - GINSN_SRC_REG, index_reg, >>>> - GINSN_SRC_IMM, index_scale, >>>> - GINSN_DST_REG, dst_reg); >>>> - /* FIXME - It seems to make sense to represent a scale factor of 1 >>>> - correctly here (i.e. not as "other", but rather similar to the >>>> - base-without- index case above)? */ >>>> - } >>>> - else >>>> - { >>>> - /* lea disp(%base,%index,imm) %dst. */ >>>> - /* TBD_GINSN_INFO_LOSS - Skip adding information about the disp and imm >>>> - for index reg. */ >>>> - base_reg = ginsn_dw2_regnum (i.base_reg); >>>> - index_reg = ginsn_dw2_regnum (i.index_reg); >>>> - dst_reg = ginsn_dw2_regnum (i.op[1].regs); >>>> - /* Generate an GINSN_TYPE_OTHER ginsn. */ >>>> - ginsn = ginsn_new_other (insn_end_sym, true, >>>> - GINSN_SRC_REG, base_reg, >>>> - GINSN_SRC_REG, index_reg, >>>> - GINSN_DST_REG, dst_reg); >>>> - } >>>> + /* It makes sense to represent a scale factor of 1 precisely here >>>> + (i.e., not using GINSN_TYPE_OTHER, but rather similar to the >>>> + base-without-index case). Ignore the case when disp has a symbol >>>> + instead. */ >>>> + if (!index_scale >>>> + && (!i.disp_operands >>>> + || (i.disp_operands && i.op[0].disps->X_op == O_constant))) >>> This is functionally identical to the shorter >>> >>> if (!index_scale >>> && (!i.disp_operands || i.op[0].disps->X_op == O_constant)) >>> >>> But: What about any of >>> >>> lea (%rax,%riz),%rbp >>> lea (%rax,4),%rbp >>> lea (%rax,%riz,4),%rbp >>> >>> ? >> Current behaviour is: >> >> lea (%rax,%riz),%rbp >> ginsn: OTH 0, 0, %r6 > Ought to be MOV? > MOV is more precise, thats true here... >> lea (%rax,4),%rbp >> **** Warning: scale factor of 4 without an index register >> ginsn: MOV %r0, %r6 > Oh, right - the scale factor is zapped in that case along with issuing > the warning. That's not quite right though, I suppose. > >> lea (%rax,%riz,4),%rbp >> ginsn: OTH 0, 0, %r6 > Ought to be MOV again? > ..and here again. But I am inclined to just leave them as OTH for the same reason, we left the sub-case handling of lea symbol, %dst : this is better expressed as a MOV itself. >> lea sym(,%riz), %rbp >> ginsn: OTH 0, 0, %r6 >> >> lea (,%riz), %rbp >> ginsn: MOV %r4, %r6 >> (We use DWARF register number 4 {%rsi} in lieu of %riz). > Where's the 4 coming from? That doesn't look right. Imo when you > create insns other than OTHER, they should be correct. Irrespective > of SCFI's needs. (The case here is no different from "lea const, ..." > so ought to be handled like that.) Since %riz is a pseudo register, and we need a DWARF register number in the ginsn representation, I designated %rsi to be used instead when %riz or %rip appears. This adds a inexistent data flow dependence, but I judged that this _should_ be ok (as not callee-saved register). That said, for this specific case of 'lea (,%riz), %rbp', generating ginsn GINSN_TYPE_OTHER does seem better. I agree that when we create ginsn other than GINSN_TYPE_OTHER, they should be as precise as possible. I can add a check of (!i.index_reg || i.index_reg->reg_num != RegIZ) and handle lea (,%riz), %rbp as GINSN_TYPE_OTHER.