From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 791983858437 for ; Wed, 5 Oct 2022 21:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 791983858437 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id f140so234823pfa.1 for ; Wed, 05 Oct 2022 14:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=HPFf6bNs8Tcm3Vv3chgnckbklv5MIid1oDm8Hadh0SI=; b=DK2S8wUDd0geFKQigVz1gXLiVKhgUGgx3wwZ+4F7f+g5PeyzNEibdYb3h4xcS7VU/z BC++9arnDtXT3oyC28y5bVXZTfnq7+YijWFyOxlx/fvIwYHPfFbxA+JQcfl6okd6ZZyr ygYMW/kArSUuEcom9duFaqNa3Al5OsW+je98tDUCHpQLeVqTgcCb0dERr41Ju5f8PP4B OrObXGCiLoZtnQXMxQIn0nPWUApGtamOKuTZSAeZ7LyCp3tr2bcQ/jGXVNjwEnKQ2Wrb 6fb9IwWLM8FxbYntSEPiZkLMr5yAWq3I/3mbEDaplMhp22HkqYgJQ3MM2m4SQZlTirUk trkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=HPFf6bNs8Tcm3Vv3chgnckbklv5MIid1oDm8Hadh0SI=; b=EgINiGvk3EWVnflkzrUQIL7CZZViPaI9w4Blc+78bxj4CcmzPFlxLj9OQygcaJ26Dn lIJdkYv7/TVHgbdBWdJygqEiet5+xwqjaTiabMQ2HDWmk8XUVVCMHOi6V2mpPbZT2vDj PUvZSGpMHq9cDpfReebuDvR1gzUEESJam6Y3ZN3P/WSVRPdU/N+oqXBmIp6vVb5qLJx9 04SvIseTjyCmEx5OTapAPg8SkSi7MTkrNYGSLE2Rgz2eeKM66ivBr/NwHpTxRhHa8MQ9 uFOBf7lawJ4SKdUkaIhptvjMWfUHK8B6f4fl/TyzmLt3WEm02JbiI3EuEigfHMe5hRh9 hnUg== X-Gm-Message-State: ACrzQf14IRxoTTJMV7Pu8j9IDOQ775saN01I1KV2afyhSazmljBE/xD4 yUgpIWf2fAzeei4szcVO7RMPbjfTsDR7mw== X-Google-Smtp-Source: AMsMyM4UvzwlS/lpBs3hh4mXbRF3cG79r9tH+3SWyTV0YGvTof/RZ2whV2a8Q6Bob8v7bplQlecN/A== X-Received: by 2002:a05:6a00:a96:b0:558:8915:2f0e with SMTP id b22-20020a056a000a9600b0055889152f0emr1738094pfl.38.1665006753942; Wed, 05 Oct 2022 14:52:33 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id k12-20020a170902ce0c00b00176e6f553efsm10948946plg.84.2022.10.05.14.52.33 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Oct 2022 14:52:33 -0700 (PDT) Message-ID: Date: Wed, 5 Oct 2022 15:52:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 0/6] RISC-V: Fix disassembler types and styles Content-Language: en-US To: binutils@sourceware.org References: From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/3/22 11:40, Palmer Dabbelt wrote: > On Mon, 03 Oct 2022 02:59:18 PDT (-0700), aburgess@redhat.com wrote: >> Tsukasa OI via Binutils writes: >> >>> Hello, >>> >>> This patchset fixes various typing and styling errors on the RISC-V >>> disassembler. >> >> I can't approve binutils patches. >> >> I've taken a look through this series, and other than the minor typo I >> spotted, this all looks good to me. > > My worry with these things is that it's sort of a grey area in terms > of what our stable user interface is: there's definitely folks who try > and parse the text output of tools like objdump and changing anything > risks breaking that.  IMO that's too strict of a stable interface to > keep around as it pretty much prevents us from fixing any disassembly > weirdness, but I'm not sure if that's what other ports do and I don't > want to make a mess by breaking users' expectations here. > > That said, as far as I can tell the only user-visible change here is > to print some bits with the correct syntax coloring in GDB. Seems > pretty straight-forward to say anything users can't rely on parsing > syntax highlighting colors being a stable interface, so maybe we can > just punt on the grey area for now ;) I don't think the precise for of disassembly output needs to stay stable; it's certainly not something we've ever promised or encouraged folks to rely on.  Obviously we shouldn't change it just for the sake of changing it, but if we need to make a fix, we should just make it. jeff