From: Jan Beulich <jbeulich@suse.com>
To: Stephen Kitt <steve@sk2.org>
Cc: binutils@sourceware.org
Subject: Re: [PATCH v3] tests: force non-deterministic mode in non-deterministic tests
Date: Mon, 11 Mar 2024 08:25:16 +0100 [thread overview]
Message-ID: <aaff7fd8-e427-4307-9d64-517da6bd80de@suse.com> (raw)
In-Reply-To: <20240310153104.731d42ad@heffalump.sk2.org>
On 10.03.2024 15:31, Stephen Kitt wrote:
> On Tue, 27 Feb 2024 10:45:01 +0100, Jan Beulich <jbeulich@suse.com> wrote:
>> On 16.01.2024 14:57, Stephen Kitt wrote:
>>> Since ar can be built defaulting to deterministic mode, tests which
>>> expect non-deterministic behaviour need to explicitly set the U flag.
>>>
>>> The non-deterministic member test expects SOURCE_DATE_EPOCH to not be
>>> set; this documents that. Unconditionally unsetting the variable
>>> causes issues in test infrastructure (which expects unsetenv to only
>>> be called on variables which are already set).
>>>
>>> Signed-off-by: Stephen Kitt <steve@sk2.org>
>>
>> In the absence of any other comments, please feel free to put in.
>
> I’m not sure whether this was asking me to apply my patch to the binutils
> tree, but I can’t push to the binutils tree myself.
I see; I've committed it on your behalf.
Jan
next prev parent reply other threads:[~2024-03-11 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 13:57 Stephen Kitt
2024-02-27 9:45 ` Jan Beulich
2024-03-10 14:31 ` Stephen Kitt
2024-03-11 7:25 ` Jan Beulich [this message]
2024-03-11 7:51 ` Stephen Kitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaff7fd8-e427-4307-9d64-517da6bd80de@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).