From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 925C23858C53 for ; Sat, 7 Oct 2023 23:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 925C23858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=eagercon.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E6EC8841391; Sat, 7 Oct 2023 23:07:32 +0000 (UTC) Received: from pdx1-sub0-mail-a246.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 6A96584127F; Sat, 7 Oct 2023 23:07:32 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696720052; a=rsa-sha256; cv=none; b=jNIYZmOCXSkKkLcsla68QH80G7Bk0tHTbW6TqmI2yFAXBIYMYEstawtWtQUN7/KB/Mb2Et 6rj+xCMdzgRF/Mbk9IdPWw9NTQuCPHKvHf6mYcTEr8A6LiBCXXhkRyRYbaldeLRivr82DI e5tbXBej+wHAFrnNBKoGbXR9zEF6UPrIqAAOkwcNmhGmwEFATMkRxrDtGDdCiV+HDbg9IL vs+EsSaBfg6z7otwqwpvHe01zuL59+w9Yq+Ryitd+wJIAYVFZHV5NQ27MTtT4OMCea8a1j OYOcDKRRXgIVPqz0GcOG9Bi58JOgRYc1Ee62w0pf28sidymepkaA7XsWNabbQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696720052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ws8it9bchDcjxMHAu/GN145JEDge7KgclNyucgsS0Cc=; b=xd8QHrNkkBQ/U4D2twjJrYydda+qH/tquM+vvn4S+ZJa+yhcgliy60SBVHvh+6ESIjbxex cSOZI4HseisMiFkAYvjILUs8v1pVSEABfUtU9TLXMWD+RIOFEOfzwEvQUnYFHehNpShhhH wC5ShE8ICvPe7ceKf2AApsO+uHpApq+Xpe/nCuXl1OSbZrrkky8hnfgWgKwfWDsP+ZTVfk 7Ro4iIpIUwpn/BeDLzHCAN4cqowyHXIza84kvv/drwopq5I0E0PtburQ4iNr9IOiSU1pvm 6iWsv1+VxM0EyhlbJ2zMzlDy7dUy3AqK3BujYdeDUe5aOneczN2BIvFcUXbxtQ== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-r6smj; auth=pass smtp.auth=dreamhost smtp.mailfrom=eager@eagercon.com X-Sender-Id: dreamhost|x-authsender|eager@eagerm.com X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|eager@eagerm.com X-MailChannels-Auth-Id: dreamhost X-Befitting-Obese: 74982d8a61bee769_1696720052745_274366915 X-MC-Loop-Signature: 1696720052745:4166990140 X-MC-Ingress-Time: 1696720052745 Received: from pdx1-sub0-mail-a246.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.126.222.7 (trex/6.9.1); Sat, 07 Oct 2023 23:07:32 +0000 Received: from [192.168.20.10] (c-73-170-238-207.hsd1.ca.comcast.net [73.170.238.207]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by pdx1-sub0-mail-a246.dreamhost.com (Postfix) with ESMTPSA id 4S31Cl5gXYz54; Sat, 7 Oct 2023 16:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eagercon.com; s=dreamhost; t=1696720052; bh=Ws8it9bchDcjxMHAu/GN145JEDge7KgclNyucgsS0Cc=; h=Date:Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=BINni794anakVQoft5EJp0NsJ4/Glz7wlMfOEbX5rI0YlFvYO1Q/KhzNvNQ011aQN X0j2cwIp1hRrzHd6cXQ1u8BZZ2aI5wiPfCJfk86Eo69FjTB+GvgCKrm4uo+e9GEyz8 7Ho5qLsaGIpYtmOXNAKjsRy2WFyC4vZ6s22K4Yi5EaoJiHymeZ50VAeLx3GuS84fuv cKTNCGeqkJAp3zV1H/JCXv84qoAw+G8OVJ5p1S8j9LQnieX7KxaWETgRx96RBc/RwH 0XWhjIQcGKFDqTB0d4WFvN7FGEu4hlht/16O5OTHRJvFXFUc27F1iPvNFpiNoPuxjq v6CGmYVsP1NHQ== Message-ID: Date: Sat, 7 Oct 2023 16:07:30 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] microblaze: fix build error on 32-bit hosts Content-Language: en-US From: Michael Eager To: Mark Wielaard Cc: appa.rao.nali@amd.com, binutils@sourceware.org, ibai.erkiaga-elorza@amd.com, luca.ceresoli@bootlin.com, mark.hatle@amd.com, nagaraju.mekala@amd.com, neal.frager@amd.com, nickc@redhat.com, sadanand.mutyala@amd.com, vidhumouli.hunsigida@amd.com References: <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> <20231007220105.818599-1-mark@klomp.org> <609d027a-0671-4416-ea0f-6d59b32f94f1@eagercon.com> In-Reply-To: <609d027a-0671-4416-ea0f-6d59b32f94f1@eagercon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/7/23 15:53, Michael Eager wrote: > On 10/7/23 15:01, Mark Wielaard wrote: >> commit 6bbf24955 opcodes: microblaze: Add new bit-field instructions >> introduced a build error on 32-bit hosts: >> >> elf32-microblaze.c: In function ‘microblaze_elf_relax_section’: >> elf32-microblaze.c:1989:53: error: format ‘%lx’ expects argument of >> type ‘long unsigned int’, but argument 5 has type ‘bfd_vma’ {aka >> ‘unsigned int’} [-Werror=format=] >>   1989 |       fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", >> __LINE__, val, irel->r_addend); >>        | >> ~~^                    ~~~~~~~~~~~~~~ >>        | >> |                        | >>        |                                                     long >> unsigned int        bfd_vma {aka unsigned int} >>        |                                                   %x >> elf32-microblaze.c:2074:51: error: format ‘%lx’ expects argument of >> type ‘long unsigned int’, but argument 5 has type ‘bfd_vma’ {aka >> ‘unsigned int’} [-Werror=format=] >>   2074 |    fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", >> __LINE__, val, irelscan->r_addend); >>        | >> ~~^                    ~~~~~~~~~~~~~~~~~~ >>        | >> |                            | >>        |                                                   long >> unsigned int            bfd_vma {aka unsigned int} >>        |                                                 %x >> >> Fix by explicitly casting the r_addend to long. >> --- >>   bfd/elf32-microblaze.c | 4 ++-- >>   1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/bfd/elf32-microblaze.c b/bfd/elf32-microblaze.c >> index a8ced43c08a..2c584f91a4e 100644 >> --- a/bfd/elf32-microblaze.c >> +++ b/bfd/elf32-microblaze.c >> @@ -1986,7 +1986,7 @@ microblaze_elf_relax_section (bfd *abfd, >>           /* Validate the in-band val.  */ >>           val = bfd_get_32 (abfd, contents + irel->r_offset); >>           if (val != irel->r_addend && ELF32_R_TYPE (irel->r_info) == >> R_MICROBLAZE_32_NONE) { >> -            fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", >> __LINE__, val, irel->r_addend); >> +            fprintf(stderr, "%d: CORRUPT relax reloc %x %lx\n", >> __LINE__, val, (long) irel->r_addend); >>           } >>           irel->r_addend -= (efix - sfix); >>           /* Should use HOWTO.  */ >> @@ -2071,7 +2071,7 @@ microblaze_elf_relax_section (bfd *abfd, >>             val = bfd_get_32 (abfd, ocontents + irelscan->r_offset); >>             if (val != irelscan->r_addend) { >> -            fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", >> __LINE__, val, irelscan->r_addend); >> +            fprintf(stderr, "%d: CORRUPT relax reloc! %x %lx\n", >> __LINE__, val, (long) irelscan->r_addend); >>             } >>             irelscan->r_addend -= calc_fixup (irelscan->r_addend, 0, >> sec); > > I didn't see any build errors, building with GCC-12.3.1. Building with GCC-13.2.1 on Fedora 38 -- no error messages. > Which version of GCC are you using? > > (Patch was reverted.) > -- Michael Eager