From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id D96A93858D35 for ; Thu, 29 Jun 2023 13:10:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D96A93858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.171]) by gateway (Coremail) with SMTP id _____8Bx2cXPgp1kfeIDAA--.6219S3; Thu, 29 Jun 2023 21:10:40 +0800 (CST) Received: from [10.20.4.171] (unknown [10.20.4.171]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dx_yPOgp1k5vsQAA--.19697S3; Thu, 29 Jun 2023 21:10:38 +0800 (CST) Subject: Re: [PATCH v6 0/7] LoongArch: disassembler improvements & deprecate old register aliases To: WANG Xuerui , binutils@sourceware.org Cc: Chenghua Xu , Zhensong Liu , Lulu Cheng , Fangrui Song , Xi Ruoyao , WANG Xuerui References: <20230629061029.29773-1-i.swmail@xen0n.name> From: mengqinggang Message-ID: Date: Thu, 29 Jun 2023 21:10:38 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20230629061029.29773-1-i.swmail@xen0n.name> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Dx_yPOgp1k5vsQAA--.19697S3 X-CM-SenderInfo: 5phqw15lqjwttqj6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoWxAr45Gr4xJF1fGw4fJr1UurX_yoWrZrWkpF y7ZF4qyrW8CFs3ur1kW345Xrn7Jw4xGrWaqFyft3WIkrn3Xry2vw18trZxZFZ8J3yUWa4S qr4rWw1UZF1Dt3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU5529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GF ylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j1 WlkUUUUU= X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, There still some errors when run "make check" configured with --target=loongarch32-unknown-linux-gnu and --target=loongarch64-unknown-linux-gnu. ÔÚ 2023/6/29 ÏÂÎç2:10, WANG Xuerui дµÀ: > From: WANG Xuerui > > Hi, > > This series implements colored output for LoongArch disassembly, and > some minor tweaks to the output so there is less clutter. While at it, > also deprecate the aliases $v0, $v1, $fv0, $fv1 and $x, so users don't > find it confusing in an era when $vrNN and $xrNN (LSX/LASX registers) > are also available. The patch is included last because its test case > would need tweaking if the disassembler changes first get merged anyway. > > The 4th revision was sent back in February but at that time the Loongson > maintainers were busy with linker relaxation support; now that the work > was done let's try upstreaming this series again, hopefully for > inclusion in binutils 2.41. > > Changes from v5: > > - Rebased > - Added DCO (Signed-off-by) tags and changelog entries (I hate them but > it seems LoongArch patches usually carry some, so I went for > consistency) > - Absorbed the https://sourceware.org/pipermail/binutils/2023-June/128073.html > patch > - Minor tweaks to the commit messages > > Changes from v4: > > - Rebased (mainly test case changes) > > Changes from v3: > > - Fixed ld test cases (make check-gas and make check-ld both pass on > x86_64 and loongarch64) > - Branch target address is now correctly printed in comment style, plus > code simplification as suggested > > Changes from v2: > > - Fixed test cases > - Added the fixed "LoongArch: support disassembling certain pseudo- > instructions" patch into this series > - Fixed ".insn" in the last patch to say ".word" instead (MIPS muscle > memory strikes back hard) > - Fixed some commit messages > - Added mengqinggang to Cc list > > WANG Xuerui (7): > LoongArch: support disassembling certain pseudo-instructions > opcodes/loongarch: remove unused code > opcodes/loongarch: implement style support in the disassembler > opcodes/loongarch: style disassembled address offsets as such > opcodes/loongarch: do not print hex notation for signed immediates > opcodes/loongarch: print unrecognized insn words with the .word > directive > LoongArch: Deprecate $v[01], $fv[01] and $x names per spec > > gas/config/tc-loongarch.c | 45 ++++++- > gas/testsuite/gas/loongarch/64_pcrel.d | 2 +- > .../gas/loongarch/deprecated_reg_aliases.d | 17 +++ > .../gas/loongarch/deprecated_reg_aliases.l | 7 ++ > .../gas/loongarch/deprecated_reg_aliases.s | 5 + > gas/testsuite/gas/loongarch/imm_ins.d | 84 ++++++------- > gas/testsuite/gas/loongarch/imm_ins_32.d | 54 ++++---- > gas/testsuite/gas/loongarch/imm_op.d | 44 +++---- > gas/testsuite/gas/loongarch/jmp_op.d | 44 +++---- > gas/testsuite/gas/loongarch/li.d | 8 +- > gas/testsuite/gas/loongarch/load_store_op.d | 80 ++++++------ > gas/testsuite/gas/loongarch/macro_op.d | 4 +- > gas/testsuite/gas/loongarch/macro_op_32.d | 4 +- > .../gas/loongarch/macro_op_large_abs.d | 12 +- > .../gas/loongarch/macro_op_large_pc.d | 12 +- > gas/testsuite/gas/loongarch/nop.d | 2 +- > gas/testsuite/gas/loongarch/privilege_op.d | 8 +- > gas/testsuite/gas/loongarch/raw-insn.d | 11 ++ > gas/testsuite/gas/loongarch/raw-insn.s | 7 ++ > gas/testsuite/gas/loongarch/relax_align.d | 6 +- > gas/testsuite/gas/loongarch/reloc.d | 2 +- > gas/testsuite/gas/loongarch/uleb128.d | 22 ++-- > include/opcode/loongarch.h | 11 +- > ld/testsuite/ld-loongarch-elf/jmp_op.d | 40 +++--- > ld/testsuite/ld-loongarch-elf/macro_op.d | 24 ++-- > ld/testsuite/ld-loongarch-elf/macro_op_32.d | 4 +- > ld/testsuite/ld-loongarch-elf/relax-align.dd | 4 +- > opcodes/disassemble.c | 5 + > opcodes/loongarch-dis.c | 118 ++++++++---------- > opcodes/loongarch-opc.c | 81 +++++++----- > 30 files changed, 424 insertions(+), 343 deletions(-) > create mode 100644 gas/testsuite/gas/loongarch/deprecated_reg_aliases.d > create mode 100644 gas/testsuite/gas/loongarch/deprecated_reg_aliases.l > create mode 100644 gas/testsuite/gas/loongarch/deprecated_reg_aliases.s > create mode 100644 gas/testsuite/gas/loongarch/raw-insn.d > create mode 100644 gas/testsuite/gas/loongarch/raw-insn.s >