From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C63B93858D38 for ; Tue, 26 Mar 2024 09:58:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C63B93858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C63B93858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711447102; cv=none; b=djjoq2f6Wl1T0HH6yGGKiR3GBMF4r9igPt5S84iFCL96y/pQy6499vN4Dou/kfIbp5RfOQ7nxN4V37n8igg5CLTt/JoNDR0TN6gcvP4YhjaJTeu9igWRZ8/sq3FGKG5wokP533AGQ14hiaYDHpL+Um+kImDsgaQA4BltnnTVnsE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711447102; c=relaxed/simple; bh=uepBemY2IFJCwYy1bTEwJ2wrV0mVjJ6t61d1it4uMvI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=t9/Bcdq4XcCJmvroUVxsJgYZgi4RVK8CQoXRAf4/pUmpQBaTTvsKtCEbyje9wt0DKS5paNwKqHqivae5EKtEpLrmKgom9P7VP5JlGIk+pDMyJRoGp6osJuCf5QjxOEXOYmKQJO649j8N/G5jAnfjTQrdJxR5xWa2xCGBtC3tQ5w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711447100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KNaWMrUmcbvE6iNeRaqzmiivJjpssyvBruIeNG1fn/4=; b=IwOrlE4duDapzYl1KIZLGvD0kPTkkEOrHWV88anr0UtW3YK20WQ+D8MsUCV77McikZ8cP/ Dh9kKZk/Sbtfkz5L8kg1I+e/4meir/w/jO/TFOCNMlk4GvBZU4xLu8NLQN/ZkyohwJT6ZL Ram3QPzpVsSZBaVwElbumm3sI/ApRz8= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-258-3ABqVAnsO62idla1qhV-sw-1; Tue, 26 Mar 2024 05:58:18 -0400 X-MC-Unique: 3ABqVAnsO62idla1qhV-sw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4148b739698so6665485e9.0 for ; Tue, 26 Mar 2024 02:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711447097; x=1712051897; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KNaWMrUmcbvE6iNeRaqzmiivJjpssyvBruIeNG1fn/4=; b=YWg9h4p0FnJ6RCxzGzSftjDLDI6CL2ABC3xHPCEfAQncMACnAJGrILMm69lfGzszMp LAKPob5llFe588wknU+haAQ+9VmPm9m/5CYVlgcZaZxDYuuBR+2nrY3TPODZtgauolBc 5KmbZkP4N8klP1fP4YB1buVZL3FFtKK4qcrAUQV5D4IGSfzfwFjOwEaIAHbjSFPWfXbB 9CQFS4MjTocphRdekFETUQ81/Lh4d6zYGgblDXx0WpuCUvVnONw3xV3XL2LgnSMYeT+J As+dgg+e7YmGrVpmvBtqbMpfVCwq0OGXOXaRaVEs7xgk5timl9frKzzUjIEmKn2zS7Xm f2mQ== X-Forwarded-Encrypted: i=1; AJvYcCWTlA5qpXRaK7bv7f/5jJHpE/8Bi5pfgouE3zXaNT3K71fDjfYSQZFIP/mG9zhoVC1bBjRvkHZITP2gcxZA3gjPcQ/Y9xa8PQ== X-Gm-Message-State: AOJu0YyEk+l3j7szg5BQnsd4VnhrTI8mZ2CcAW6dJ3yn1PWc59Np+v0c JlUTbJOVnGJm6OEhGQFjO+P88XXLZsG7sy4KO/ic5z71YFyTlh/vxsG7YbAHASzyFQfHAKdkaJK O9u/QL7YmrDWNFeA8yjCCwQ6tZ5AuZyw223XWVqLnhPqJw88wZI6X/SG8dtmQPso= X-Received: by 2002:a05:600c:5248:b0:414:cbd:1ee2 with SMTP id fc8-20020a05600c524800b004140cbd1ee2mr6433214wmb.35.1711447097345; Tue, 26 Mar 2024 02:58:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIiKTciRb9Lf6JRXx/IH59KdUd7nFLBPFAW4HDfVIFL+OZBXSDmA7YFfBPvCV3e+iV/Fnlww== X-Received: by 2002:a05:600c:5248:b0:414:cbd:1ee2 with SMTP id fc8-20020a05600c524800b004140cbd1ee2mr6433204wmb.35.1711447097075; Tue, 26 Mar 2024 02:58:17 -0700 (PDT) Received: from [192.168.1.18] ([79.123.79.31]) by smtp.gmail.com with ESMTPSA id m29-20020a05600c3b1d00b004147b5dd6f8sm11235656wms.9.2024.03.26.02.58.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 02:58:16 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 09:58:13 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] gas: sanitize FB- and dollar-label uses To: Jan Beulich , Binutils Cc: Alan Modra References: From: Nick Clifton Autocrypt: addr=nickc@redhat.com; keydata= xsFNBFm/2cUBEADkvRqMWfAryJ52T4J/640Av5cam9ojdFih9MjcX7QWFxIzJfTFYq2z+nb4 omdfZosdCJL2zGcn6C0AxpHNvxR9HMDkEyFHKrjDh4xWU+pH4z9azQEqJh331X7UzbZldqQo 16VkuVavgsTJaHcXm+nGIBTcUbl2oiTtHhmuaYxx6JTMcFjC7vyO5mLBw78wt52HBYweJ0Nj HBvvH/JxbAAULSPRUC61K0exlO49VFbFETQNG1hZTKEji95fPbre7PpXQ0ewQShUgttEE/J3 UA4jYaF9lOcZgUzbA27xTV//KomP0D30yr4e4EJEJYYNKa3hofTEHDXeeNgM25tprhBUMdbV RZpf2Keuk2uDVwc+EiOVri48rb1NU+60sOXvoGO6Ks81+mhAGmrBrlgLhAp8K1HPHI4MG4gH nrMqX2rEGUGRPFjC3qqVVlPm8H05PnosNqDLQ1Pf7C0pVgsCx6hKQB7Y1qBui7aoj9zeFaQg pYef+CEERIKEcWwrjaOJwK3pi9HFdxS0NNWYZj8HPzz/AsgTTQdsbulPlVq2SsctmOnL42CZ OCTppGYwl53CG/EqVY+UQBzFzJBaY8TJRFFYVEy5/HH4H11rMoZwqIkk71EOGU3X6mWlANRi kR3M4GhVITRzuaV69Fed+OeXcCmP94ASLfuhBR2uynmcHpBKpwARAQABzTtOaWNrIENsaWZ0 b24gKENoaWVmIEJpbnV0aWxzIE1haW50YWluZXIpIDxuaWNrY0ByZWRoYXQuY29tPsLBeAQT AQIAIgUCWb/ZxQIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQE/zvid2ePE9cOxAA 3cX1bdDaTFttTqukdPXLCtD2aNwJos4vB4LYPSgugLkYaHIQH9d1NQPhS0TlUeovnFNESLaV soihv0YmBUCyL4jE52FRoTjE6fUhYkFNqIWN2HYwkVrSap2UUJFquRVoVbPkbSup8P+D8eyd BbdxsY6f+5E8Rtz5ibVnPZTib7CyqnFokJITWjzGdIP0Gn+JWVa6jtHTImWx1MtqiuVRDapU hrIoUIjf98HQn9/N5ylEFYQTw7tzaJNWeGUoGYS8+8n/0sNbuYQUU/zwMVY9wpJcrXaas6yZ XGpF/tua59t9LFCct+07YAUSWyaBXqBW3PKQz7QP+oE8yje91XrhOQam04eJhPIBLO88g6/U rdKaY7evBB8bJ76Zpn1yqsYOXwAxifD0gDcRTQcB2s5MYXYmizn2GoUm1MnCJeAfQCi/YMob R+c8xEEkRU83Tnnw3pmAbRU6OcPihEFuK/+SOMKIuV1QWmjkbAr4g9XeXvaN+TRJ9Hl/k1k/ sj+uOfyGIaFzM/fpaLmFk8vHeej4i2/C6cL4mnahwYBDHAfHO65ZUIBAssdA6AeJ+PGsYeYh qs6zkpaA2b0wT4f9s7BPSqi0Veky8bUYYY7WpjzDcHnj1gEeIU55EhOQ42dnEfv7WrIAXanO P8SjhgqAUkb3R88azZCpEMTHiCE4bFxzOmjOwU0EWb/ZxQEQALaJE/3u23rTvPLkitaTJFqK kwPVylzkwmKdvd2qeEFk1qys2J3tACTMyYVnYTSXy5EJH2zJyhUfLnhLp8jJZF4oU5QehOaJ PcMmzI/CZS1AmH+jnm6pukdZAowTzJyt4IKSapr+7mxcxX1YQ2XewMnFYpLkAA2dHaChLSU/ EHJXe3+O4DgEURTFMa3SRN/J4GNMBacKXnMSSYylI5DcIOZ/v0IGa5MAXHrP1Hwm1rBmloIc gmzexczBf+IcWgCLThyFPffv+2pfLK1XaS82OzBC7fS01pB/eDOkjQuKy16sKZX6Rt57vud4 0uE5a0lpyItC2P7u7QWL4yT5pMF+oS8bm3YWgEntV380RyZpqgJGZTZLNq2T4ZgfiaueEV4J zOnG2/QRGjOUrNQaYzKy5V127CTnRg4BYF/uLEmizLcI3O3U1+mEz6h48wkAojO1B6AZ8Lm+ JuxOW5ouGcrkTEuIG56GcDwMWS/Pw/vNsDyNmOCjy9eEKWJgmMmLaq59HpfTd8IOeaYyuAQH AsYt/zzKy0giMgjhCQtuc99E4nQE9KZ44DKsnqRabK9s3zYE3PIkCFIEZcUiJXSXWWOIdJ43 j+YyFHU5hqXfECM6rzKGBeBUGTzyWcOX6YwRM4LzQDVJwYG8cVfth+v4/ImcXR43D4WVxxBE AjKag02b+1yfABEBAAHCwV8EGAECAAkFAlm/2cUCGwwACgkQE/zvid2ePE/dqQ/6ApUwgsZz tps0MOdRddjPwz44pWXS5MG45irMQXELGQyxkrafc8lwHeABYstoK8dpopTcJGE3dZGL3JNz 1YWxQ5AV4uyqBn5N8RubcA8NzR6DQP+OGPIwzMketvVC/cbbKDZqf0uTDy3jP65OFhSkTEIy nYv1Mb4JJl3Sq+haUbfWLAV5nboSuHmiZE6Bz2+TjdoVkNwHBfpqxu6MlWka+P98SUcmY8iV hPy9QC1XFOGdFDFf1kYgHW27mFwds35NQhNARgftAVz9FZXruW6tFIIfisjr3rVjD9R8VgL7 l5vMr9ylOFpepnI6+wd2X1566HW7F1Zw1DIrY2NHL7kL5635bHrJY4n7o/n7Elk/Ca/MAqzd IZxz6orfXeImsqZ6ODn4Y47PToS3Tr3bMNN9N6tmOPQZkJGHDBExbhAi/Jp8fpWxMmpVCUl6 c85cOBCR4s8tZsvGYOjR3CvqKrX4bb8GElrhOvAJa6DdmZXc7AyoVMaTvhpq3gJYKmC64oqt 7zwIHwaCxTbP6C6oUp9ENRV7nHnXN3BlvIgCo4QEs6HkDzkmgYlCEOKBiDyVMSkPDZdsspa+ K4GlU2Swi/BDJMjtDxyo+K0M81LXXxOeRfEIfPtZ3ddxBKPva1uSsuz+pbN9d1JY8Ko5T/h1 6susi2ReUyNJEJaSnjO5z13TQ1U= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, I just one, very minor comment: > - int small; /* True if fits in 32 bits. */ > + int small; /* True if fits in 32 bits (64 bits with BFD64). */ I think that this should be: bool small; /* True if fits in 32 bits (64 bits with BFD64). */ It irks me when types are used incorrectly, and given that we have a boolean type, I feel that it should be used wherever it make sense. This is obviously not critical, so please feel free to ignore the suggestion if you do not agree with it. Cheers Nick