From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 23E753858D33 for ; Wed, 15 Mar 2023 11:08:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23E753858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678878516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8os3kfFZS3Ol5EY1NVIoWmQl0PhNulsR2hc2bW1OzEM=; b=T7/l4v3wZ643XBZiG4RjtEBX+nIQBsmJyLyqv9EcEQS6/kDGjg5NucobezyYvLp7E7GHiG PR517Kp//oXy+f0ABe/HRj8wehnTiFJSoiZO7FeoBLmtTjevtae56LkL1PBeGWC0mXlwYg pZj48rRNT1BFY8Mysl4/5ovcGt9oX3M= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-Y6aPSUNNN1mL-I6ZR3F6_Q-1; Wed, 15 Mar 2023 07:08:35 -0400 X-MC-Unique: Y6aPSUNNN1mL-I6ZR3F6_Q-1 Received: by mail-wr1-f71.google.com with SMTP id o15-20020a05600002cf00b002c54a27803cso3187164wry.22 for ; Wed, 15 Mar 2023 04:08:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678878514; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8os3kfFZS3Ol5EY1NVIoWmQl0PhNulsR2hc2bW1OzEM=; b=0yDInGsIgL82bWzyoG7KT/jdPwzUJl3SAPNGd7lpzFJfYxgt1Ikv+FUVMER3/LHiS1 2jGvnE7mTgCUy06BNWoiXMZ4Z41/AKgGGT0alA3lNxstWWsxEAoCfWOlWQIAOwgQoTU3 gFUPH45QjU1pPszEN7RAogsU+NKbSCjbqchbqEz1hhag5XyPwdZFCdifpihz/vTP5wUi efabWyfPMCiR24tOnRJJtHEhzicz16SPzPNqncGn2t7UHXHkWJJ1a5CQ0WAuVObJ+/TM wFVW28KkZDxvsjGQRn40Akaj4AUPn5SuYJQ/7EurMZrYT1Jlqu73fRipfz2tkvXRbSOM CKxA== X-Gm-Message-State: AO0yUKUlPU01El54LFC65Id3lMMnUrs7xmQ2apgYaH7JWmWtrdN2CtX9 a4JGMUNQKm30Tj8ZaUpogaZkaotyErS5WIScbUQVnPQbUshMiAEoZUG4h1EFc8xSdc/2WJk63zE /qsV/3vFpXUN7z97cUg== X-Received: by 2002:adf:cd0e:0:b0:2ce:a0c1:bcaa with SMTP id w14-20020adfcd0e000000b002cea0c1bcaamr1818152wrm.9.1678878513991; Wed, 15 Mar 2023 04:08:33 -0700 (PDT) X-Google-Smtp-Source: AK7set+So9+Kubmz1SIDcxQ4pwfrobEKiccQR0krBfEJJvfuMFI/itUjCVMGPxutpCBSa1snqTxJEw== X-Received: by 2002:adf:cd0e:0:b0:2ce:a0c1:bcaa with SMTP id w14-20020adfcd0e000000b002cea0c1bcaamr1818141wrm.9.1678878513672; Wed, 15 Mar 2023 04:08:33 -0700 (PDT) Received: from [192.168.1.7] ([79.123.86.193]) by smtp.gmail.com with ESMTPSA id j17-20020adfe511000000b002c707785da4sm4280086wrm.107.2023.03.15.04.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 04:08:33 -0700 (PDT) Message-ID: Date: Wed, 15 Mar 2023 11:08:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: Jan Beulich Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Binutils , Alan Modra References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> <9f769d26-f51c-4f85-f61b-330226c1cc2d@suse.com> <0a576110-624b-6339-b24d-907d6df72e09@suse.com> <67df1a4d-223f-2b4c-4957-394a299fb112@suse.com> From: Nick Clifton Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME In-Reply-To: <67df1a4d-223f-2b4c-4957-394a299fb112@suse.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > I wonder therefore whether S_IS_LOCAL() and S_IS_EXTERNAL() can't be made > true opposites of one another (with perhaps one of the two simply expanding > to a call to the other, inverting the result). I think that they are actually testing different things. The way I see it, S_IS_LOCAL() should return true for any symbol that is not intended to be seen by anyone disassembling the code. (Unless of course a command line has been used to change this behaviour). So for example labels like .L1 or ^B1. This does not however mean the same thing as ELF's STB_LOCAL binding. Local ELF symbols can be found in disassemblies, should be present in symbol tables, and represent something intelligible to the user, rather than something invented by the assembler. S_IS_EXTERNAL() on the other hand is meant to return true for symbols which are not only exposed to the disassembler, but which also have visibility outside of the file which is currently being assembled. ie in ELF terms symbols which have a binding other than STB_LOCAL. That is why, IMHO, the two functions are different. Cheers Nick