From: Nick Clifton <nickc@redhat.com>
To: Claudio Bantaloukas <claudio.bantaloukas@arm.com>,
binutils@sourceware.org
Cc: nd@arm.com
Subject: Re: [PATCH] arm: Fix MVE vmla encoding
Date: Tue, 23 Apr 2024 18:04:11 +0100 [thread overview]
Message-ID: <ac3a63da-6598-44e4-9d6d-6f787427c69b@redhat.com> (raw)
In-Reply-To: <20240415100020.497574-1-claudio.bantaloukas@arm.com>
Hi Claudio,
> Is this Ok for master? I do not have commit rights, if OK, can someone commit on my behalf please?
> Tested on arm-none-eabi.
Patch approved and applied. I did have to make one change however.
The patch, as it was, added a new failure to the gas testsuite
for PE based ARM targets (eg arm-wince-pe):
gas/testsuite/gas/arm/mve-vmla.s:20: Error: unknown pseudo-op: `.inst'>, no expected output
FAIL: MVE vmla instructions
The .inst pseudo-op is ELF specific, so that is why the failure was
happening. I choose the simplest solution of adding:
#target: [is_elf_format]
to the mve-vmla.d test control file. But you might prefer to make a
more complete solution by moving the .inst directive out of the mve-vmla.s
source file and into its own file...
Cheers
Nick
next prev parent reply other threads:[~2024-04-23 17:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 10:00 Claudio Bantaloukas
2024-04-23 17:04 ` Nick Clifton [this message]
2024-04-23 17:36 ` Claudio Bantaloukas
2024-04-24 10:47 ` Nick Clifton
2024-05-17 14:52 ` Richard Earnshaw (lists)
2024-05-17 14:31 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3a63da-6598-44e4-9d6d-6f787427c69b@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=claudio.bantaloukas@arm.com \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).