From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by sourceware.org (Postfix) with ESMTPS id C9F0F3858D1E for ; Tue, 29 Nov 2022 09:23:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C9F0F3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SNw59w0o+DoXHmhlWte9D6xM6A3C9hPCusNodfbjZUOg6fNBzJbRbAWvO9vhHsx7gHB63LLYd/eL0acSwKLBlQ31A+Uig5uo9hTFygUK7qurqEV49hcag/1E/RhZ86bObVZErxpXjO1pcrtd4RGGVJAZsh47pPVSzB6vp9PNnlBMlLdap7R5/h5ebkMeyWT5MuU7qyFCWo2lr9u6Rt60eoaNm+ooog0hIcV5K8a2NJhZHkBIqvmRvuU+/3O3JEb35crb1X+y8kcj4ogqFwetXH3/wBBhAKkNt7W2kq1IAGR5jcLXCRyrxvSnakWdqBfoEWu0roFq5z0C79EoluZDAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oxf3vR03dgVfnA/CBYS8Az5ccGKOHJIq0JbTh8llwZ4=; b=N3wwzNbU06/ENcmY/U3pyS/wbaN2i93Hli5YCyulCygUx2sGfYKgJS9uzbh1Mn3PQqqurZLOvIb03HqPBCeWHCWHe4SSu8GXBFiH3iQdm8V21ipUO8aK14oAMdzO+CjnPhXT9rhNgZFb8NJ6ffhL1WMDSkj1pxflMsbvkvMb4Hp1l5EHdJWI7dTRXFjtMSc9AiDkZrvSWj/sgYBkfksuLZCNhHumoYNB6E9mQFXXkjAZIo9i3KXaHR6iRt6Sbg4n2x/kG5lD/hH0yrudYaV0MBtnqYfgeKld769eq5oYCYXC0wndeTBBoru+HGWsiEdgQMq7e3r7OVTzZ2uTtmbhbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oxf3vR03dgVfnA/CBYS8Az5ccGKOHJIq0JbTh8llwZ4=; b=dPwVwk/eAMxnYjQLPSepShS1VaHp2SUPJ74Ndh/Wu1XwB0wFTJwlzilxXMxFnqrpMTaq4tPALIrxL16h8Dnwh1DknvUEiQ59Hb7UW5di4PTV0Jv06Y3NUI4+h3xOaIOQwF0XgV8YHv9VaPNFF+OVMpFqewuh8BMG6EHFyLx5Gq+ZY0JS+J1rA/Vam3XVbVYPSn63+pthVvlvaBPQzs+9WEyA9A6epu+zYN8iGi08gQdKlAKU9RB1QnVu5k3QRk11drQpN3LwZGdYT83zBOIDMGcmXgGi3tmliP0VJ6i+vraBAoe7AwiCq6upQCIwKwHsSXOs7L5ROnH7kMHiEohgBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8173.eurprd04.prod.outlook.com (2603:10a6:102:1ca::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.20; Tue, 29 Nov 2022 09:22:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 09:22:58 +0000 Message-ID: Date: Tue, 29 Nov 2022 10:22:56 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8173:EE_ X-MS-Office365-Filtering-Correlation-Id: b74fd5bd-cf5d-4c6a-e3d9-08dad1eb4de1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XTFDGysMUni52bLViKycb7xp7E4AZKrfhdHtPUXHxgKlguHOjPOaAyXdloeQOVJneRUe8RtQ/veregIHpUU9XgzrT26/JFG3u6KovL+PEVPrJC3mEEVpKy2Iu2TWA4qt8PUEfxL7ov1gUoII3Hioi5KsUSDXJsSs0J6TwsV1CQ/SuWXi5bN5o8h50a8U1agCv9E68Sv1gRrm5WQl6mjGRcTiQolIq35wj5f3QI95odX1ZLBJxFh9igwcD39J2+feSHsYVzavZlZXF3VU/27N/TWVG1lFNeRhCNxlFqdpXf2j9FuVzUTyjGN6v43m7+gE/Jz5WjJNCseZFGB8yBU18oCCdIRqj2yTDHF/cvCybraG5e2qmwWRgRs3FCo3YMN61VG097G9Rf/mVzEIOAzBTguMl2RyX0UbK2qgxa/8AAFx4Bay4Yru2rI1j89KJzVYjNbSspmAFBLnkHSEZxqgc8P7FZ3emhomTkCWvRYDukxZSBOqWNesTEsp79HtO9n0T26L3zcoDQPrDFQIXBcHPt3mDV/hsjFVxhshC2JfHBxoPTfd6Sc8/7X6eGeRjtMmqnR+xDel2zEGUjliLdK+w8AAzK+xSnCyQXx+eE+xj6Q30f0zhiUzGfUeJcdA8NPR2uJc2unIdDVBGtwTRymp/Gd7Y7eXofREuhGNJoB8Y273LhyCpkEkrrP8bcYIyeNlthBIicxeGfn/8HMArfz4kSPSbBLb/2/LA8er8VWwugI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199015)(36756003)(66556008)(6486002)(53546011)(26005)(6506007)(38100700002)(6512007)(478600001)(41300700001)(8676002)(66946007)(66476007)(86362001)(31696002)(4326008)(316002)(6916009)(5660300002)(8936002)(186003)(2616005)(31686004)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TU5BbWZCS3pUbVhLR0Fac2Fra0Q3Ynd2SVZFK2pUY1I5RG16eWsrNFBaSHJO?= =?utf-8?B?ZENNV3RmNGlnSW5PU1Q0dEZnazIzb3Y3UFhhRnhzOFBvK1I3cEduUFRoYmdV?= =?utf-8?B?VjJuZEE3ems4cTFZd0ZrWU5nUURmN0dnYVBoZHhyNVh2eXk1ejdTQUlqWWdB?= =?utf-8?B?c3pYbTFyL0FvalJReVYvajl5Z1hEbnBCcFZSV295RXZ2cXlRTXZJN054SVBG?= =?utf-8?B?VU1BWHZ3cC9DTng4ODdPNXZLOXg2S2dUNWczMjc3L2RIUGxhOVdna25uM3BZ?= =?utf-8?B?YWZ4d0x4eWpzREdjU1l1dDVueitNOFVGTEJtZGxKS3psMklTa3R0ZXN6NHRh?= =?utf-8?B?R2M1ZkhoRm5mRTBYT3J0OS95c2g4bWJuRXQ3b2dTSk5veEZLeEFyTHdnOXU1?= =?utf-8?B?Q2YyRXFlMS9QNU51THdyWFFIZHhadUQrbjhCSm5GdXN2YkhSZVhmbWcvMTdT?= =?utf-8?B?UmZ3UWVWeCtuVXNDbDQ3cVdtT2wza05JdE9XU2ZaaHlRVVc5b3QxNDUrZTIx?= =?utf-8?B?SWQvRXBQZ1d2M3NQUFZjcnVtaWQ1SUQ3RzRFUTNndXFQZmZFTndUZzgxSTl4?= =?utf-8?B?VXVEZWV0MUFqRkhnZ0h5Y0VjR05CVmNBS1dDSTF6K2J0SFEvUHZqamJwUitv?= =?utf-8?B?WjdDUU4vV0dTeHkvV0xVbisyT1V5T2tVZno3MjFhUnhPVTBOcVhnUks2OEZL?= =?utf-8?B?SmJ4TE5QQkVpM2RjSzIyMUVlbkJITUh4V00rWDFkamlpTDJBTVlPLzBrUmQx?= =?utf-8?B?Vy81RU44Tmo1VW0vbG40MVpqemJuRzcySGxpNURmbnROYVFlNWplcC9Iak9H?= =?utf-8?B?RnVsSmpKaitEc0h3dmRjaG01MGwrMkZydVE5dWt1T2szbGYxR2VHV1NMRm9S?= =?utf-8?B?RjBXdGxBWW92a1JLUjNlU3FtUy9IeTJlbTY3cXBMa3FrOFh3QnV3Uzhqei8r?= =?utf-8?B?SW44cDdkODVPSC9mYzZuTEdEZDlnZmlGYmtuQVdWYlpscmt1NUdxa25HTCsv?= =?utf-8?B?OFlKSUlmdzF5djZCWFBFNFpKazd5ZTJJMGpWUDgxK2pHekthR0ZaWHFyMlFx?= =?utf-8?B?V0RPKzhEVWJMMW1jNXBLYkVnbkdDekkwZ3QrWlo0ZER4bEp5UWd6aXVQNHBv?= =?utf-8?B?VUdvSC9zYSt4UWtrVExuM2NlZnAvMTFhcDNPaEp5MVZHSHpnYVhjVnBmV1J1?= =?utf-8?B?cDBFN0N6TG4vbnA3K0JuWjFmWkp3MTNJRWM5M21ybUlkYlIvMCtLVkxrM0Fw?= =?utf-8?B?RlhVRGdhWHdUY1QrNnF6Wk5pcDM3L1p2NXlJZzRxR2xJeXpMdEFxemsxbUw2?= =?utf-8?B?SWExYlA1S1VoeDRJNlhZSmhZQ2xnZXlFYTRLNUNEeDljb1ZpbGdhWEEwa2NX?= =?utf-8?B?SlYyeVBBRFFBWW13L0ZGMmdlSTFoSW42Yzg5akJYcE01NGsweFZCTUFtMTJ4?= =?utf-8?B?QTZlM1VGVlRHeTlxSFowUHI2WFRnVmtWcE9OYnBkYVh2c05uSlc2bElxSnlw?= =?utf-8?B?NU5tZy8wY1h6d1MyLzQrRUdzRkZsTWRNTU41bkowbWp4bUNmZDljN1B3dkpP?= =?utf-8?B?OWY0NkZEQ3ozUzBnZUtEVzMzeTRUcXBOUnRFSXlsM3lzVURLQkJJL0xJR3Ra?= =?utf-8?B?OGtuMTdFV2pDUHlPU2VockNmcWJKMU4vRHN5SnBHUkJqVnVOZ2hLYU1TWmVp?= =?utf-8?B?dEROSVgyU0ZGamx2NGFDc3pJVUVKMmFEd2dQaXVvL3cxckpxZGFWQlFVdXB2?= =?utf-8?B?Ukp4RUk1SjRCVUlNVEg5WlIydy9IWktPOFdBWlduOFZwUG0rb1NaWERodklB?= =?utf-8?B?OExyRnd1SVBvWDRVQ0IzRjVlSGloenE5YU4yVlhJTW1wckdJbVVzbVJ2QXov?= =?utf-8?B?QUMxNkRkN2RyVmtnc25YZ0JucUVmeUJCM3hudmhtTUdOdVM5TU5qMEthTmF0?= =?utf-8?B?K29JNnE0V0o0T1dVSnY5azdMR0NSRlhkaWVzNlg2cEFxMUdoVnZrc29Mazlt?= =?utf-8?B?azdwYzlXcDZFU2pxZWtDR3lJSFJreFFqSWxycmw3YmE1WFV0V1FMbEpiL1pQ?= =?utf-8?B?eURUY3VFTGF4Y0JodU1lUjVWYnBNVWk3MG9XN0lYblBWdjBJcTZTbzZSanhV?= =?utf-8?Q?Bs0adisIxlZCwd8GgQN/gZLNv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b74fd5bd-cf5d-4c6a-e3d9-08dad1eb4de1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 09:22:58.1609 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iFEaCP8faslvrm2A0LQouyJhmUESVWSK+U+qewZ51gIfB2vfO1Y4UqBj6hY2bgRc+kswgljhREfCSL506Jn7OA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8173 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.11.2022 00:49, H.J. Lu wrote: > On Thu, Nov 24, 2022 at 2:19 AM Jan Beulich wrote: >> On 22.11.2022 19:19, H.J. Lu wrote: >>> --- a/gas/Makefile.am >>> +++ b/gas/Makefile.am >>> @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh >>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ >>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ >>> >>> +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ >>> + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ >>> + $(srcdir)/../opcodes/i386-reg.tbl \ >>> + $(srcdir)/../opcodes/i386-opc.h >>> + cd ../opcodes; make gen-i386-tbl >> >> I've made a patch to gas/Makefile.am as you have requested in reply to >> my series. I will want to put that through some more testing, so I will >> submit a v3 of that only a little later (and of course only unless you >> submit a v2 of your patch earlier that I would also end up being okay >> with). In the course of doing so I noticed a few more issues with your >> change: >> >> For one I don't think you can put @MAINT@ on a continued line, as the >> line continuation might then be hidden when @MAINT@ expands to #. The >> list of dependencies wants expressing via a variable, which would then >> be used immediately after @MAINT@ without any line continuation >> following. > > Fixed. No, the same problem is still there. You either need to use a very long line, or you need to introduce a variable holding the list of prereqs, like I've done in my series. >> And then your rule / dependency won't be enough on a "maintainer-clean" >> tree, i.e. when the generated headers aren't there at all, and when >> config/.deps/tc-i386.Po is still empty. In that case nothing would >> trigger their generation; an explicit dependency of config/tc-i386.o on >> these headers needs adding here. > > Fixed. > >> Finally you're missing a dependency of the generated headers on >> i386-gen.c. > > They have a dependency on i386-gen which depends on i386-gen.c. In opcodes/, yes, but talk was about the rule in gas/. Yet despite your comment above I see that you've added the missing dependency. > Here is the v2 patch. As said in reply to v1 - my objection to this particular use of make recursion remains. I also continue to be irritated by you specifically having asked me to further split my series, when you do everything in a single patch. One further request at least for consideration: In my v3 I've moved the inclusion of opcodes/i386-tbl.h quite a bit further down in tc-i386.c, as I think it's preferable that way (not introducing the static arrays earlier than necessary). Jan