From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 80181385B515 for ; Thu, 16 Nov 2023 14:16:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 80181385B515 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 80181385B515 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700144187; cv=none; b=VQURvNtnWcstrevF8EXASIEnI3SURcMBuN1t+9hgSVBEAvdXfVHjwXKncbT2TJb5Ga9jgNNvD6KMek1pdUt6L7yPKW8DKp0x0CZZ9sNl7GZ++LwX5DRWCKSiS8NX5CPJYemMUYWJUxx9Yu6lMG2IOzQjFSsXfLrqi4h+HamXir4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700144187; c=relaxed/simple; bh=+y7Z4Wjai+1L13pLWL/8iGWqm1ySawebA4lE4gjtko4=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=daZBFAJ3ANEe0ha4eZVEGKqPS4T/+exSh1o04XTft3mB31dppX8Dq3D/pyUQ0wgTwx6vOKrXXXEo92xqnRdeNV2iO70HTLevyfpfChGvdVh6F8gkUATXoTh6GSM7/uFpGLp6Mv3nx3xQXYUd40sOUZTQu2ycFOzG3VQmJtIGXP8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6131E1595; Thu, 16 Nov 2023 06:17:12 -0800 (PST) Received: from [10.57.41.187] (unknown [10.57.41.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 701743F73F; Thu, 16 Nov 2023 06:16:25 -0800 (PST) Message-ID: Date: Thu, 16 Nov 2023 14:16:24 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5][BINUTILS] aarch64: Add support for VMSA feature enhancements. Content-Language: en-GB To: Srinath Parvathaneni , binutils@sourceware.org Cc: Richard Earnshaw , nickc@redhat.com References: <8e6b9010-5a62-e00f-9afe-d86474343a2e@arm.com> <8dcf129a-88c8-198a-adbb-4da2e6403063@arm.com> <122e823d-6989-4b1e-bfa1-ce8b9a6de2cc@arm.com> <82c92cc2-bdb2-487c-b50f-05ec88f861d7@arm.com> <94805bd5-a22c-4285-a068-8ce701880af6@arm.com> From: Richard Earnshaw In-Reply-To: <94805bd5-a22c-4285-a068-8ce701880af6@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3489.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/11/2023 11:39, Srinath Parvathaneni wrote: > Hi, > > This patch adds the permission model enhancement and memory > attribute index enhancement features and their corresponding > system registers in AArch64 assembler. > Permission Indirection Extension (FEAT_S1PIE, FEAT_S2PIE) > Permission Overlay Extension (FEAT_S1POE, FEAT_S2POE) > Memory Attribute Index Enhancement (FEAT_AIE) > Extension to Translation Control Registers (FEAT_TCR2) > > These features are available by default from Armv9.4-A architecture. > > Regression tested for aarch64-none-elf target and found > no regressions. > > Ok for binutils-master? > > Regards, > Srinath. @@ -248,7 +260,13 @@ enum aarch64_feature_bit { | AARCH64_FEATBIT (X, SCTLR2) \ | AARCH64_FEATBIT (X, FGT2) \ | AARCH64_FEATBIT (X, PFAR) \ - | AARCH64_FEATBIT (X, ATS1A)) + | AARCH64_FEATBIT (X, ATS1A) \ + | AARCH64_FEATBIT (X, AIE) \ + | AARCH64_FEATBIT (X, S1PIE) \ + | AARCH64_FEATBIT (X, S2PIE) \ + | AARCH64_FEATBIT (X, S1POE) \ + | AARCH64_FEATBIT (X, S2POE) \ + | AARCH64_FEATBIT (X, TCR2)) Hmm, it's this one where the change I suggested on patch 4 really needs doing so that next time we win. Otherwise OK. R.