From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BB739385803F for ; Mon, 15 Aug 2022 12:04:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB739385803F Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-557-7nGIBUwGPlG1DJuSCrkVeQ-1; Mon, 15 Aug 2022 08:04:49 -0400 X-MC-Unique: 7nGIBUwGPlG1DJuSCrkVeQ-1 Received: by mail-wm1-f69.google.com with SMTP id j22-20020a05600c485600b003a5e4420552so3176698wmo.8 for ; Mon, 15 Aug 2022 05:04:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=EC/fEUCaY7JbR80/9/to3EibNj0yCrgMfPEq0dWc+nM=; b=fI9OyvHfJrSozHqVbTyyKidXHRTYYH8w4c1oGzNFDnE5KUxbCERp+VxiBPzNLv0oyw OuNbO757ATvOQdQhtjtwm+N1vmPxMB56d66OYRpHIASUBQw8THmCanp1o6HWXWtPJFG4 fALrn71AoeEC3Cnuvx3sSZq/hlpSI7r3jlcJ/eRqO7qQWsq0+peyyBL3tOnxYJvrjToZ F8DyXWqh+ioSODdSgs1P/5foBygWD90MaPNu8K9Kl8kOjf/t12AiUyleRlHas97Lq8rp buT9Tz5iTbY3yH7IzuUL76AHKHikO5ElFAHytYooRaLsxATsrocjw0DePVZnHXFzkOV4 lrHw== X-Gm-Message-State: ACgBeo05MBPYf9EIuA//xSOULoRjVuQ1j4ZKOOM4Um78DeIM/vMKxesC 90DOycuCPoirXkS464gurMjviO9dfI7/0LhfrGKjGwoQ+kB0o0KHxDFFRu0IEZd6cHlDHb5+gGd LLftWn/EBWa/S/g4S3w== X-Received: by 2002:adf:d4c2:0:b0:21e:ddf3:8b14 with SMTP id w2-20020adfd4c2000000b0021eddf38b14mr8884420wrk.355.1660565088099; Mon, 15 Aug 2022 05:04:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR4hUi93laCx6dlABaVJd8TCf9+L6pM65WUSgTfAPnrxUPTujrKQm/S02ynpSz0tk7NCjxaCGQ== X-Received: by 2002:adf:d4c2:0:b0:21e:ddf3:8b14 with SMTP id w2-20020adfd4c2000000b0021eddf38b14mr8884413wrk.355.1660565087912; Mon, 15 Aug 2022 05:04:47 -0700 (PDT) Received: from [192.168.1.6] (adsl-2-solo-236-177.claranet.co.uk. [80.168.236.177]) by smtp.gmail.com with ESMTPSA id b3-20020a05600010c300b002217339ce90sm7265610wrx.8.2022.08.15.05.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 05:04:47 -0700 (PDT) Message-ID: Date: Mon, 15 Aug 2022 13:04:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH,V6 01/10] ctf-frame.h: Add CTF Frame format definition To: Indu Bhagat , binutils@sourceware.org References: <20220802080452.1143351-1-indu.bhagat@oracle.com> <20220802080452.1143351-2-indu.bhagat@oracle.com> From: Nick Clifton In-Reply-To: <20220802080452.1143351-2-indu.bhagat@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Aug 2022 12:04:54 -0000 Hi Indu, [Sorry for the delay in reviewing these patches]. > + uint8_t ctfp_flags; /* Flags. */ > +} __attribute__ ((packed)) ctf_frame_preamble; I would suggest using the ATTRIBUTE_PACKED define here (from ansidecl.h) so that the header can be compiled with non-gcc compilers if necessary. (And likewise for the other uses of __attribute__((packed)) in ctf-frame.h). Cheers Nick