Re: [PATCH v1 0/7][Binutils] aarch64: Add support for FEAT_SME_F16F16 feature and instructions.

[Jan Beulich <jbeulich@suse.com>]

On 16.08.2024 18:50, Andrew Carlotti wrote:
> On Fri, Aug 16, 2024 at 05:38:59PM +0100, Andrew Carlotti wrote:
>> On Fri, Jul 12, 2024 at 05:35:30PM +0100, Srinath Parvathaneni wrote:
>>> Hi,
>>>
>>> This patch series adds the support for aarch64 FEAT_SME_F16F16 feature
>>> and all the instructions by "+sme-f16f16" flag to -march and the spec
>>> can be found here [1].
>>>
>>> Srinath Parvathaneni (7):
>>>   aarch64: Add support for FEAT_SME_F16F16 feature.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmops and fmopa instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmopa and fmops instructions
>>>     (regenerated files).
>>>   aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions
>>>     (regenerated files).
>>>   aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions
>>>     (regenerated files).
>>>
>>> Regression testing for aarch64-none-elf target and found no regressions.
>>>
>>> Ok for binutils-master?
>>>
>>> [1]: https://developer.arm.com/documentation/ddi0602/2024-06/SME-Instructions?lang=en
>>>
>>> Regards,
>>> Srinath.
>>
>> There's a couple of test gaps I've mention in reply to patch 4/7, but this
>> otherwise looks good to me (though I can't formally approve it).
> 
> Actually, you should also add here the whitespace parsing changes that Jan
> requested elsewhere, in line with his patch [2] for existing tests.
> Specifically, I think this entails adding ` ?` to the vector lists in your
> error tests - e.g. `{z0\.h-z3\.h}` -> `{ ?z0\.h-z3\.h ?}`.

Right. Fundamentally the (not really new) rule is "A single space ought to
be allowed for in all places where the source has any form of whitespace."

Jan