public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Carlotti <andrew.carlotti@arm.com>,
	Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Cc: binutils@sourceware.org, richard.earnshaw@arm.com, nickc@redhat.com
Subject: Re: [PATCH v1 0/7][Binutils] aarch64: Add support for FEAT_SME_F16F16 feature and instructions.
Date: Mon, 19 Aug 2024 09:41:39 +0200	[thread overview]
Message-ID: <ad5f3f35-5a8d-4dfa-9591-235b785064d8@suse.com> (raw)
In-Reply-To: <88b154d2-b714-c460-8501-2e52aaaf41c8@e124511.cambridge.arm.com>

On 16.08.2024 18:50, Andrew Carlotti wrote:
> On Fri, Aug 16, 2024 at 05:38:59PM +0100, Andrew Carlotti wrote:
>> On Fri, Jul 12, 2024 at 05:35:30PM +0100, Srinath Parvathaneni wrote:
>>> Hi,
>>>
>>> This patch series adds the support for aarch64 FEAT_SME_F16F16 feature
>>> and all the instructions by "+sme-f16f16" flag to -march and the spec
>>> can be found here [1].
>>>
>>> Srinath Parvathaneni (7):
>>>   aarch64: Add support for FEAT_SME_F16F16 feature.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmops and fmopa instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmopa and fmops instructions
>>>     (regenerated files).
>>>   aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions
>>>     (regenerated files).
>>>   aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions.
>>>   aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions
>>>     (regenerated files).
>>>
>>> Regression testing for aarch64-none-elf target and found no regressions.
>>>
>>> Ok for binutils-master?
>>>
>>> [1]: https://developer.arm.com/documentation/ddi0602/2024-06/SME-Instructions?lang=en
>>>
>>> Regards,
>>> Srinath.
>>
>> There's a couple of test gaps I've mention in reply to patch 4/7, but this
>> otherwise looks good to me (though I can't formally approve it).
> 
> Actually, you should also add here the whitespace parsing changes that Jan
> requested elsewhere, in line with his patch [2] for existing tests.
> Specifically, I think this entails adding ` ?` to the vector lists in your
> error tests - e.g. `{z0\.h-z3\.h}` -> `{ ?z0\.h-z3\.h ?}`.

Right. Fundamentally the (not really new) rule is "A single space ought to
be allowed for in all places where the source has any form of whitespace."

Jan

      reply	other threads:[~2024-08-19  7:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 16:35 Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 1/7] aarch64: Add support for FEAT_SME_F16F16 feature Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 2/7] aarch64: Add support for FEAT_SME_F16F16 fmops and fmopa instructions Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 3/7] aarch64: Add support for FEAT_SME_F16F16 fmopa and fmops instructions (regenerated files) Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 4/7] aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions Srinath Parvathaneni
2024-08-16 16:20   ` Andrew Carlotti
2024-07-12 16:35 ` [PATCH v1 5/7] aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions (regenerated files) Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 6/7] aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions Srinath Parvathaneni
2024-07-12 16:35 ` [PATCH v1 7/7] aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions (regenerated files) Srinath Parvathaneni
2024-08-16 16:38 ` [PATCH v1 0/7][Binutils] aarch64: Add support for FEAT_SME_F16F16 feature and instructions Andrew Carlotti
2024-08-16 16:50   ` Andrew Carlotti
2024-08-19  7:41     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad5f3f35-5a8d-4dfa-9591-235b785064d8@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.carlotti@arm.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=richard.earnshaw@arm.com \
    --cc=srinath.parvathaneni@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).