From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 0ED543864810 for ; Mon, 19 Aug 2024 07:41:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0ED543864810 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0ED543864810 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724053304; cv=none; b=PNPvtWle/p8FYFFqyn/60IWmvJpYARXX5sZiOD/cUWr7C/I+tdQqcBZ8S8nHWRUjvUVIsVZ1O+XGuRp/4mznFjLNWORTxLAiNnfGlzOAhAEn0Pchgl+0j2POnUfYBuE6JrX0/+HbUNVZ6RaPP7REG5ggj/VKlXfS45WhW3B8Ins= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724053304; c=relaxed/simple; bh=/ftHnEo3mJ14Drvf0j+j5ztjviZF2rgzDong7AR1mt4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eCUuFBt6xr9pv1jIaFC3whfidvKevsqqPV9NLO143MUlRIQdJUxRq1tdf9K5cpEQPgPb8qwhPjB6ROK1du/EB5AOUDjiTsx15O9D/JPQDlt4wmQUN1XZcWugyHkGmawn0DTndnZoGcoZTugVMhz2aqRCXbe5lx3+jUvKeyl4esE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a7aabb71bb2so435412866b.2 for ; Mon, 19 Aug 2024 00:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724053302; x=1724658102; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=oHesFo5U4NYsNduYLYHpk6L+M23DqBcNKLoZS+CbYVU=; b=JklLATehwUbx/MFK1MsvGfRam7kYelDbJFSdXvRGevoPBmorqOi5bsqkXtChepMJSZ f4jL6k36tUGRz/HnqNdUw2Wu5qtl3d/t+0Oc2K2TucXP2zYjqV1naqMISm4ifs4gaUrY CwTLfjYQ6Hqq6ZrRmRoiB6eC2jMCIm0EYOhDIgdmtAGyBlQoZ7p46HptnY1+YTUd11lJ mydq26Y6MdT6rYqs4vbv+kkp1ved16XAnkCHTuPbEppVelRYr9ppW5CYgErzD3/Gp+E4 yIMnEtWdc8TmwMurHPByjyNYzz3Pm2F+bATE0hlJsqQLsMBnuWF46tztw2z/JpB3thHC RfXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724053302; x=1724658102; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oHesFo5U4NYsNduYLYHpk6L+M23DqBcNKLoZS+CbYVU=; b=HM7X7w9iPbGRVj6MOwjvLZzkxdfdy+W4ARIBc7ONZNhfMJvQJriPp8o6hGLdslVTfE NzcTFnh3lKXCLWw+xpWIcBJyWxXE4z6U2TROTAhJgvCrpxNNi5zppmU/XXY3vXbK2f8R E6eaQCsmL7jUP8KGwX9gxg8S5EhI7SRwpGdn6KFXrmOVol1Ptbp0RTIWOAHtFlv44sJB TnwTqeSiF+vJmmZnZlofJmuAOpvndlNC+SjtSAtiJdYHK7pw9d2TWzl7b1c5Fc7ad7oG Qzuqz1BHcR8EQNZJDfDkoBWmg24BjexbVuZQncMQ4GPXpSvmhV3CPi+i5YlXu+Z7gK3k wm1g== X-Gm-Message-State: AOJu0Yx0IdbjhiDLwy1QhZ4kPMQbUTSCtPfBp2niCO5F8ZaYhZWZ1k/m Z4rtVP2pHsnTS1p9zJkkUJlUFp22YEnEaWo2NGiNg5gGCNieHSfBPINiHXzEHQ== X-Google-Smtp-Source: AGHT+IGIE+DE4tWVN/2p1WPgWbNpUfrzjk5vVsIBefRhOAEeU3YKZKb0TlJwbX8cRUf6LsKaL3B0ZA== X-Received: by 2002:a17:907:e290:b0:a7d:ea36:b294 with SMTP id a640c23a62f3a-a8392933049mr712493966b.26.1724053301538; Mon, 19 Aug 2024 00:41:41 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838cfe70sm597949566b.75.2024.08.19.00.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 00:41:41 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 09:41:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/7][Binutils] aarch64: Add support for FEAT_SME_F16F16 feature and instructions. To: Andrew Carlotti , Srinath Parvathaneni Cc: binutils@sourceware.org, richard.earnshaw@arm.com, nickc@redhat.com References: <20240712163537.1768993-1-srinath.parvathaneni@arm.com> <0a58c948-af02-67fe-05ad-128549ab7ba4@e124511.cambridge.arm.com> <88b154d2-b714-c460-8501-2e52aaaf41c8@e124511.cambridge.arm.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <88b154d2-b714-c460-8501-2e52aaaf41c8@e124511.cambridge.arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16.08.2024 18:50, Andrew Carlotti wrote: > On Fri, Aug 16, 2024 at 05:38:59PM +0100, Andrew Carlotti wrote: >> On Fri, Jul 12, 2024 at 05:35:30PM +0100, Srinath Parvathaneni wrote: >>> Hi, >>> >>> This patch series adds the support for aarch64 FEAT_SME_F16F16 feature >>> and all the instructions by "+sme-f16f16" flag to -march and the spec >>> can be found here [1]. >>> >>> Srinath Parvathaneni (7): >>> aarch64: Add support for FEAT_SME_F16F16 feature. >>> aarch64: Add support for FEAT_SME_F16F16 fmops and fmopa instructions. >>> aarch64: Add support for FEAT_SME_F16F16 fmopa and fmops instructions >>> (regenerated files). >>> aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions. >>> aarch64: Add support for FEAT_SME_F16F16 fmla and fmls instructions >>> (regenerated files). >>> aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions. >>> aarch64: Add support for FEAT_SME_F16F16 fcvt and fcvtl instructions >>> (regenerated files). >>> >>> Regression testing for aarch64-none-elf target and found no regressions. >>> >>> Ok for binutils-master? >>> >>> [1]: https://developer.arm.com/documentation/ddi0602/2024-06/SME-Instructions?lang=en >>> >>> Regards, >>> Srinath. >> >> There's a couple of test gaps I've mention in reply to patch 4/7, but this >> otherwise looks good to me (though I can't formally approve it). > > Actually, you should also add here the whitespace parsing changes that Jan > requested elsewhere, in line with his patch [2] for existing tests. > Specifically, I think this entails adding ` ?` to the vector lists in your > error tests - e.g. `{z0\.h-z3\.h}` -> `{ ?z0\.h-z3\.h ?}`. Right. Fundamentally the (not really new) rule is "A single space ought to be allowed for in all places where the source has any form of whitespace." Jan