From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2042.outbound.protection.outlook.com [40.107.8.42]) by sourceware.org (Postfix) with ESMTPS id 82FBB3858CD1 for ; Wed, 22 Nov 2023 08:48:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82FBB3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82FBB3858CD1 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.8.42 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700642883; cv=pass; b=RL6O/855R9Yef+xJ7Pg8dBSfSN7KvybwY+LVoVMwk6enJsZSu/0kA16S1h6+5SvyUQt+UGagmN7lhF3QRfn5PpvUE3SmnLl3uKNGQdBKDcnm2g9Y+x/2Y80e9CZERWC4ps0v5wwNhIVzXyRStG9Esh4NLyLVbNSVvHPIkpOiU2g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1700642883; c=relaxed/simple; bh=PgIXk9foUVhg7XWyX0HUiDiCco6vcXtTICEKMQFQR8E=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=x2LBM0haKDJjgkv7dN807BZu6E5DjHfnmjZq2UBEQUhacT+oye+q+C8qUPiN4Arr20LYxhxAwcKExxWzaS9hWN71GwDibQrU1vivi0eMcZeLO9/HgOqp+4ji3oH9x+QPykDV48TG877fULgn3w6MjN9f81TAf47dBZvpptX2o+c= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEQd0OGzewufJ+BbRkegyNz2DHY8m1PkZnkLOqsmZBs/n0izn+DhlmsmCk8DCwItizTAI6VScanlawzwzl7JarvahRCqp4A0bVYlmx99a5tsNBv3U/4qrZZWv5RF71iUOtcjaXCDSVXuDYULvT5TSybpXoJIYRYGiIEpX67PDgG2UqKKf8KPyUCZxiP56SMox+p5k0g+WRoxd8BDVKDWCGfwinwWIUUugUBGSlwgXuOLS9oKEeKTNNnE6t6OOJKRqjUgeAESdeTS4WSCY3yTxoe8I91t0wZWvDu9wf8I37+1sqQmxTZwfpYSJQia9p2YdJNOZVHZIj4PCuypBnSDbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDeEpnow4fkablrC620bFuSr7rZi5E270meLl+LbRM4=; b=i53ODUncXsHhpy0HGb7KQtw1MmuplF9wRZimr98WyX4z1lpovmy/kzdvNSn54HRSHAaHXAY2rprJ/51fTe7JlpvQznLTHKzgPA2K9QPcK3Yj1vcZqlqnoMW1JSZJcYRNWp7eL/nqX8EIJ8lUPvEBEWluMoe6IaMWCIjbXoAuWTFcLh0PbMc4WfadOtm6nE/DhpN2+CZloiJE1tvNQRweVz/AC3IjSmkrFalBDLzjD0EUiMYf0XbiZLI+ZpSNfu548kRGq3Div2SXap/LtmAJpxloS77nc205Ddv2T+m5m8V3Wew+7+GR9jigULngKuny2yHpu1l2rPXfjZ9fHo5rWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDeEpnow4fkablrC620bFuSr7rZi5E270meLl+LbRM4=; b=XP7J6Kn0NBE0dQc1nCt5MWcXKg3f0fcwlwoDx2iFSi/DCnWcWJIhCS9GPX3YsoFrGxEA8nRq5x9jYWw9BIRS1EmHfi4LH4mMBtU1sWlaYv4EQb3uGApgtldNlcDNJRke/yf/W/ctYS4GWIfE5GzYJKxAHt1SnMiJSav/Sk9b3Dk/d6wBtxoVHWStr6WXfgKjxn3jv370ayttWXPejUJi63xpe3HEKom8IeCyLh8EG2wi9+sjYRR5EwmdUkoCML3Q+bgDKeE5m71XXFcNphB22vnv5n8wYd2HlgbnkVCxSXcRY/QZewx2K9/LqApEehJCt68fXrqeGBR19CTTNzf4DA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by AM9PR04MB8084.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Wed, 22 Nov 2023 08:47:58 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.7025.019; Wed, 22 Nov 2023 08:47:58 +0000 Message-ID: Date: Wed, 22 Nov 2023 09:47:57 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] Support APX NDD Content-Language: en-US To: "Cui, Lili" Cc: "Lu, Hongjiu" , "ccoutant@gmail.com" , "binutils@sourceware.org" , "Kong, Lingling" References: <20231102112911.2372810-1-lili.cui@intel.com> <20231102112911.2372810-6-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::10) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|AM9PR04MB8084:EE_ X-MS-Office365-Filtering-Correlation-Id: 04196880-a72f-45b9-7983-08dbeb37ba45 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gHWpgu1//FNreISoJkOQJPRFNRt2SFQA1wvfJgqEdqiNW02AAKLicPgHsVVLcqJiGz6iD20vLBNrm0oHSuxvonqkgQ8y1Kx7vj/W8nqFNchOqjuNwvI3BhGUNygcDeniTrJJVCBR+WpzYgnNN3c/vj/hW1GPFQlpZaSO60tz/7QHPrlQEnXLeDVdFv8Avow2K9jOo9HXa5WsUp3ICrahHSvdYzziP1N9pNNjM/8zuB2ZJoKSD3kMQdXecjqmUcOhhBXunXrX5YAlBmvUu7Ekm1vhy2Tpe7PNh9mKZm/l+WgPj4CnsVwPe/3KkBN6mBR1WueM3oLVVZQRABTnvUPLIRBuvZHpZEhJtOh7RxR2cOOdi5eYzzQivezJGA715pLEZogDoHklCF9cex2AaFAaxmYHXiakEpSJFKzOs46PLjPGMjbZfQRg8hxKE1b9a8FivbNp6AHU8LO4zNC3P9UMdeD1ULtXcwJarp+krVLZnOP74o538mgiPaeZxv80Ax+6GYVp4GggReIWHNRI8AiYtS/10K89adv5B6Wb4bV7ehPkiAifN1u4gelauf1o3VbexgeJxknmFdGNrYbLZPkIJP/OGp+KlGRMcKpzd3QfjgJjNhoBKiVYcNm6XqcIYqVcVd9s+w9GZp+RRg8ZPqCE5A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(376002)(346002)(136003)(366004)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799012)(36756003)(31696002)(86362001)(6512007)(2616005)(6506007)(4326008)(8936002)(8676002)(53546011)(26005)(5660300002)(2906002)(66946007)(6916009)(316002)(4744005)(66476007)(66556008)(54906003)(6486002)(478600001)(31686004)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHhzRDRKWFhqMEJzcVNEK0ZoK3JTUUJ1WlR0VGZlSnBLM05GcVdaR01sWnhC?= =?utf-8?B?ckNuLzVQYUJLQ25GYmV6QWprWTRnQlh2SC94b3F2NjgzcEsyVit3ekY2S1Bx?= =?utf-8?B?T21SODJFUWdheGJmRXpmRmJjbm0vNFFhclk0K0QxRnNIR0FkZ3ZFd3ZwWEww?= =?utf-8?B?dE5IeExlNldWbzlrczNyOXhNT2g1K2ppRmhoQWt4NG1nc01GSlhOV1A1MzJU?= =?utf-8?B?ZUFVOE03MjZpKzhlWEVMSkFmL0JWcXVyMUZBUm1zNHZJZW9PdVlHL3hrL3pB?= =?utf-8?B?MnlvOWJpaUh1aThlSENuSHpZaFhIdHU2MnpUd1VvZU0xeXlRS2RJNEI0ZXBC?= =?utf-8?B?Yytuc2VneVZRTmZ3ekFkOEpZQjIreGlLWXJZWVJQRUhFTjN1dC8zQ1NGSHo5?= =?utf-8?B?UlZ5V1NrOFA4d0RmaktRaW1BTFR4SWkyeElLN2daWFdIUEpUV1A3SFJmczNi?= =?utf-8?B?VDUrS0JibnFOVFUrcFhlcUl5OWdzQ0JIRHE5OEhWTWV0R3BERmF3TVBEczB6?= =?utf-8?B?TU5JMUdmcXdEb3ByOWUwd3pOeUpVWU4zdTh5TnFlZ1ZwVWJIVlBqUGpta0dY?= =?utf-8?B?NmJCNWtheGppWWJYYmlNaS8xd0djYVIwdTd2bHFGTTRLc1ZHd3d5eHpHanVH?= =?utf-8?B?b3NXQ2xYUnpxcUYrRFlrdEQvNTJRZnJYV0N2b1RhdElPMU9WS2RncWgyVHN6?= =?utf-8?B?czlhV1dkWlVYdlV0NHVYVlJTZTg1NlA2TGVzTWI5QTAvZURreEFzcjNnTmVp?= =?utf-8?B?RU0zUW1zYTFPUURlZnVsOENaVmlYT1lKdGgwbitoOXFPOUt1YWtNR2NFNFBk?= =?utf-8?B?cU5QTytvc0Q0V2QvMDRJY2EralE4MVRnSm9ISkhVTTY3ZUtMdTB5eUNhZ0pH?= =?utf-8?B?ZllTcUlTZlZ6RWVMYXpBZWZCZkRqN1FUVFAzU3pnVGZONFJMNTQrc3FhYkFi?= =?utf-8?B?aURiUUpVdityVjdXeXpwSkhtNXM3eE92a0NOUm1RQTY3dEFlRmhXeTUrTHpU?= =?utf-8?B?TkZqZThhUVE3UEJwRHNmTEZ2WmRPbVQ0Tk56MVlXTmlISXMxVWJzTUx5RmtR?= =?utf-8?B?OUdIQjFTR3pzT3BNaWc3cVRpTGgzNVBsQmNPcE0vcXB6d1ZQNVBnd3ZuNGpO?= =?utf-8?B?dUEwSXdyWjgxUDdWNktoY2JtSFV0NytzZE5XZTAremcrMzFmOFQ4NkJmcnB0?= =?utf-8?B?UmxxZVUweFJyNk9VYnJ6eTRvaHZDVTBGVzFvSVliN3dPUE5NME43T1BQcUpK?= =?utf-8?B?cHVBcEUvWWZvdkwzaUJ3MlhycWJ6OFk5eFpyOEowMlkxUTVQTWxIN0lSd1lG?= =?utf-8?B?OGpnbDBkeEloRXhiNXc0NXFYbkxqR0VQRFRXN09aaXBrSElHRi8wQU13c1Jn?= =?utf-8?B?V3poMGhpMmV6OVMvaDBoSElXblBGOVExRk5VR0RGNStQN2ZtYTJRZHNaYWxY?= =?utf-8?B?bXoyc2NqTWRBN2lxbk5wTnJFUk55Tk03SFVuaVErZzU1NUdMMlkzanZBOFZp?= =?utf-8?B?T040OTNmakZacWlKRExxOHBXR1ZzeEdEN2g2allETzE0VndqVmNRSEJGbVJF?= =?utf-8?B?cXBVWG91ZEdWVC9DdWdJaDE3K0ZTT2wzcFh3SGJ5NGRjN3VHMnI2RnNFaTdo?= =?utf-8?B?TjdlYWcvWXFQeld4QjhSeHl3Lzd6YzNmTlA3c3RGd1hHUHZqMTdjOFVrMmp1?= =?utf-8?B?a3dZR0JJaHpZVndjUlh1ZDdPTE9OK2dNUGpDWEEyS2xESThoNWs5RUNVTlRI?= =?utf-8?B?S1M1ejNabEkwR3JWMDFVUjhzVzltVVhudzVZZWNsbjZqcHZvQnArOFoydUhB?= =?utf-8?B?Uml3OTRLSWRaVWM3NC9ad0luV0JtTlF4YjlKUWp5VjNNcHVWRVpmL2w2am5t?= =?utf-8?B?WE0xeTdud09wV1VMWjVPRExhRzJlUFB5Zkk5TUdRb0l1dUF6bERhTjRCOGwr?= =?utf-8?B?MVBZZk9ZUFNvckp1SkI0VDdWVjZ3Q1ZWVHBMVVArWVpsMy9NNzdhZEl5TEY1?= =?utf-8?B?bWxNNm8rSnZhcDZGTTVZaUl0WkZZR0ZqZ3FrYlZaZE9FbVJ5UnhIQ29Zbk1K?= =?utf-8?B?dm9UTlhtbWZMZkZEK2ovVWl5YnJrcDRkblJWeStPemd0RGs1SWlIVFMxQm1Y?= =?utf-8?Q?8n0ui4nEEpfTapBD/imerO+aX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04196880-a72f-45b9-7983-08dbeb37ba45 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 08:47:58.4969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k4P8djQb3S73wJqCpogsV3mSbIU698U8o3Rm9UmshGz1R97EejneYHwgchMW+xxZYL/B1pqR/aPISLWMnJgQ6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8084 X-Spam-Status: No, score=-3026.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22.11.2023 08:46, Cui, Lili wrote: >>>>> @@ -9087,7 +9104,7 @@ get_valid_dis386 (const struct dis386 *dp, >>>> instr_info *ins) >>>>> return &err_opcode; >>>>> >>>>> /* Set vector length. */ >>>>> - if (ins->modrm.mod == 3 && ins->vex.b) >>>>> + if (ins->modrm.mod == 3 && ins->vex.b && ins->evex_type == >>>>> + evex_default) >>>>> ins->vex.length = 512; >>>>> else >>>>> { >>>> >>>> Is this change really needed for anything? >>> >>> If it's NDD and ins->vex.b ==1, we need to avoid giving NDD a wrong value. >> >> But this is recording ->vex.length, not anything NDD related (afaics). > > There are some instructions that use OP_VEX, which will use ->vex.length. > > For example: > "addB", { VexGb, Eb, Gb } But that's a GPR, for which ->vex.length is not supposed to have an effect. Jan